You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bing-Qian Luan <bi...@icloud.com> on 2017/01/11 09:27:38 UTC
Review Request 55409: AURORA-1873 CuratorServiceGroupMonitor.LOG
should use its own logger name
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55409/
-----------------------------------------------------------
Review request for Aurora and Joshua Cohen.
Repository: aurora
Description
-------
AURORA-1873 CuratorServiceGroupMonitor.LOG should use its own logger name
Diffs
-----
commons/src/main/java/org/apache/aurora/common/application/ShutdownRegistry.java 5ee740fed58175f0b42c45320a4d76c2d5260a63
src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java 0b86fb6eb95d74a464358e8c1fcd473b52a9afbc
src/main/java/org/apache/aurora/scheduler/discovery/ServiceDiscoveryModule.java 07a63023511c5bd05a5d9c8d7a421a1091854d4a
src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java 18edb01113f605398837ac3957a5662abc3bb755
src/main/java/org/apache/aurora/scheduler/storage/backup/StorageBackup.java 92b7b82a2eeaf7688606645cedc837d4467ee1bc
Diff: https://reviews.apache.org/r/55409/diff/
Testing
-------
./gradlew clean build
Please NOTE: I didn't run any integration tests.
Thanks,
Bing-Qian Luan
Re: Review Request 55409: AURORA-1873 CuratorServiceGroupMonitor.LOG
should use its own logger name
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55409/#review161250
-----------------------------------------------------------
Ship it!
Thanks for cleaning this up!
- Joshua Cohen
On Jan. 11, 2017, 9:27 a.m., Bing-Qian Luan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55409/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2017, 9:27 a.m.)
>
>
> Review request for Aurora and Joshua Cohen.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-1873 CuratorServiceGroupMonitor.LOG should use its own logger name
>
>
> Diffs
> -----
>
> commons/src/main/java/org/apache/aurora/common/application/ShutdownRegistry.java 5ee740fed58175f0b42c45320a4d76c2d5260a63
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java 0b86fb6eb95d74a464358e8c1fcd473b52a9afbc
> src/main/java/org/apache/aurora/scheduler/discovery/ServiceDiscoveryModule.java 07a63023511c5bd05a5d9c8d7a421a1091854d4a
> src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java 18edb01113f605398837ac3957a5662abc3bb755
> src/main/java/org/apache/aurora/scheduler/storage/backup/StorageBackup.java 92b7b82a2eeaf7688606645cedc837d4467ee1bc
>
> Diff: https://reviews.apache.org/r/55409/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build
>
> Please NOTE: I didn't run any integration tests.
>
>
> Thanks,
>
> Bing-Qian Luan
>
>
Re: Review Request 55409: AURORA-1873 CuratorServiceGroupMonitor.LOG
should use its own logger name
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55409/#review161196
-----------------------------------------------------------
Master (3bdf027) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 11, 2017, 9:27 a.m., Bing-Qian Luan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55409/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2017, 9:27 a.m.)
>
>
> Review request for Aurora and Joshua Cohen.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-1873 CuratorServiceGroupMonitor.LOG should use its own logger name
>
>
> Diffs
> -----
>
> commons/src/main/java/org/apache/aurora/common/application/ShutdownRegistry.java 5ee740fed58175f0b42c45320a4d76c2d5260a63
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java 0b86fb6eb95d74a464358e8c1fcd473b52a9afbc
> src/main/java/org/apache/aurora/scheduler/discovery/ServiceDiscoveryModule.java 07a63023511c5bd05a5d9c8d7a421a1091854d4a
> src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java 18edb01113f605398837ac3957a5662abc3bb755
> src/main/java/org/apache/aurora/scheduler/storage/backup/StorageBackup.java 92b7b82a2eeaf7688606645cedc837d4467ee1bc
>
> Diff: https://reviews.apache.org/r/55409/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build
>
> Please NOTE: I didn't run any integration tests.
>
>
> Thanks,
>
> Bing-Qian Luan
>
>
Re: Review Request 55409: AURORA-1873 CuratorServiceGroupMonitor.LOG
should use its own logger name
Posted by Bing-Qian Luan <bi...@icloud.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55409/
-----------------------------------------------------------
(Updated Jan. 11, 2017, 3:59 p.m.)
Review request for Aurora and Joshua Cohen.
Changes
-------
set ticket on rb.
Bugs: AURORA-1873
https://issues.apache.org/jira/browse/AURORA-1873
Repository: aurora
Description
-------
AURORA-1873 CuratorServiceGroupMonitor.LOG should use its own logger name
Diffs
-----
commons/src/main/java/org/apache/aurora/common/application/ShutdownRegistry.java 5ee740fed58175f0b42c45320a4d76c2d5260a63
src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java 0b86fb6eb95d74a464358e8c1fcd473b52a9afbc
src/main/java/org/apache/aurora/scheduler/discovery/ServiceDiscoveryModule.java 07a63023511c5bd05a5d9c8d7a421a1091854d4a
src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java 18edb01113f605398837ac3957a5662abc3bb755
src/main/java/org/apache/aurora/scheduler/storage/backup/StorageBackup.java 92b7b82a2eeaf7688606645cedc837d4467ee1bc
Diff: https://reviews.apache.org/r/55409/diff/
Testing
-------
./gradlew clean build
Please NOTE: I didn't run any integration tests.
Thanks,
Bing-Qian Luan