You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Mark Chu-Carroll <mc...@twopensource.com> on 2014/06/04 20:39:50 UTC
Review Request 22243: Variety of help fixes.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22243/
-----------------------------------------------------------
Review request for Aurora, David McLaughlin and Brian Wickman.
Bugs: aurora-437 and aurora-508
https://issues.apache.org/jira/browse/aurora-437
https://issues.apache.org/jira/browse/aurora-508
Repository: aurora
Description
-------
Variety of help fixes.
- Fixed glitch with string handling in "aurora help noun verb".
- Modified parameter name defaulting to produce better usage strings.
- Added whitespace between lines of a noun's usage message.
- Added missing parameter help messages for "job list" and "job status" parameters.
Diffs
-----
src/main/python/apache/aurora/client/cli/__init__.py fd6f96ebe4acd358409f145178ebf8ad5ea27d05
src/main/python/apache/aurora/client/cli/client.py 1fb5364894d230646592942434eb1da6554d5c05
src/main/python/apache/aurora/client/cli/config.py 034c68e52ac8d2fbabb9dbf4f397f1a4920d0122
src/main/python/apache/aurora/client/cli/cron.py c30a0a605412229f3e4cddbe8c5ae746f256e30c
src/main/python/apache/aurora/client/cli/jobs.py 8020c356aba9321ded20f06707ff3678aef61937
src/main/python/apache/aurora/client/cli/options.py 0d49bac2fa13ed5b156508a08a1af48c58582f8f
src/test/python/apache/aurora/client/api/test_sla.py 9c3bb6d386abbdbbfa8746639798ddca01d54fe9
src/test/python/apache/aurora/client/cli/test_config_noun.py 7a9d733835e204bfd179e698bc335435b837d24b
src/test/python/apache/aurora/client/cli/test_cron.py 049405a4323fc73102d6ac1dae2230be4325c530
src/test/python/apache/aurora/client/test_config.py 4b3e1499c7447792288f4b480cbd756c8e19a831
src/test/sh/org/apache/aurora/e2e/http_example.py 04f7fa5c9bf36a36b395d870db02b97f8e5b6c66
Diff: https://reviews.apache.org/r/22243/diff/
Testing
-------
Thanks,
Mark Chu-Carroll
Re: Review Request 22243: Variety of help fixes.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22243/
-----------------------------------------------------------
(Updated June 9, 2014, 4:13 p.m.)
Review request for Aurora, David McLaughlin and Brian Wickman.
Changes
-------
rebase
Bugs: aurora-437 and aurora-508
https://issues.apache.org/jira/browse/aurora-437
https://issues.apache.org/jira/browse/aurora-508
Repository: aurora
Description
-------
Variety of help fixes.
- Fixed glitch with string handling in "aurora help noun verb".
- Modified parameter name defaulting to produce better usage strings.
- Added whitespace between lines of a noun's usage message.
- Added missing parameter help messages for "job list" and "job status" parameters.
Diffs (updated)
-----
src/main/python/apache/aurora/client/cli/__init__.py 552f9f17881bdba7693a7a1ca0e40a7122c99abd
src/main/python/apache/aurora/client/cli/jobs.py e7c3ee4c5db788b50cc9d669fd04b2b26730f7e5
src/main/python/apache/aurora/client/cli/options.py f10ef4c3d694e3a5e313fa4b530146df81e92f56
Diff: https://reviews.apache.org/r/22243/diff/
Testing
-------
Thanks,
Mark Chu-Carroll
Re: Review Request 22243: Variety of help fixes.
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22243/#review45114
-----------------------------------------------------------
Ship it!
Ship It!
- David McLaughlin
On June 4, 2014, 6:39 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22243/
> -----------------------------------------------------------
>
> (Updated June 4, 2014, 6:39 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Brian Wickman.
>
>
> Bugs: aurora-437 and aurora-508
> https://issues.apache.org/jira/browse/aurora-437
> https://issues.apache.org/jira/browse/aurora-508
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Variety of help fixes.
>
> - Fixed glitch with string handling in "aurora help noun verb".
> - Modified parameter name defaulting to produce better usage strings.
> - Added whitespace between lines of a noun's usage message.
> - Added missing parameter help messages for "job list" and "job status" parameters.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/__init__.py fd6f96ebe4acd358409f145178ebf8ad5ea27d05
> src/main/python/apache/aurora/client/cli/client.py 1fb5364894d230646592942434eb1da6554d5c05
> src/main/python/apache/aurora/client/cli/config.py 034c68e52ac8d2fbabb9dbf4f397f1a4920d0122
> src/main/python/apache/aurora/client/cli/cron.py c30a0a605412229f3e4cddbe8c5ae746f256e30c
> src/main/python/apache/aurora/client/cli/jobs.py 8020c356aba9321ded20f06707ff3678aef61937
> src/main/python/apache/aurora/client/cli/options.py 0d49bac2fa13ed5b156508a08a1af48c58582f8f
> src/test/python/apache/aurora/client/api/test_sla.py 9c3bb6d386abbdbbfa8746639798ddca01d54fe9
> src/test/python/apache/aurora/client/cli/test_config_noun.py 7a9d733835e204bfd179e698bc335435b837d24b
> src/test/python/apache/aurora/client/cli/test_cron.py 049405a4323fc73102d6ac1dae2230be4325c530
> src/test/python/apache/aurora/client/test_config.py 4b3e1499c7447792288f4b480cbd756c8e19a831
> src/test/sh/org/apache/aurora/e2e/http_example.py 04f7fa5c9bf36a36b395d870db02b97f8e5b6c66
>
> Diff: https://reviews.apache.org/r/22243/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 22243: Variety of help fixes.
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22243/#review45112
-----------------------------------------------------------
Ship it!
modulo checkstyle nit
src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/22243/#comment79780>
surprised checkstyle-check doesn't warn about this. should be 2nl between statements.
- Brian Wickman
On June 4, 2014, 6:39 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22243/
> -----------------------------------------------------------
>
> (Updated June 4, 2014, 6:39 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Brian Wickman.
>
>
> Bugs: aurora-437 and aurora-508
> https://issues.apache.org/jira/browse/aurora-437
> https://issues.apache.org/jira/browse/aurora-508
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Variety of help fixes.
>
> - Fixed glitch with string handling in "aurora help noun verb".
> - Modified parameter name defaulting to produce better usage strings.
> - Added whitespace between lines of a noun's usage message.
> - Added missing parameter help messages for "job list" and "job status" parameters.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/__init__.py fd6f96ebe4acd358409f145178ebf8ad5ea27d05
> src/main/python/apache/aurora/client/cli/client.py 1fb5364894d230646592942434eb1da6554d5c05
> src/main/python/apache/aurora/client/cli/config.py 034c68e52ac8d2fbabb9dbf4f397f1a4920d0122
> src/main/python/apache/aurora/client/cli/cron.py c30a0a605412229f3e4cddbe8c5ae746f256e30c
> src/main/python/apache/aurora/client/cli/jobs.py 8020c356aba9321ded20f06707ff3678aef61937
> src/main/python/apache/aurora/client/cli/options.py 0d49bac2fa13ed5b156508a08a1af48c58582f8f
> src/test/python/apache/aurora/client/api/test_sla.py 9c3bb6d386abbdbbfa8746639798ddca01d54fe9
> src/test/python/apache/aurora/client/cli/test_config_noun.py 7a9d733835e204bfd179e698bc335435b837d24b
> src/test/python/apache/aurora/client/cli/test_cron.py 049405a4323fc73102d6ac1dae2230be4325c530
> src/test/python/apache/aurora/client/test_config.py 4b3e1499c7447792288f4b480cbd756c8e19a831
> src/test/sh/org/apache/aurora/e2e/http_example.py 04f7fa5c9bf36a36b395d870db02b97f8e5b6c66
>
> Diff: https://reviews.apache.org/r/22243/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>