You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "rich7420 (via GitHub)" <gi...@apache.org> on 2025/11/21 09:58:02 UTC
[PR] feat(services/seafile): Implement write returns metadata [opendal]
rich7420 opened a new pull request, #6810:
URL: https://github.com/apache/opendal/pull/6810
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Related #5693
# What changes are included in this PR?
This PR fetches file metadata via file_detail API after upload since the upload response doesn't include it.
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
none
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking-changes` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(services/seafile): Implement write returns metadata [opendal]
Posted by "rich7420 (via GitHub)" <gi...@apache.org>.
rich7420 commented on PR #6810:
URL: https://github.com/apache/opendal/pull/6810#issuecomment-3587945860
@Xuanwo thanks for the reminding! in the other words, maybe seafile doesn't return metadata?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(services/seafile): Implement write returns metadata [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #6810:
URL: https://github.com/apache/opendal/pull/6810#issuecomment-3586688889
Hi @rich7420, thank you for your efforts on this.
Sorry the context around this issue isn’t clear enough. I want to clarify that the `return metadata for write` behavior is best effort: we only return the metadata that the services provide to us. We shouldn’t call additional APIs to fetch that metadata. This ensures our behavior is zero cost: users only pay for what they actually use. On the other hand, users can call stat themselves after write if they really need it.
So we need to do some research before working on this to decide whether to just add a comment here, like this service doesn't return metadata, or implement the metadata parsing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(services/seafile): Implement write returns metadata [opendal]
Posted by "rich7420 (via GitHub)" <gi...@apache.org>.
rich7420 closed pull request #6810: feat(services/seafile): Implement write returns metadata
URL: https://github.com/apache/opendal/pull/6810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(services/seafile): Implement write returns metadata [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #6810:
URL: https://github.com/apache/opendal/pull/6810#issuecomment-3588004138
> maybe seafile doesn't return metadata?
Hi, I don't know. We need to read seafile's API docs to find out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(services/seafile): Implement write returns metadata [opendal]
Posted by "rich7420 (via GitHub)" <gi...@apache.org>.
rich7420 commented on PR #6810:
URL: https://github.com/apache/opendal/pull/6810#issuecomment-3588501663
No problem!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(services/seafile): Implement write returns metadata [opendal]
Posted by "rich7420 (via GitHub)" <gi...@apache.org>.
rich7420 commented on PR #6810:
URL: https://github.com/apache/opendal/pull/6810#issuecomment-3588025033
Ok , I'll try to find it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(services/seafile): Implement write returns metadata [opendal]
Posted by "rich7420 (via GitHub)" <gi...@apache.org>.
rich7420 commented on PR #6810:
URL: https://github.com/apache/opendal/pull/6810#issuecomment-3588084576
https://cloud.seafile.com/published/web-api/v2.1/file-upload.md
It seems we don’t get any metadata in the upload response if we don’t add the ret-json parameter to the request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(services/seafile): Implement write returns metadata [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #6810:
URL: https://github.com/apache/opendal/pull/6810#issuecomment-3588250340
> https://cloud.seafile.com/published/web-api/v2.1/file-upload.md It seems we don’t get any metadata in the upload response if we don’t add the ret-json parameter to the request.
Thank you for doing research on this, so we don't need to do anything for seafile. Can you comment back to the tracking issue and close this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org