You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Peter Bacsko (Jira)" <ji...@apache.org> on 2020/01/16 12:12:00 UTC
[jira] [Comment Edited] (YARN-10085) FS-CS converter: remove mixed
ordering policy check
[ https://issues.apache.org/jira/browse/YARN-10085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17016845#comment-17016845 ]
Peter Bacsko edited comment on YARN-10085 at 1/16/20 12:11 PM:
---------------------------------------------------------------
[~leftnoteasy] a question to you: I set YARN-9892 as a dependency for this JIRA.
However, that ticket might require some more discussions, implementation takes time, etc. Currently the converter does not allow converting an FS config which has mixed fifo/fair/drf policies.
But you said that the conversion must succeed regardless, we just print warnings if we encounter something that's not supported.
Question: what should we do? Eg. we have an FS config with default "fair" policy, with some queues being set to "drf". How should the tool behave in this scenario?
was (Author: pbacsko):
[~leftnoteasy] a question to you: I set YARN-9892 as a dependency for this JIRA.
However, that ticket might require some more discussions, implementation takes time, etc. Currently the converter does not allow converting an FS config which has mixed fifo/fair/drf policies.
But you said that the conversion should succeed regardless, we should only print warnings.
Question: what should we do? Eg. we have an FS config with default "fair" policy, with some queues being set to "drf". How should the tool behave in this scenario?
> FS-CS converter: remove mixed ordering policy check
> ---------------------------------------------------
>
> Key: YARN-10085
> URL: https://issues.apache.org/jira/browse/YARN-10085
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Peter Bacsko
> Assignee: Peter Bacsko
> Priority: Critical
>
> When YARN-9892 gets committed, this part will become unnecessary:
> {noformat}
> // Validate ordering policy
> if (queueConverter.isDrfPolicyUsedOnQueueLevel()) {
> if (queueConverter.isFifoOrFairSharePolicyUsed()) {
> throw new ConversionException(
> "DRF ordering policy cannot be used together with fifo/fair");
> } else {
> capacitySchedulerConfig.set(
> CapacitySchedulerConfiguration.RESOURCE_CALCULATOR_CLASS,
> DominantResourceCalculator.class.getCanonicalName());
> }
> }
> {noformat}
> We will be able to freely mix fifo/fair/drf, so let's get rid of this strict check and also rewrite {{FSQueueConverter.emitOrderingPolicy()}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org