You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/03 10:04:46 UTC
[GitHub] [flink] Myasuka commented on a change in pull request #11624:
[FLINK-16949] Enhance AbstractStreamOperatorTestHarness to use customized
TtlTimeProvider
Myasuka commented on a change in pull request #11624: [FLINK-16949] Enhance AbstractStreamOperatorTestHarness to use customized TtlTimeProvider
URL: https://github.com/apache/flink/pull/11624#discussion_r402898020
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamTaskStateInitializerImpl.java
##########
@@ -258,6 +258,10 @@ protected OperatorStateBackend operatorStateBackend(
}
}
+ protected TtlTimeProvider getTtlTimeProvider() {
Review comment:
I just don't want to introduce too many changes here. If we plan to inject this as a filed, I am in favor of moving `TtlTimeProvider` at operator level (by changing `StreamTaskStateInitializer#streamOperatorStateContext`) but not in the constructor which was [FLINK-14156](https://issues.apache.org/jira/browse/FLINK-14156) fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services