You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by sl...@apache.org on 2021/10/02 12:45:44 UTC
[maven-release] 01/03: [MRELEASE-1066] Use try-with-resources
This is an automated email from the ASF dual-hosted git repository.
slachiewicz pushed a commit to branch MRELEASE-1066
in repository https://gitbox.apache.org/repos/asf/maven-release.git
commit aab0aa3a24a045af39431082ad7e0879e9304006
Author: Sylwester Lachiewicz <sl...@apache.org>
AuthorDate: Sat Oct 2 12:10:00 2021 +0200
[MRELEASE-1066] Use try-with-resources
---
.../release/phase/AbstractBackupPomsPhaseTest.java | 23 +++++++++++-----------
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/maven-release-manager/src/test/java/org/apache/maven/shared/release/phase/AbstractBackupPomsPhaseTest.java b/maven-release-manager/src/test/java/org/apache/maven/shared/release/phase/AbstractBackupPomsPhaseTest.java
index ce8e00e..6f2c560 100644
--- a/maven-release-manager/src/test/java/org/apache/maven/shared/release/phase/AbstractBackupPomsPhaseTest.java
+++ b/maven-release-manager/src/test/java/org/apache/maven/shared/release/phase/AbstractBackupPomsPhaseTest.java
@@ -24,8 +24,11 @@ import org.apache.maven.model.io.xpp3.MavenXpp3Reader;
import org.apache.maven.project.MavenProject;
import org.apache.maven.shared.release.PlexusJUnit4TestCase;
import org.codehaus.plexus.util.ReaderFactory;
+import org.codehaus.plexus.util.xml.XmlStreamReader;
+import org.codehaus.plexus.util.xml.pull.XmlPullParserException;
import java.io.File;
+import java.io.IOException;
import java.util.ArrayList;
import java.util.List;
@@ -76,18 +79,16 @@ public abstract class AbstractBackupPomsPhaseTest
return reactorProjects;
}
- private MavenProject createMavenProject( File pomFile )
- throws Exception
+ private MavenProject createMavenProject( File pomFile ) throws IOException, XmlPullParserException
{
- MavenXpp3Reader reader = new MavenXpp3Reader();
-
- Model model = reader.read( ReaderFactory.newXmlReader( pomFile ) );
-
- MavenProject project = new MavenProject( model );
-
- project.setFile( pomFile );
-
- return project;
+ try ( XmlStreamReader xmlStreamReader = ReaderFactory.newXmlReader( pomFile ))
+ {
+ MavenXpp3Reader reader = new MavenXpp3Reader();
+ Model model = reader.read( xmlStreamReader );
+ MavenProject project = new MavenProject( model );
+ project.setFile( pomFile );
+ return project;
+ }
}
}