You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/28 02:36:22 UTC

[GitHub] [spark] cloud-fan commented on a diff in pull request #38415: [SPARK-40938][CONNECT] Support Alias for every type of Relation

cloud-fan commented on code in PR #38415:
URL: https://github.com/apache/spark/pull/38415#discussion_r1007551962


##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -47,6 +47,13 @@ message Relation {
 
     Unknown unknown = 999;
   }
+  // Optional. Every relation might have an alias.

Review Comment:
   I don't have a strong opinion, but not sure which one is better. We can also follow catalyst, and add a new plan `SubqueryAlias(child, alias)` 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org