[jira] [Commented] (FLINK-6561) GlobFilePathFilterTest#testExcludeFilenameWithStart fails on Windows

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-6561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007068#comment-16007068 ] 

ASF GitHub Bot commented on FLINK-6561:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/3878

    [FLINK-6561] Disable glob test on Windows

    This PR disables a test case in the `GlobFilePathFilterTest`. The test verified that a file name containing asterisks `(*)` was properly filtered out; this however can't succeed on Windows since asterisks aren't allowed in file names in the first place. The creation of a nio path for such a file name throws an exception.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 6561_glog_test

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3878.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3878
    
----
commit f75edf840a1fb8633543518449f9373e40598001
Author: zentol <ch...@apache.org>
Date:   2017-05-11T19:24:02Z

    [FLINK-6561] Disable glob test on Windows

----


> GlobFilePathFilterTest#testExcludeFilenameWithStart fails on Windows
> --------------------------------------------------------------------
>
>                 Key: FLINK-6561
>                 URL: https://issues.apache.org/jira/browse/FLINK-6561
>             Project: Flink
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 1.3.0, 1.4.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Trivial
>
> The test fails because it verifies that a file containing an asterisk {{*}} is still properly filtered. This character however is not allowed in file names, causing an exception when the nio Path is generated.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)