[GitHub] yanghua commented on a change in pull request #7287: [FLINK-11140][streaming] Fix empty child path check in Buckets

[GitBox <gi...@apache.org>]

yanghua commented on a change in pull request #7287: [FLINK-11140][streaming] Fix empty child path check in Buckets
URL: https://github.com/apache/flink/pull/7287#discussion_r240931304
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/Buckets.java
 ##########
 @@ -304,6 +304,10 @@ void close() {
 	}
 
 	private Path assembleBucketPath(BucketID bucketId) {
+		String child = bucketId.toString();
+		if ("".equals(child)) {
+			return basePath;
+		}
 		return new Path(basePath, bucketId.toString());
 
 Review comment:
   Now that you have given `bucketId.toString()` to the variable `child`, you can change it to: `return new Path(basePath, child);`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services