[jira] Commented: (AXIS2-2612) ServiceGroupContextTest fails

["Glen Daniels (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AXIS2-2612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12493254 ] 

Glen Daniels commented on AXIS2-2612:
-------------------------------------

This is fixed as of r534662.  Leaving this open until I check in another test case.

I still think we should NOT be using WS-Addressing for our session mechanism, for a variety of reasons.  If we switched to another custom header on the response rather than using <wsa:ReplyTo>, two things would happen - first, we would not need to depend on the addressing module (or addressing support from a peer) in order to handle sessions.  This means we could include and test session support directly in the kernel maven module without introducing a dependency.  Second, we would avoid problems with an off-label use of <ReplyTo> (as mentioned in AXIS2-2607) being misinterpreted.

Note that there is NO benefit to using addressing here, because both of the things our session mechanism does (using <ReplyTo> to mean "this EPR is to be used the next time you talk to me even though this MEP is complete", and interpreting a custom <ServiceGroupID> header) are already going beyond what the Addressing spec states, thus they are already custom Axis2 idioms.

Come to think of it, if we just used the Axis1 session header, we would immediately gain backwards-compatible sessions with Axis1 clients and servers....

> ServiceGroupContextTest fails
> -----------------------------
>
>                 Key: AXIS2-2612
>                 URL: https://issues.apache.org/jira/browse/AXIS2-2612
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Bug
>          Components: kernel
>            Reporter: Davanum Srinivas
>         Assigned To: Glen Daniels
>
> Glen,
> Please see the following test failure...Can you please check if any of the recent dispatcher changes broke it? 
> Testsuite: org.apache.axis2.engine.ServiceGroupContextTest
> Tests run: 1, Failures: 1, Errors: 0, Time elapsed: 5.701 sec
> ------------- Standard Output ---------------
> Server started on port 5555.....[SimpleHTTPServer] Stop called
> Server stopped .....[SimpleHTTPServer] Stop called
> ------------- ---------------- ---------------
> ------------- Standard Error -----------------
> log4j:WARN No appenders could be found for logger (org.apache.axiom.om.util.StAXUtils).
> log4j:WARN Please initialize the log4j system properly.
> ------------- ---------------- ---------------
> Testcase: testEchoXMLSync(org.apache.axis2.engine.ServiceGroupContextTest):     FAILED
> Number of requests should be 2 expected:<2> but was:<1>
> junit.framework.AssertionFailedError: Number of requests should be 2 expected:<2> but was:<1>
>         at org.apache.axis2.engine.ServiceGroupContextTest.testEchoXMLSync(ServiceGroupContextTest.java:107)
>         at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
>         at junit.extensions.TestSetup$1.protect(TestSetup.java:21)
>         at junit.extensions.TestSetup.run(TestSetup.java:25)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org