You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/06/18 05:15:27 UTC

[GitHub] [incubator-iotdb] Alima777 commented on a change in pull request #1384: [IOTDB-726] CheckPoint of MTree

Alima777 commented on a change in pull request #1384:
URL: https://github.com/apache/incubator-iotdb/pull/1384#discussion_r441972634



##########
File path: server/src/main/java/org/apache/iotdb/db/metadata/MTree.java
##########
@@ -72,27 +80,34 @@
 public class MTree implements Serializable {
 
   private static final long serialVersionUID = -4200394435237291964L;
+
   private MNode root;
+  private int snapshotLineNumber;

Review comment:
       Actually, it means the line number of mlog file that is serialized in snapshot. And the current name may be confusing because it's referred to the line number in snapshot log file. So you'd better change rename this variable as `serializedLineNumber`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org