You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Christopher Schultz <ch...@christopherschultz.net> on 2023/06/02 18:41:54 UTC
[VOTE] Release Apache Tomcat 10.1.10
The proposed Apache Tomcat 10.1.10 release is now available for
voting.
The notable changes compared to 10.1.9 are:
- Add support for virtual threads. (Java 21+ only)
- Update HTTP/2 to use the RFC-9218 prioritization scheme.
- Deprecate the xssProtectionEnabled from HttpHeaderSecurityFilter
and set the default value to false.
- Update Tomcat Native to 2.0.4 which includes binaries for Windows
built with OpenSSL 3.0.9.
For full details, see the change log:
https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html
Applications that run on Tomcat 9 and earlier will not run on Tomcat 10
without changes. Java EE applications designed for Tomcat 9 and earlier
may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat
will automatically convert them to Jakarta EE and copy them to the
webapps directory.
It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.10/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1439
The tag is:
https://github.com/apache/tomcat/tree/10.1.10
744f57269b2dda2dfcd252fff7f04744a7fcd5b8
The proposed 10.1.10 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 10.1.10
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 10.1.10
Posted by Rémy Maucherat <re...@apache.org>.
On Fri, Jun 2, 2023 at 8:43 PM Christopher Schultz
<ch...@christopherschultz.net> wrote:
>
> The proposed Apache Tomcat 10.1.10 release is now available for
> voting.
>
> The notable changes compared to 10.1.9 are:
>
> - Add support for virtual threads. (Java 21+ only)
>
> - Update HTTP/2 to use the RFC-9218 prioritization scheme.
>
> - Deprecate the xssProtectionEnabled from HttpHeaderSecurityFilter
> and set the default value to false.
>
> - Update Tomcat Native to 2.0.4 which includes binaries for Windows
> built with OpenSSL 3.0.9.
>
> For full details, see the change log:
> https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html
>
> Applications that run on Tomcat 9 and earlier will not run on Tomcat 10
> without changes. Java EE applications designed for Tomcat 9 and earlier
> may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat
> will automatically convert them to Jakarta EE and copy them to the
> webapps directory.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.10/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1439
>
> The tag is:
> https://github.com/apache/tomcat/tree/10.1.10
> 744f57269b2dda2dfcd252fff7f04744a7fcd5b8
>
> The proposed 10.1.10 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 10.1.10
Rémy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 10.1.10
Posted by Dimitris Soumis <ds...@redhat.com>.
+1
Tests pass on Linux.
On Fri, Jun 2, 2023 at 9:52 PM Christopher Schultz <
chris@christopherschultz.net> wrote:
> The proposed Apache Tomcat 10.1.10 release is now available for
> voting.
>
> The notable changes compared to 10.1.9 are:
>
> - Add support for virtual threads. (Java 21+ only)
>
> - Update HTTP/2 to use the RFC-9218 prioritization scheme.
>
> - Deprecate the xssProtectionEnabled from HttpHeaderSecurityFilter
> and set the default value to false.
>
> - Update Tomcat Native to 2.0.4 which includes binaries for Windows
> built with OpenSSL 3.0.9.
>
> For full details, see the change log:
> https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html
>
> Applications that run on Tomcat 9 and earlier will not run on Tomcat 10
> without changes. Java EE applications designed for Tomcat 9 and earlier
> may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat
> will automatically convert them to Jakarta EE and copy them to the
> webapps directory.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.10/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1439
>
> The tag is:
> https://github.com/apache/tomcat/tree/10.1.10
> 744f57269b2dda2dfcd252fff7f04744a7fcd5b8
>
> The proposed 10.1.10 release is:
> [ ] Broken - do not release
> [X ] Stable - go ahead and release as 10.1.10
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
Re: [VOTE] Release Apache Tomcat 10.1.10
Posted by Mark Thomas <ma...@apache.org>.
On 02/06/2023 19:41, Christopher Schultz wrote:
> The proposed 10.1.10 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 10.1.10
Tests pass on Windows, Linux, MacOS (M1) and MacOS (Intel).
I have confirmed that the release binaries are reproducible.
The source releases are only reproducible on Windows due to a
line-ending issue (my fault) with the file _listing.xslt that was added
to the tests. This has been fixed for the next set of releases.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 10.1.10
Posted by Christopher Schultz <ch...@christopherschultz.net>.
All,
On 6/2/23 2:41 PM, Christopher Schultz wrote:
> The proposed Apache Tomcat 10.1.10 release is now available for
> voting.
>
> The notable changes compared to 10.1.9 are:
>
> - Add support for virtual threads. (Java 21+ only)
>
> - Update HTTP/2 to use the RFC-9218 prioritization scheme.
>
> - Deprecate the xssProtectionEnabled from HttpHeaderSecurityFilter
> and set the default value to false.
>
> - Update Tomcat Native to 2.0.4 which includes binaries for Windows
> built with OpenSSL 3.0.9.
>
> For full details, see the change log:
> https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html
>
> Applications that run on Tomcat 9 and earlier will not run on Tomcat 10
> without changes. Java EE applications designed for Tomcat 9 and earlier
> may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat
> will automatically convert them to Jakarta EE and copy them to the
> webapps directory.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.10/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1439
>
> The tag is:
> https://github.com/apache/tomcat/tree/10.1.10
> 744f57269b2dda2dfcd252fff7f04744a7fcd5b8
>
> The proposed 10.1.10 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 10.1.10
+1 for stable release.
Unit tests pass on MacOS.
The unit tests that fail are expected except for "TcpFailureDetector"
which I will investigate.
Details:
* Environment
* Java (build): openjdk version "17.0.5" 2022-10-18 OpenJDK Runtime
Environment Temurin-17.0.5+8 (build 17.0.5+8) OpenJDK 64-Bit Server VM
Temurin-17.0.5+8 (build 17.0.5+8, mixed mode, sharing)
* Java (test): openjdk version "17.0.5" 2022-10-18 OpenJDK Runtime
Environment Temurin-17.0.5+8 (build 17.0.5+8) OpenJDK 64-Bit Server VM
Temurin-17.0.5+8 (build 17.0.5+8, mixed mode, sharing)
* OS: Darwin 21.6.0 x86_64
* cc: Apple clang version 12.0.0 (clang-1200.0.31.1)
* make: GNU Make 3.81
* OpenSSL: OpenSSL 3.0.7 1 Nov 2022 (Library: OpenSSL 3.0.7 1 Nov 2022)
* APR: 1.7.0
*
* Valid SHA-512 signature for apache-tomcat-10.1.10.zip
* Valid GPG signature for apache-tomcat-10.1.10.zip
* Valid SHA-512 signature for apache-tomcat-10.1.10.tar.gz
* Valid GPG signature for apache-tomcat-10.1.10.tar.gz
* Valid SHA-512 signature for apache-tomcat-10.1.10.exe
* Valid GPG signature for apache-tomcat-10.1.10.exe
* Valid SHA512 signature for apache-tomcat-10.1.10-src.zip
* Valid GPG signature for apache-tomcat-10.1.10-src.zip
* Valid SHA512 signature for apache-tomcat-10.1.10-src.tar.gz
* Valid GPG signature for apache-tomcat-10.1.10-src.tar.gz
*
* Binary Zip and tarball: Same
* Source Zip and tarball: Same
*
* Building dependencies returned: 0
* tcnative builds cleanly
* Tomcat builds cleanly
* Junit Tests: FAILED
*
* Tests that failed:
*
org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.NIO2.txt
* org.apache.tomcat.util.net.openssl.ciphers.TestCipher.NIO.txt
* org.apache.tomcat.util.net.openssl.ciphers.TestCipher.NIO2.txt
*
org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser.NIO.txt
*
org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser.NIO2.txt
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 10.1.10
Posted by Han Li <li...@apache.org>.
Hi Mark,
> On Jun 5, 2023, at 17:14, Mark Thomas <ma...@apache.org> wrote:
>
> On 05/06/2023 03:41, Han Li wrote:
>> Mark,
>> I encounter one error, as follow:
>> 20 Testcase: testPerformance took 11.807 sec
>> 21 FAILED
>> 22 5666
>> 23 junit.framework.AssertionFailedError: 5666
>> 24 at org.apache.catalina.mapper.TestMapperPerformance.testPerformance(TestMapperPerformance.java:49)
>> 25 at org.apache.catalina.mapper.TestMapperPerformance.testPerformance(TestMapperPerformance.java:32)
>> 26 at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>> 27 at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
>> 28 at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>> But I re-tested this entry, and it did not reproduce.
>> According to your comment [1], I think that need feedback to you.
>> // Takes ~1s on markt's laptop. If this takes more than 5s something
>> // probably needs looking at. If this fails repeatedly then we may need
>> // to increase this limit.
>> ENV:
>> OpenJDK 17.0.2
>> macOS 12.3.1
>> NOTE: I have never encountered this problem before, the difference between this and before is that I change the value of ‘test.threads' property from 8 to 12. ; )
>
> Hi Han,
>
> How many cores do you have available on that machine? If it is less than 12 you might be seeing the effects of context switching.
12, I think maybe I was doing something else at the time and it affected this test.
>
> Looking at the date on that test and the comment, I think the laptop being referenced is a work laptop that has since been replaced. My current personal desktop and work laptop both run the whole test in under 2s if I run it single threaded.
>
> The ~1s time refers to an individual test and there are 9 on those in the test overall so running the whole test in <2s indicates that the 5s per individual test limit should be very generous.
>
> If the failure only happened once and you can't repeat it I think it is safe to ignore it for now. If it happens again or we see similar issues with the CI systems then we might need to look more closely.
I have reran the whole test single thread twice, the result all under 1s. Look great. Let’s ignore it. ;)
Han
>
> Mark
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org <ma...@tomcat.apache.org>
> For additional commands, e-mail: dev-help@tomcat.apache.org <ma...@tomcat.apache.org>
Re: [VOTE] Release Apache Tomcat 10.1.10
Posted by Mark Thomas <ma...@apache.org>.
On 05/06/2023 03:41, Han Li wrote:
> Mark,
> I encounter one error, as follow:
>
> 20 Testcase: testPerformance took 11.807 sec
> 21 FAILED
> 22 5666
> 23 junit.framework.AssertionFailedError: 5666
> 24 at org.apache.catalina.mapper.TestMapperPerformance.testPerformance(TestMapperPerformance.java:49)
> 25 at org.apache.catalina.mapper.TestMapperPerformance.testPerformance(TestMapperPerformance.java:32)
> 26 at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 27 at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> 28 at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>
> But I re-tested this entry, and it did not reproduce.
>
> According to your comment [1], I think that need feedback to you.
>
> // Takes ~1s on markt's laptop. If this takes more than 5s something
> // probably needs looking at. If this fails repeatedly then we may need
> // to increase this limit.
>
> ENV:
> OpenJDK 17.0.2
> macOS 12.3.1
>
> NOTE: I have never encountered this problem before, the difference between this and before is that I change the value of ‘test.threads' property from 8 to 12. ; )
Hi Han,
How many cores do you have available on that machine? If it is less than
12 you might be seeing the effects of context switching.
Looking at the date on that test and the comment, I think the laptop
being referenced is a work laptop that has since been replaced. My
current personal desktop and work laptop both run the whole test in
under 2s if I run it single threaded.
The ~1s time refers to an individual test and there are 9 on those in
the test overall so running the whole test in <2s indicates that the 5s
per individual test limit should be very generous.
If the failure only happened once and you can't repeat it I think it is
safe to ignore it for now. If it happens again or we see similar issues
with the CI systems then we might need to look more closely.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 10.1.10
Posted by Han Li <li...@apache.org>.
Mark,
I encounter one error, as follow:
20 Testcase: testPerformance took 11.807 sec
21 FAILED
22 5666
23 junit.framework.AssertionFailedError: 5666
24 at org.apache.catalina.mapper.TestMapperPerformance.testPerformance(TestMapperPerformance.java:49)
25 at org.apache.catalina.mapper.TestMapperPerformance.testPerformance(TestMapperPerformance.java:32)
26 at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
27 at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
28 at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
But I re-tested this entry, and it did not reproduce.
According to your comment [1], I think that need feedback to you.
// Takes ~1s on markt's laptop. If this takes more than 5s something
// probably needs looking at. If this fails repeatedly then we may need
// to increase this limit.
ENV:
OpenJDK 17.0.2
macOS 12.3.1
NOTE: I have never encountered this problem before, the difference between this and before is that I change the value of ‘test.threads' property from 8 to 12. ; )
Han
> On Jun 3, 2023, at 02:41, Christopher Schultz <ch...@christopherschultz.net> wrote:
>
> The proposed Apache Tomcat 10.1.10 release is now available for
> voting.
>
> The notable changes compared to 10.1.9 are:
>
> - Add support for virtual threads. (Java 21+ only)
>
> - Update HTTP/2 to use the RFC-9218 prioritization scheme.
>
> - Deprecate the xssProtectionEnabled from HttpHeaderSecurityFilter
> and set the default value to false.
>
> - Update Tomcat Native to 2.0.4 which includes binaries for Windows
> built with OpenSSL 3.0.9.
>
> For full details, see the change log:
> https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html
>
> Applications that run on Tomcat 9 and earlier will not run on Tomcat 10 without changes. Java EE applications designed for Tomcat 9 and earlier may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat will automatically convert them to Jakarta EE and copy them to the webapps directory.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.10/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1439
>
> The tag is:
> https://github.com/apache/tomcat/tree/10.1.10
> 744f57269b2dda2dfcd252fff7f04744a7fcd5b8
>
> The proposed 10.1.10 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 10.1.10
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 10.1.10
Posted by Igal Sapir <is...@apache.org>.
On Fri, Jun 2, 2023 at 11:43 AM Christopher Schultz <
chris@christopherschultz.net> wrote:
> The proposed Apache Tomcat 10.1.10 release is now available for
> voting.
>
> The notable changes compared to 10.1.9 are:
>
> - Add support for virtual threads. (Java 21+ only)
>
> - Update HTTP/2 to use the RFC-9218 prioritization scheme.
>
> - Deprecate the xssProtectionEnabled from HttpHeaderSecurityFilter
> and set the default value to false.
>
> - Update Tomcat Native to 2.0.4 which includes binaries for Windows
> built with OpenSSL 3.0.9.
>
> For full details, see the change log:
> https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html
>
> Applications that run on Tomcat 9 and earlier will not run on Tomcat 10
> without changes. Java EE applications designed for Tomcat 9 and earlier
> may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat
> will automatically convert them to Jakarta EE and copy them to the
> webapps directory.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.10/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1439
>
> The tag is:
> https://github.com/apache/tomcat/tree/10.1.10
> 744f57269b2dda2dfcd252fff7f04744a7fcd5b8
>
> The proposed 10.1.10 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 10.1.10
>
+1
Igal
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
Re: [VOTE] Release Apache Tomcat 10.1.10
Posted by Han Li <li...@apache.org>.
> On Jun 3, 2023, at 02:41, Christopher Schultz <ch...@christopherschultz.net> wrote:
>
> The proposed Apache Tomcat 10.1.10 release is now available for
> voting.
>
> The notable changes compared to 10.1.9 are:
>
> - Add support for virtual threads. (Java 21+ only)
>
> - Update HTTP/2 to use the RFC-9218 prioritization scheme.
>
> - Deprecate the xssProtectionEnabled from HttpHeaderSecurityFilter
> and set the default value to false.
>
> - Update Tomcat Native to 2.0.4 which includes binaries for Windows
> built with OpenSSL 3.0.9.
>
> For full details, see the change log:
> https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html
>
> Applications that run on Tomcat 9 and earlier will not run on Tomcat 10 without changes. Java EE applications designed for Tomcat 9 and earlier may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat will automatically convert them to Jakarta EE and copy them to the webapps directory.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.10/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1439
>
> The tag is:
> https://github.com/apache/tomcat/tree/10.1.10
> 744f57269b2dda2dfcd252fff7f04744a7fcd5b8
>
> The proposed 10.1.10 release is:
> [ ] Broken - do not release
> [X ] Stable - go ahead and release as 10.1.10
Han
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org