You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/11/01 07:58:07 UTC
[GitHub] [echarts] sirviot opened a new issue, #17858: Bar charts not clipped when using filterMode: 'none'
sirviot opened a new issue, #17858:
URL: https://github.com/apache/echarts/issues/17858
### Version
5.3.3
### Link to Minimal Reproduction
https://gallery.echartsjs.com/editor.html?c=xI02xxZ13f&v=1
### Steps to Reproduce
From previous issue:
> I saw the very same title issue before, I thought the problem was solved, but when I tried it, there was actually no.
>
> https://github.com/apache/incubator-echarts/issues/10646
### Current Behavior
Soe bar chart bars are drawn outside of the chart area.
### Expected Behavior
Bars outside of the chart area should not be drawn.
### Environment
```markdown
- OS:
- Browser:
- Framework:
```
### Any additional comments?
Link to previous issue that was closed due to inactivity #12720.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] gowthamicp commented on issue #17858: Bar charts not clipped when using filterMode: 'none'
Posted by "gowthamicp (via GitHub)" <gi...@apache.org>.
gowthamicp commented on issue #17858:
URL: https://github.com/apache/echarts/issues/17858#issuecomment-1449704515
@Ovilia
Bar chart not clipped when filterMode none is selected .Below is the code to replicate the issue :
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] sirviot commented on issue #17858: Bar charts not clipped when using filterMode: 'none'
Posted by "sirviot (via GitHub)" <gi...@apache.org>.
sirviot commented on issue #17858:
URL: https://github.com/apache/echarts/issues/17858#issuecomment-1476170313
Nothing from my end. I'm hoping someone someday will have time to solve the issue. The issue still has the "pending" label, although it shouldn't be necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #17858: Bar charts not clipped when using filterMode: 'none'
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #17858:
URL: https://github.com/apache/echarts/issues/17858#issuecomment-1305315816
@sirviot Please provide a demo for the issue either with [Official Editor](https://echarts.apache.org/examples/editor.html), [CodePen](https://codepen.io/Ovilia/pen/dyYWXWM), [CodeSandbox](https://codesandbox.io/s/echarts-basic-example-template-mpfz1s) or [JSFiddle](https://jsfiddle.net/plainheart/e46ozpqj/7/).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] bosseDev commented on issue #17858: Bar charts not clipped when using filterMode: 'none'
Posted by "bosseDev (via GitHub)" <gi...@apache.org>.
bosseDev commented on issue #17858:
URL: https://github.com/apache/echarts/issues/17858#issuecomment-1422543015
Any update on this? I have exactly the same problem and i am a bit lost. Is there any workaround to solve this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] gitter-me commented on issue #17858: Bar charts not clipped when using filterMode: 'none'
Posted by "gitter-me (via GitHub)" <gi...@apache.org>.
gitter-me commented on issue #17858:
URL: https://github.com/apache/echarts/issues/17858#issuecomment-1558867723
I can confirm the exact issue.
This makes zooming problematic if a bar and line series are in one chart.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] gowthamicp commented on issue #17858: Bar charts not clipped when using filterMode: 'none'
Posted by "gowthamicp (via GitHub)" <gi...@apache.org>.
gowthamicp commented on issue #17858:
URL: https://github.com/apache/echarts/issues/17858#issuecomment-1466367284
Any update on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Skuperday commented on issue #17858: Bar charts not clipped when using filterMode: 'none'
Posted by GitBox <gi...@apache.org>.
Skuperday commented on issue #17858:
URL: https://github.com/apache/echarts/issues/17858#issuecomment-1397902071
Hello there! I ran into a same trouble a couple of days ago and found a solution how to use a bar chart and line chart so that the filtering does not cut off the data. This solved my problem with dataZoom
All that is needed is to change the weakFilter behavior logic in the sources. For a line chart, using filters causes problems when 1-2 points remain, but @cfwang123 was able to find a solution to the problem of filter behavior, I suggest using the old filter for the bar chart, and in all other situations, the modified filter @cfwang123
from:
`var thisLeftOut = value < valueWindow[0];`
`var thisRightOut = value > valueWindow[1]; `
to:
`if(seriesModel.subType === 'bar') {`
` var thisLeftOut = value < valueWindow[0];`
` var thisRightOut = value > valueWindow[1];`
`} else {`
` var thisLeftOut = value < valueWindow[0] && seriesData.get(dataDims[i], dataIndex+1) < valueWindow[0];`
` var thisRightOut = value > valueWindow[1] && seriesData.get(dataDims[i], dataIndex-1) > valueWindow[1];`
`}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] sirviot commented on issue #17858: Bar charts not clipped when using filterMode: 'none'
Posted by "sirviot (via GitHub)" <gi...@apache.org>.
sirviot commented on issue #17858:
URL: https://github.com/apache/echarts/issues/17858#issuecomment-1429334887
At least the lables should be updated, but I have no access to them. The issue is not missing a demo anymore and this is definitelty a bug and not a new feature request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] sirviot commented on issue #17858: Bar charts not clipped when using filterMode: 'none'
Posted by GitBox <gi...@apache.org>.
sirviot commented on issue #17858:
URL: https://github.com/apache/echarts/issues/17858#issuecomment-1306768663
Linked to a JSFiddle and attached an image to visualize the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [I] Bar charts not clipped when using filterMode: 'none' [echarts]
Posted by "sirviot (via GitHub)" <gi...@apache.org>.
sirviot commented on issue #17858:
URL: https://github.com/apache/echarts/issues/17858#issuecomment-1851931989
Is there any possibility to have the issue fixed in some near future? Also, the issue still has the "pending" label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org