You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pdfbox.apache.org by "John Hewson (JIRA)" <ji...@apache.org> on 2014/09/01 20:42:21 UTC
[jira] [Resolved] (PDFBOX-1991) Shading PaintContexts should not
depend on the page height
[ https://issues.apache.org/jira/browse/PDFBOX-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Hewson resolved PDFBOX-1991.
---------------------------------
Resolution: Fixed
Fix Version/s: 2.0.0
> Shading PaintContexts should not depend on the page height
> ----------------------------------------------------------
>
> Key: PDFBOX-1991
> URL: https://issues.apache.org/jira/browse/PDFBOX-1991
> Project: PDFBox
> Issue Type: Improvement
> Components: Rendering
> Affects Versions: 2.0.0
> Reporter: John Hewson
> Priority: Minor
> Labels: shading, shadingpattern
> Fix For: 2.0.0
>
>
> I'd like to remove the page height parameter from PDPattern as soon as possible because of doubts over its safety (i.e. the current stream being processed may be a pattern or a form, not a page). Before I do that we need to remove its only use, which is...
> The page height is passed to all shading PaintContext subclasses but it is only used in GouraudShadingContext. However, all other drawing in PDFBox is done using the native PDF y-axis which is flipped via a call to Graphics2D#scale(0, -1) but the following code in GouraudShadingContext flips the y-axis:
> v.point = new Point.Double(v.point.getX(), pageHeight + xform.getTranslateY() - v.point.getY());
> So it seems like this could be removed and the y-axis inversion done elsewhere with either a Matrix, AffineTransform or Grpahics2D#scale.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)