You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2017/01/11 22:25:51 UTC

Re: Review Request 55029: CMake: Added source groups to Stout build.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55029/#review161322
-----------------------------------------------------------


Ship it!




Ship It!

- Joseph Wu


On Dec. 24, 2016, 9:38 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55029/
> -----------------------------------------------------------
> 
> (Updated Dec. 24, 2016, 9:38 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich, and Joseph Wu.
> 
> 
> Bugs: MESOS-3542
>     https://issues.apache.org/jira/browse/MESOS-3542
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Currently in IDEs such as XCode and Visual Studio, all mesos source
> files are grouped into one huge folder, with no attempt made to reflect
> the hierarchy of folders that exist on disk.
> 
> This commit groups Stout files into relevant source groups so that they
> appear in a sensible directory structure in these IDEs.
> 
> In addition to beginning to directly address MESOS-3542, this is also
> (indirectly) the first step towards addressing the problem of breaking
> libmesos up into smaller binaries (MESOS-3542).
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/cmake/StoutConfigure.cmake 04e0f2f0d464d6740055eb1db2a8d41349879171 
>   3rdparty/stout/tests/CMakeLists.txt a09693d4b9a70faf1e4e337ec71ead2f0bbab0a2 
> 
> Diff: https://reviews.apache.org/r/55029/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>