You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Narayan Periwal <na...@inmobi.com> on 2015/09/21 09:28:20 UTC

Review Request 38546: FALCON-1462: Modify use of "testuser" in UTs and ITs

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38546/
-----------------------------------------------------------

Review request for Falcon.


Repository: falcon-git


Description
-------

As part of FALCON-1027 a few tests were introduced that hardcode "testuser" as the user. Use FalconTestUtil.TEST_USER_2 instead.


Diffs
-----

  common/src/test/java/org/apache/falcon/security/SecurityUtilTest.java 76d9f45 
  prism/src/test/java/org/apache/falcon/security/FalconAuthenticationFilterTest.java 5627e68 
  webapp/pom.xml 828f7f5 
  webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 577b60d 
  webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 6d375c0 
  webapp/src/test/java/org/apache/falcon/resource/MetadataResourceJerseyIT.java 749dfa5 

Diff: https://reviews.apache.org/r/38546/diff/


Testing
-------

Done.


Thanks,

Narayan Periwal

Re: Review Request 38546: FALCON-1462: Modify use of "testuser" in UTs and ITs

Posted by Sowmya Ramesh <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38546/#review100373
-----------------------------------------------------------

Ship it!


Ship It!

- Sowmya Ramesh


On Sept. 21, 2015, 7:28 a.m., Narayan Periwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38546/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2015, 7:28 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> As part of FALCON-1027 a few tests were introduced that hardcode "testuser" as the user. Use FalconTestUtil.TEST_USER_2 instead.
> 
> 
> Diffs
> -----
> 
>   common/src/test/java/org/apache/falcon/security/SecurityUtilTest.java 76d9f45 
>   prism/src/test/java/org/apache/falcon/security/FalconAuthenticationFilterTest.java 5627e68 
>   webapp/pom.xml 828f7f5 
>   webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 577b60d 
>   webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 6d375c0 
>   webapp/src/test/java/org/apache/falcon/resource/MetadataResourceJerseyIT.java 749dfa5 
> 
> Diff: https://reviews.apache.org/r/38546/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>

Re: Review Request 38546: FALCON-1462: Modify use of "testuser" in UTs and ITs

Posted by Sowmya Ramesh <sr...@hortonworks.com>.

> On Sept. 21, 2015, 5 p.m., Sowmya Ramesh wrote:
> > webapp/pom.xml, line 88
> > <https://reviews.apache.org/r/38546/diff/1/?file=1077931#file1077931line88>
> >
> >     Why is this change required? Also why do we have two dependency instances for falcon-common?
> 
> Narayan Periwal wrote:
>     FalconTestUtil.java is in the common's module and we use this in webapp. For this, we have to add this as a separate dependency.<version>${project.version}</version>: This change was required because we dont have the falcon-common dependency(that also has type as "test-jar") in the main pom, so we need to specify the version here.

Won't the below change work instead of having two dependency instances for falcon-common?

<dependency>
            <groupId>org.apache.falcon</groupId>
            <artifactId>falcon-common</artifactId>
            <version>${project.version}</version>
            <type>test-jar</type>
            <scope>test</scope>
            <exclusions>
                <exclusion>
                    <groupId>javax.servlet.jsp</groupId>
                    <artifactId>jsp-api</artifactId>
                </exclusion>
            </exclusions>
        </dependency>


- Sowmya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38546/#review99760
-----------------------------------------------------------


On Sept. 21, 2015, 7:28 a.m., Narayan Periwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38546/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2015, 7:28 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> As part of FALCON-1027 a few tests were introduced that hardcode "testuser" as the user. Use FalconTestUtil.TEST_USER_2 instead.
> 
> 
> Diffs
> -----
> 
>   common/src/test/java/org/apache/falcon/security/SecurityUtilTest.java 76d9f45 
>   prism/src/test/java/org/apache/falcon/security/FalconAuthenticationFilterTest.java 5627e68 
>   webapp/pom.xml 828f7f5 
>   webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 577b60d 
>   webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 6d375c0 
>   webapp/src/test/java/org/apache/falcon/resource/MetadataResourceJerseyIT.java 749dfa5 
> 
> Diff: https://reviews.apache.org/r/38546/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>

Re: Review Request 38546: FALCON-1462: Modify use of "testuser" in UTs and ITs

Posted by Sowmya Ramesh <sr...@hortonworks.com>.

> On Sept. 21, 2015, 5 p.m., Sowmya Ramesh wrote:
> > webapp/pom.xml, line 88
> > <https://reviews.apache.org/r/38546/diff/1/?file=1077931#file1077931line88>
> >
> >     Why is this change required? Also why do we have two dependency instances for falcon-common?
> 
> Narayan Periwal wrote:
>     FalconTestUtil.java is in the common's module and we use this in webapp. For this, we have to add this as a separate dependency.<version>${project.version}</version>: This change was required because we dont have the falcon-common dependency(that also has type as "test-jar") in the main pom, so we need to specify the version here.
> 
> Sowmya Ramesh wrote:
>     Won't the below change work instead of having two dependency instances for falcon-common?
>     
>     <dependency>
>                 <groupId>org.apache.falcon</groupId>
>                 <artifactId>falcon-common</artifactId>
>                 <version>${project.version}</version>
>                 <type>test-jar</type>
>                 <scope>test</scope>
>                 <exclusions>
>                     <exclusion>
>                         <groupId>javax.servlet.jsp</groupId>
>                         <artifactId>jsp-api</artifactId>
>                     </exclusion>
>                 </exclusions>
>             </dependency>

My bad. I understand now that scope test dependency is required for IT tests. LGTM!


- Sowmya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38546/#review99760
-----------------------------------------------------------


On Sept. 21, 2015, 7:28 a.m., Narayan Periwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38546/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2015, 7:28 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> As part of FALCON-1027 a few tests were introduced that hardcode "testuser" as the user. Use FalconTestUtil.TEST_USER_2 instead.
> 
> 
> Diffs
> -----
> 
>   common/src/test/java/org/apache/falcon/security/SecurityUtilTest.java 76d9f45 
>   prism/src/test/java/org/apache/falcon/security/FalconAuthenticationFilterTest.java 5627e68 
>   webapp/pom.xml 828f7f5 
>   webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 577b60d 
>   webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 6d375c0 
>   webapp/src/test/java/org/apache/falcon/resource/MetadataResourceJerseyIT.java 749dfa5 
> 
> Diff: https://reviews.apache.org/r/38546/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>

Re: Review Request 38546: FALCON-1462: Modify use of "testuser" in UTs and ITs

Posted by Narayan Periwal <na...@inmobi.com>.

> On Sept. 21, 2015, 5 p.m., Sowmya Ramesh wrote:
> > webapp/pom.xml, line 88
> > <https://reviews.apache.org/r/38546/diff/1/?file=1077931#file1077931line88>
> >
> >     Why is this change required? Also why do we have two dependency instances for falcon-common?

FalconTestUtil.java is in the common's module and we use this in webapp. For this, we have to add this as a separate dependency.<version>${project.version}</version>: This change was required because we dont have the falcon-common dependency(that also has type as "test-jar") in the main pom, so we need to specify the version here.


- Narayan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38546/#review99760
-----------------------------------------------------------


On Sept. 21, 2015, 7:28 a.m., Narayan Periwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38546/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2015, 7:28 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> As part of FALCON-1027 a few tests were introduced that hardcode "testuser" as the user. Use FalconTestUtil.TEST_USER_2 instead.
> 
> 
> Diffs
> -----
> 
>   common/src/test/java/org/apache/falcon/security/SecurityUtilTest.java 76d9f45 
>   prism/src/test/java/org/apache/falcon/security/FalconAuthenticationFilterTest.java 5627e68 
>   webapp/pom.xml 828f7f5 
>   webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 577b60d 
>   webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 6d375c0 
>   webapp/src/test/java/org/apache/falcon/resource/MetadataResourceJerseyIT.java 749dfa5 
> 
> Diff: https://reviews.apache.org/r/38546/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>

Re: Review Request 38546: FALCON-1462: Modify use of "testuser" in UTs and ITs

Posted by Sowmya Ramesh <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38546/#review99760
-----------------------------------------------------------



webapp/pom.xml (line 88)
<https://reviews.apache.org/r/38546/#comment156747>

    Why is this change required? Also why do we have two dependency instances for falcon-common?


- Sowmya Ramesh


On Sept. 21, 2015, 7:28 a.m., Narayan Periwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38546/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2015, 7:28 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> As part of FALCON-1027 a few tests were introduced that hardcode "testuser" as the user. Use FalconTestUtil.TEST_USER_2 instead.
> 
> 
> Diffs
> -----
> 
>   common/src/test/java/org/apache/falcon/security/SecurityUtilTest.java 76d9f45 
>   prism/src/test/java/org/apache/falcon/security/FalconAuthenticationFilterTest.java 5627e68 
>   webapp/pom.xml 828f7f5 
>   webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 577b60d 
>   webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 6d375c0 
>   webapp/src/test/java/org/apache/falcon/resource/MetadataResourceJerseyIT.java 749dfa5 
> 
> Diff: https://reviews.apache.org/r/38546/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>