You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Violeta Georgieva <mi...@gmail.com> on 2015/03/26 09:31:32 UTC

[VOTE] Release Apache Tomcat 7.0.60

The proposed Apache Tomcat 7.0.60 release is now available for voting.

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.60/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1040/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_60/

The proposed 7.0.60 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 7.0.60 Stable

Regards,
Violeta

Re: [VOTE] Release Apache Tomcat 7.0.60

Posted by Violeta Georgieva <mi...@gmail.com>.
2015-03-26 15:40 GMT+02:00 Ognjen Blagojevic <ognjen.d.blagojevic@gmail.com
>:
>
> On 26.3.2015 14:23, Ognjen Blagojevic wrote:
>>
>> On 26.3.2015 9:31, Violeta Georgieva wrote:
>>>
>>> The proposed 7.0.60 release is:
>>> [X] Broken - do not release
>>> [ ] Stable - go ahead and release as 7.0.60 Stable
>
> ...
>>
>> I'm still investigating why this doesn't work as expected.
>
>
> It was introduced in 1662994, in method
AbstractEndpoint.testServerCipherSuitesOrderSupport (reformatted for
clarity):
>
> if (JreCompat.isJre8Available()) {
>   throw new UnsupportedOperationException(
>     sm.getString("endpoint.jsse.cannotHonorServerCipherOrder"));
>
> Condition is wrong, it should throw exception only if Jre8 is NOT
available:
>
> if (!JreCompat.isJre8Available()) {
>   throw new UnsupportedOperationException(
>     sm.getString("endpoint.jsse.cannotHonorServerCipherOrder"));
>

I've just prepared a patch ;).

Index: AbstractEndpoint.java
===================================================================
--- AbstractEndpoint.java (revision 1669289)
+++ AbstractEndpoint.java (working copy)
@@ -654,7 +654,7 @@
     private void testServerCipherSuitesOrderSupport() {
         // Only test this feature if the user explicitly requested its use.
         if(!"".equals(getUseServerCipherSuitesOrder().trim())) {
-            if (JreCompat.isJre8Available()) {
+            if (!JreCompat.isJre8Available()) {
                 throw new UnsupportedOperationException(

 sm.getString("endpoint.jsse.cannotHonorServerCipherOrder"));
             }


>
> -Ognjen
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>

Re: [VOTE] Release Apache Tomcat 7.0.60

Posted by Ognjen Blagojevic <og...@gmail.com>.
On 26.3.2015 14:23, Ognjen Blagojevic wrote:
> On 26.3.2015 9:31, Violeta Georgieva wrote:
>> The proposed 7.0.60 release is:
>> [X] Broken - do not release
>> [ ] Stable - go ahead and release as 7.0.60 Stable
...
> I'm still investigating why this doesn't work as expected.

It was introduced in 1662994, in method 
AbstractEndpoint.testServerCipherSuitesOrderSupport (reformatted for 
clarity):

if (JreCompat.isJre8Available()) {
   throw new UnsupportedOperationException(
     sm.getString("endpoint.jsse.cannotHonorServerCipherOrder"));

Condition is wrong, it should throw exception only if Jre8 is NOT available:

if (!JreCompat.isJre8Available()) {
   throw new UnsupportedOperationException(
     sm.getString("endpoint.jsse.cannotHonorServerCipherOrder"));


-Ognjen

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release Apache Tomcat 7.0.60

Posted by Ognjen Blagojevic <og...@gmail.com>.
On 26.3.2015 9:31, Violeta Georgieva wrote:
> The proposed 7.0.60 release is:
> [X] Broken - do not release
> [ ] Stable - go ahead and release as 7.0.60 Stable

(non-binding vote)

Tested .zip distribution on Windows 7 64-bit, Oracle JDK 1.8.0_40.

Tested BIO and NIO connector option useServerCipherSuitesOrder="true":

Throws exception with JDK 1.8.0_40, and that shouldn't happen:

======
??? 26, 2015 1:46:56 PM 
org.apache.catalina.startup.VersionLoggerListener log
INFO: Server version:        Apache Tomcat/7.0.60
...
??? 26, 2015 1:46:56 PM 
org.apache.catalina.startup.VersionLoggerListener log
INFO: JVM Version:           1.8.0_40-b26
...
SEVERE: Failed to initialize end point associated with ProtocolHandler 
["http-bio-443"] java.lang.UnsupportedOperationException: Java Runtime 
does not support "useServerCipherSuitesOrder". You must use Java 8 or 
later to use this feature.
-----

I'm still investigating why this doesn't work as expected.

-Ognjen

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org