You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/07/13 14:56:39 UTC

[GitHub] [arrow-datafusion] alamb opened a new issue, #6955: Regression: bit_and aggregate function is incorrect

alamb opened a new issue, #6955:
URL: https://github.com/apache/arrow-datafusion/issues/6955

   ### Describe the bug
   
   https://github.com/apache/arrow-datafusion/pull/6904 introduced a bug where `bit_and` when a GROUP BY will now return zero always
   
   This was found with the tests added in https://github.com/apache/arrow-datafusion/pull/6952
   
   ```
   External error: query result mismatch:
   [SQL] SELECT
     bit_and(c1),
     bit_and(c2),
     bit_and(c3),
     bit_or(c1),
     bit_or(c2),
     bit_or(c3),
     bit_xor(c1),
     bit_xor(c2),
     bit_xor(c3),
     tag
   FROM bit_aggregate_functions
   GROUP BY tag
   ORDER BY tag
   [Diff] (-expected|+actual)
   -   1 8 11 13 14 11 12 6 11 A
   -   33 11 NULL 33 11 NULL 33 11 NULL B
   +   0 0 0 13 14 11 12 6 11 A
   +   0 0 NULL 33 11 NULL 33 11 NULL B
   at tests/sqllogictests/test_files/aggregate.slt:1546
   ```
   
   ### To Reproduce
   
   _No response_
   
   ### Expected behavior
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb closed issue #6955: Regression: bit_and aggregate function is incorrect

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #6955: Regression: bit_and aggregate function is incorrect
URL: https://github.com/apache/arrow-datafusion/issues/6955


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on issue #6955: Regression: bit_and aggregate function is incorrect

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #6955:
URL: https://github.com/apache/arrow-datafusion/issues/6955#issuecomment-1634881207

   > @alamb I think the main problem is with the default value. (for bit_and it is -1).
   
   
   You are 100% correct -- thank you @izveigor 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] izveigor commented on issue #6955: Regression: bit_and aggregate function is incorrect

Posted by "izveigor (via GitHub)" <gi...@apache.org>.
izveigor commented on issue #6955:
URL: https://github.com/apache/arrow-datafusion/issues/6955#issuecomment-1634487075

   @alamb I think the main problem is with the default value. (for `bit_and` it is `-1`).
   I have not studied in detail PR, but I think there is a mistake: https://github.com/apache/arrow-datafusion/pull/6904/files#diff-e7223136b64417c2704d9da50bea379cd297d210693693968c8276f59ec24c5bR88


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org