You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by "Ittay Dror (JIRA)" <ji...@apache.org> on 2009/10/29 15:23:59 UTC
[jira] Created: (BUILDR-335) excluding libraries from war is
confusing
excluding libraries from war is confusing
-----------------------------------------
Key: BUILDR-335
URL: https://issues.apache.org/jira/browse/BUILDR-335
Project: Buildr
Issue Type: Wish
Reporter: Ittay Dror
the confusion is from how ArchiveTask excludes files, but manifests itself in wars.
when i create a war package, it automatically adds all compile dependencies as libs. then during preparation it adds them with
path('WEB-INF/lib').include Buildr.artifacts(@libs)
now say i have a library foo.jar which i want to exclude.
these do not work:
war.exclude('**/foo.jar')
war.path('WEB-INF/lib').exclude('foo.jar')
only this works:
war.path('WEB-INF/lib').exclude('**/foo.jar')
knowing that this is the way is not intuitive an required me to dig through the code of archive.rb
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-335) excluding libraries from war is
confusing
Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883331#action_12883331 ]
Alex Boisvert commented on BUILDR-335:
--------------------------------------
Yes, most definitely.
> excluding libraries from war is confusing
> -----------------------------------------
>
> Key: BUILDR-335
> URL: https://issues.apache.org/jira/browse/BUILDR-335
> Project: Buildr
> Issue Type: Wish
> Affects Versions: 1.3.5
> Reporter: Ittay Dror
> Fix For: 1.4.1
>
>
> the confusion is from how ArchiveTask excludes files, but manifests itself in wars.
> when i create a war package, it automatically adds all compile dependencies as libs. then during preparation it adds them with
> path('WEB-INF/lib').include Buildr.artifacts(@libs)
> now say i have a library foo.jar which i want to exclude.
> these do not work:
> war.exclude('**/foo.jar')
> war.path('WEB-INF/lib').exclude('foo.jar')
> only this works:
> war.path('WEB-INF/lib').exclude('**/foo.jar')
> knowing that this is the way is not intuitive an required me to dig through the code of archive.rb
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (BUILDR-335) excluding libraries from war is
confusing
Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Boisvert reopened BUILDR-335:
----------------------------------
Darn. This spec fails:
it 'should exclude files regardless of the path where they are included' do
write 'src/main/java/com/example/included/Test.java', 'package com.example.included; class Test {}'
write 'src/main/java/com/example/excluded/Test.java', 'package com.example.excluded; class Test {}'
define('foo', :version=>'1.0') do
package(:war).exclude('WEB-INF/classes/com/example/excluded/**.class')
end
inspect_war do |files|
files.should include('WEB-INF/classes/com/example/included/Test.class')
files.should_not include('WEB-INF/classes/com/example/excluded/Test.class')
end
end
> excluding libraries from war is confusing
> -----------------------------------------
>
> Key: BUILDR-335
> URL: https://issues.apache.org/jira/browse/BUILDR-335
> Project: Buildr
> Issue Type: Wish
> Affects Versions: 1.3.5
> Reporter: Ittay Dror
> Assignee: Antoine Toulme
> Fix For: 1.4.1
>
>
> the confusion is from how ArchiveTask excludes files, but manifests itself in wars.
> when i create a war package, it automatically adds all compile dependencies as libs. then during preparation it adds them with
> path('WEB-INF/lib').include Buildr.artifacts(@libs)
> now say i have a library foo.jar which i want to exclude.
> these do not work:
> war.exclude('**/foo.jar')
> war.path('WEB-INF/lib').exclude('foo.jar')
> only this works:
> war.path('WEB-INF/lib').exclude('**/foo.jar')
> knowing that this is the way is not intuitive an required me to dig through the code of archive.rb
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-335) excluding libraries from war is
confusing
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910917#action_12910917 ]
Hudson commented on BUILDR-335:
-------------------------------
Integrated in Buildr-ci-build #121 (See [https://hudson.apache.org/hudson/job/Buildr-ci-build/121/])
BUILDR-335 follow up: excluding libraries from war is confusing
> excluding libraries from war is confusing
> -----------------------------------------
>
> Key: BUILDR-335
> URL: https://issues.apache.org/jira/browse/BUILDR-335
> Project: Buildr
> Issue Type: Wish
> Affects Versions: 1.3.5
> Reporter: Ittay Dror
> Assignee: Antoine Toulme
> Fix For: 1.4.2
>
>
> the confusion is from how ArchiveTask excludes files, but manifests itself in wars.
> when i create a war package, it automatically adds all compile dependencies as libs. then during preparation it adds them with
> path('WEB-INF/lib').include Buildr.artifacts(@libs)
> now say i have a library foo.jar which i want to exclude.
> these do not work:
> war.exclude('**/foo.jar')
> war.path('WEB-INF/lib').exclude('foo.jar')
> only this works:
> war.path('WEB-INF/lib').exclude('**/foo.jar')
> knowing that this is the way is not intuitive an required me to dig through the code of archive.rb
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-335) excluding libraries from war is
confusing
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902625#action_12902625 ]
Antoine Toulme commented on BUILDR-335:
---------------------------------------
Looking at the code, it seems to be a conflict in the order and the way we include and exclude. We include the classes in a prepare block and it overrides the exclude.
There are a few ways to fix the problem, I'll take a second look at it later.
> excluding libraries from war is confusing
> -----------------------------------------
>
> Key: BUILDR-335
> URL: https://issues.apache.org/jira/browse/BUILDR-335
> Project: Buildr
> Issue Type: Wish
> Affects Versions: 1.3.5
> Reporter: Ittay Dror
> Assignee: Antoine Toulme
> Fix For: 1.4.1
>
>
> the confusion is from how ArchiveTask excludes files, but manifests itself in wars.
> when i create a war package, it automatically adds all compile dependencies as libs. then during preparation it adds them with
> path('WEB-INF/lib').include Buildr.artifacts(@libs)
> now say i have a library foo.jar which i want to exclude.
> these do not work:
> war.exclude('**/foo.jar')
> war.path('WEB-INF/lib').exclude('foo.jar')
> only this works:
> war.path('WEB-INF/lib').exclude('**/foo.jar')
> knowing that this is the way is not intuitive an required me to dig through the code of archive.rb
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-335) excluding libraries from war is
confusing
Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902441#action_12902441 ]
Alex Boisvert commented on BUILDR-335:
--------------------------------------
The spec in the previous comment above (19/Aug/10 06:13 PM) still fails for me. I haven't committed it yet.
> excluding libraries from war is confusing
> -----------------------------------------
>
> Key: BUILDR-335
> URL: https://issues.apache.org/jira/browse/BUILDR-335
> Project: Buildr
> Issue Type: Wish
> Affects Versions: 1.3.5
> Reporter: Ittay Dror
> Assignee: Antoine Toulme
> Fix For: 1.4.1
>
>
> the confusion is from how ArchiveTask excludes files, but manifests itself in wars.
> when i create a war package, it automatically adds all compile dependencies as libs. then during preparation it adds them with
> path('WEB-INF/lib').include Buildr.artifacts(@libs)
> now say i have a library foo.jar which i want to exclude.
> these do not work:
> war.exclude('**/foo.jar')
> war.path('WEB-INF/lib').exclude('foo.jar')
> only this works:
> war.path('WEB-INF/lib').exclude('**/foo.jar')
> knowing that this is the way is not intuitive an required me to dig through the code of archive.rb
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BUILDR-335) excluding libraries from war is
confusing
Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Boisvert updated BUILDR-335:
---------------------------------
Fix Version/s: 1.4
Setting fix version to 1.4
Another reported case: http://buildr.markmail.org/thread/p642ylay6gpqsky3
> excluding libraries from war is confusing
> -----------------------------------------
>
> Key: BUILDR-335
> URL: https://issues.apache.org/jira/browse/BUILDR-335
> Project: Buildr
> Issue Type: Wish
> Reporter: Ittay Dror
> Fix For: 1.4
>
>
> the confusion is from how ArchiveTask excludes files, but manifests itself in wars.
> when i create a war package, it automatically adds all compile dependencies as libs. then during preparation it adds them with
> path('WEB-INF/lib').include Buildr.artifacts(@libs)
> now say i have a library foo.jar which i want to exclude.
> these do not work:
> war.exclude('**/foo.jar')
> war.path('WEB-INF/lib').exclude('foo.jar')
> only this works:
> war.path('WEB-INF/lib').exclude('**/foo.jar')
> knowing that this is the way is not intuitive an required me to dig through the code of archive.rb
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BUILDR-335) excluding libraries from war is
confusing
Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Boisvert updated BUILDR-335:
---------------------------------
Affects Version/s: 1.3.5
Fix Version/s: (was: 1.4)
1.4.1
At this point, I think this is better moved to 1.4.1. I think it's going to require some non-trivial amount of code to fix and I wouldn't want to delay 1.4.0 further.
> excluding libraries from war is confusing
> -----------------------------------------
>
> Key: BUILDR-335
> URL: https://issues.apache.org/jira/browse/BUILDR-335
> Project: Buildr
> Issue Type: Wish
> Affects Versions: 1.3.5
> Reporter: Ittay Dror
> Fix For: 1.4.1
>
>
> the confusion is from how ArchiveTask excludes files, but manifests itself in wars.
> when i create a war package, it automatically adds all compile dependencies as libs. then during preparation it adds them with
> path('WEB-INF/lib').include Buildr.artifacts(@libs)
> now say i have a library foo.jar which i want to exclude.
> these do not work:
> war.exclude('**/foo.jar')
> war.path('WEB-INF/lib').exclude('foo.jar')
> only this works:
> war.path('WEB-INF/lib').exclude('**/foo.jar')
> knowing that this is the way is not intuitive an required me to dig through the code of archive.rb
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (BUILDR-335) excluding libraries from war is
confusing
Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Boisvert reopened BUILDR-335:
----------------------------------
Reopening to mark as fixed instead of cannot-reproduce. The bug existed prior to Buildr 1.4.0.
> excluding libraries from war is confusing
> -----------------------------------------
>
> Key: BUILDR-335
> URL: https://issues.apache.org/jira/browse/BUILDR-335
> Project: Buildr
> Issue Type: Wish
> Affects Versions: 1.3.5
> Reporter: Ittay Dror
> Assignee: Antoine Toulme
> Fix For: 1.4.1
>
>
> the confusion is from how ArchiveTask excludes files, but manifests itself in wars.
> when i create a war package, it automatically adds all compile dependencies as libs. then during preparation it adds them with
> path('WEB-INF/lib').include Buildr.artifacts(@libs)
> now say i have a library foo.jar which i want to exclude.
> these do not work:
> war.exclude('**/foo.jar')
> war.path('WEB-INF/lib').exclude('foo.jar')
> only this works:
> war.path('WEB-INF/lib').exclude('**/foo.jar')
> knowing that this is the way is not intuitive an required me to dig through the code of archive.rb
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-335) excluding libraries from war is
confusing
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883323#action_12883323 ]
Antoine Toulme commented on BUILDR-335:
---------------------------------------
I'm wondering if this is still happening.
> excluding libraries from war is confusing
> -----------------------------------------
>
> Key: BUILDR-335
> URL: https://issues.apache.org/jira/browse/BUILDR-335
> Project: Buildr
> Issue Type: Wish
> Affects Versions: 1.3.5
> Reporter: Ittay Dror
> Fix For: 1.4.1
>
>
> the confusion is from how ArchiveTask excludes files, but manifests itself in wars.
> when i create a war package, it automatically adds all compile dependencies as libs. then during preparation it adds them with
> path('WEB-INF/lib').include Buildr.artifacts(@libs)
> now say i have a library foo.jar which i want to exclude.
> these do not work:
> war.exclude('**/foo.jar')
> war.path('WEB-INF/lib').exclude('foo.jar')
> only this works:
> war.path('WEB-INF/lib').exclude('**/foo.jar')
> knowing that this is the way is not intuitive an required me to dig through the code of archive.rb
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (BUILDR-335) excluding libraries from war is
confusing
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Toulme reassigned BUILDR-335:
-------------------------------------
Assignee: Antoine Toulme
> excluding libraries from war is confusing
> -----------------------------------------
>
> Key: BUILDR-335
> URL: https://issues.apache.org/jira/browse/BUILDR-335
> Project: Buildr
> Issue Type: Wish
> Affects Versions: 1.3.5
> Reporter: Ittay Dror
> Assignee: Antoine Toulme
> Fix For: 1.4.1
>
>
> the confusion is from how ArchiveTask excludes files, but manifests itself in wars.
> when i create a war package, it automatically adds all compile dependencies as libs. then during preparation it adds them with
> path('WEB-INF/lib').include Buildr.artifacts(@libs)
> now say i have a library foo.jar which i want to exclude.
> these do not work:
> war.exclude('**/foo.jar')
> war.path('WEB-INF/lib').exclude('foo.jar')
> only this works:
> war.path('WEB-INF/lib').exclude('**/foo.jar')
> knowing that this is the way is not intuitive an required me to dig through the code of archive.rb
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (BUILDR-335) excluding libraries from war is
confusing
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Toulme resolved BUILDR-335.
-----------------------------------
Resolution: Cannot Reproduce
Alex, I wrote two specs and could not reproduce the problem. You can see them in this commit.
11:31:01~/w/buildr>svn ci spec/java/packaging_spec.rb -m "specs for BUILDR-355: excluding libraries from war is confusing. Cannot reproduce the bug described."
Sending spec/java/packaging_spec.rb
Transmitting file data .
Committed revision 959742.
> excluding libraries from war is confusing
> -----------------------------------------
>
> Key: BUILDR-335
> URL: https://issues.apache.org/jira/browse/BUILDR-335
> Project: Buildr
> Issue Type: Wish
> Affects Versions: 1.3.5
> Reporter: Ittay Dror
> Assignee: Antoine Toulme
> Fix For: 1.4.1
>
>
> the confusion is from how ArchiveTask excludes files, but manifests itself in wars.
> when i create a war package, it automatically adds all compile dependencies as libs. then during preparation it adds them with
> path('WEB-INF/lib').include Buildr.artifacts(@libs)
> now say i have a library foo.jar which i want to exclude.
> these do not work:
> war.exclude('**/foo.jar')
> war.path('WEB-INF/lib').exclude('foo.jar')
> only this works:
> war.path('WEB-INF/lib').exclude('**/foo.jar')
> knowing that this is the way is not intuitive an required me to dig through the code of archive.rb
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-335) excluding libraries from war is
confusing
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901928#action_12901928 ]
Antoine Toulme commented on BUILDR-335:
---------------------------------------
Alex, this spec passes for me. I fixed the CI build ; it should pass there too.
> excluding libraries from war is confusing
> -----------------------------------------
>
> Key: BUILDR-335
> URL: https://issues.apache.org/jira/browse/BUILDR-335
> Project: Buildr
> Issue Type: Wish
> Affects Versions: 1.3.5
> Reporter: Ittay Dror
> Assignee: Antoine Toulme
> Fix For: 1.4.1
>
>
> the confusion is from how ArchiveTask excludes files, but manifests itself in wars.
> when i create a war package, it automatically adds all compile dependencies as libs. then during preparation it adds them with
> path('WEB-INF/lib').include Buildr.artifacts(@libs)
> now say i have a library foo.jar which i want to exclude.
> these do not work:
> war.exclude('**/foo.jar')
> war.path('WEB-INF/lib').exclude('foo.jar')
> only this works:
> war.path('WEB-INF/lib').exclude('**/foo.jar')
> knowing that this is the way is not intuitive an required me to dig through the code of archive.rb
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-335) excluding libraries from war is
confusing
Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771449#action_12771449 ]
Alex Boisvert commented on BUILDR-335:
--------------------------------------
Any chance you can provide a patch to make the above cases work as expected? I've been bitten as well and it's not nice.
> excluding libraries from war is confusing
> -----------------------------------------
>
> Key: BUILDR-335
> URL: https://issues.apache.org/jira/browse/BUILDR-335
> Project: Buildr
> Issue Type: Wish
> Reporter: Ittay Dror
>
> the confusion is from how ArchiveTask excludes files, but manifests itself in wars.
> when i create a war package, it automatically adds all compile dependencies as libs. then during preparation it adds them with
> path('WEB-INF/lib').include Buildr.artifacts(@libs)
> now say i have a library foo.jar which i want to exclude.
> these do not work:
> war.exclude('**/foo.jar')
> war.path('WEB-INF/lib').exclude('foo.jar')
> only this works:
> war.path('WEB-INF/lib').exclude('**/foo.jar')
> knowing that this is the way is not intuitive an required me to dig through the code of archive.rb
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-335) excluding libraries from war is
confusing
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902225#action_12902225 ]
Hudson commented on BUILDR-335:
-------------------------------
Integrated in Buildr-ci-build #104 (See [https://hudson.apache.org/hudson/job/Buildr-ci-build/104/])
> excluding libraries from war is confusing
> -----------------------------------------
>
> Key: BUILDR-335
> URL: https://issues.apache.org/jira/browse/BUILDR-335
> Project: Buildr
> Issue Type: Wish
> Affects Versions: 1.3.5
> Reporter: Ittay Dror
> Assignee: Antoine Toulme
> Fix For: 1.4.1
>
>
> the confusion is from how ArchiveTask excludes files, but manifests itself in wars.
> when i create a war package, it automatically adds all compile dependencies as libs. then during preparation it adds them with
> path('WEB-INF/lib').include Buildr.artifacts(@libs)
> now say i have a library foo.jar which i want to exclude.
> these do not work:
> war.exclude('**/foo.jar')
> war.path('WEB-INF/lib').exclude('foo.jar')
> only this works:
> war.path('WEB-INF/lib').exclude('**/foo.jar')
> knowing that this is the way is not intuitive an required me to dig through the code of archive.rb
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-335) excluding libraries from war is
confusing
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902473#action_12902473 ]
Antoine Toulme commented on BUILDR-335:
---------------------------------------
Apologies, I assumed you were referring to the spec by the same name currently in use.
> excluding libraries from war is confusing
> -----------------------------------------
>
> Key: BUILDR-335
> URL: https://issues.apache.org/jira/browse/BUILDR-335
> Project: Buildr
> Issue Type: Wish
> Affects Versions: 1.3.5
> Reporter: Ittay Dror
> Assignee: Antoine Toulme
> Fix For: 1.4.1
>
>
> the confusion is from how ArchiveTask excludes files, but manifests itself in wars.
> when i create a war package, it automatically adds all compile dependencies as libs. then during preparation it adds them with
> path('WEB-INF/lib').include Buildr.artifacts(@libs)
> now say i have a library foo.jar which i want to exclude.
> these do not work:
> war.exclude('**/foo.jar')
> war.path('WEB-INF/lib').exclude('foo.jar')
> only this works:
> war.path('WEB-INF/lib').exclude('**/foo.jar')
> knowing that this is the way is not intuitive an required me to dig through the code of archive.rb
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (BUILDR-335) excluding libraries from war is
confusing
Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Boisvert resolved BUILDR-335.
----------------------------------
Resolution: Fixed
Added another spec that shows bug is indeed fixed for:
package(:war).exclude('**/foo.jar')
boisvert@smudge:~/svn/buildr-trunk$ svn commit -m "Add another spec for BUILDR-335 (shows that it is indeed fixed)" spec/java/
Sending spec/java/packaging_spec.rb
Transmitting file data .
Committed revision 987327.
> excluding libraries from war is confusing
> -----------------------------------------
>
> Key: BUILDR-335
> URL: https://issues.apache.org/jira/browse/BUILDR-335
> Project: Buildr
> Issue Type: Wish
> Affects Versions: 1.3.5
> Reporter: Ittay Dror
> Assignee: Antoine Toulme
> Fix For: 1.4.1
>
>
> the confusion is from how ArchiveTask excludes files, but manifests itself in wars.
> when i create a war package, it automatically adds all compile dependencies as libs. then during preparation it adds them with
> path('WEB-INF/lib').include Buildr.artifacts(@libs)
> now say i have a library foo.jar which i want to exclude.
> these do not work:
> war.exclude('**/foo.jar')
> war.path('WEB-INF/lib').exclude('foo.jar')
> only this works:
> war.path('WEB-INF/lib').exclude('**/foo.jar')
> knowing that this is the way is not intuitive an required me to dig through the code of archive.rb
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BUILDR-335) excluding libraries from war is
confusing
Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Boisvert updated BUILDR-335:
---------------------------------
Fix Version/s: 1.4.2
(was: 1.4.1)
> excluding libraries from war is confusing
> -----------------------------------------
>
> Key: BUILDR-335
> URL: https://issues.apache.org/jira/browse/BUILDR-335
> Project: Buildr
> Issue Type: Wish
> Affects Versions: 1.3.5
> Reporter: Ittay Dror
> Assignee: Antoine Toulme
> Fix For: 1.4.2
>
>
> the confusion is from how ArchiveTask excludes files, but manifests itself in wars.
> when i create a war package, it automatically adds all compile dependencies as libs. then during preparation it adds them with
> path('WEB-INF/lib').include Buildr.artifacts(@libs)
> now say i have a library foo.jar which i want to exclude.
> these do not work:
> war.exclude('**/foo.jar')
> war.path('WEB-INF/lib').exclude('foo.jar')
> only this works:
> war.path('WEB-INF/lib').exclude('**/foo.jar')
> knowing that this is the way is not intuitive an required me to dig through the code of archive.rb
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (BUILDR-335) excluding libraries from war is
confusing
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Toulme resolved BUILDR-335.
-----------------------------------
Resolution: Fixed
Fixed in 1.4.2:
22:09:36~/w/buildr>svn ci CHANGELOG lib/buildr/java/packaging.rb spec -m "BUILDR-335 follow up: excluding libraries from war is confusing"
Sending CHANGELOG
Sending lib/buildr/java/packaging.rb
Sending spec/java/packaging_spec.rb
Transmitting file data ...
Committed revision 998400.
> excluding libraries from war is confusing
> -----------------------------------------
>
> Key: BUILDR-335
> URL: https://issues.apache.org/jira/browse/BUILDR-335
> Project: Buildr
> Issue Type: Wish
> Affects Versions: 1.3.5
> Reporter: Ittay Dror
> Assignee: Antoine Toulme
> Fix For: 1.4.2
>
>
> the confusion is from how ArchiveTask excludes files, but manifests itself in wars.
> when i create a war package, it automatically adds all compile dependencies as libs. then during preparation it adds them with
> path('WEB-INF/lib').include Buildr.artifacts(@libs)
> now say i have a library foo.jar which i want to exclude.
> these do not work:
> war.exclude('**/foo.jar')
> war.path('WEB-INF/lib').exclude('foo.jar')
> only this works:
> war.path('WEB-INF/lib').exclude('**/foo.jar')
> knowing that this is the way is not intuitive an required me to dig through the code of archive.rb
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.