You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by scottyaslan <gi...@git.apache.org> on 2016/07/29 17:44:48 UTC
[GitHub] nifi pull request #749: [NIFI-2303] Update lineage styles
GitHub user scottyaslan opened a pull request:
https://github.com/apache/nifi/pull/749
[NIFI-2303] Update lineage styles
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scottyaslan/nifi responsiveDevBranch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/749.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #749
----
commit c7bb1ce510df8acfbc26096c4f270a854fe88ab8
Author: Scott Aslan <ja...@hortonworks.com>
Date: 2016-07-29T17:42:32Z
[NIFI-2303] Update lineage styles
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #749: [NIFI-2303] Update lineage styles
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/749
Actually if you widen the screen the white background stops a sort of light gray background appears.
Also, there appears to be a way to close the screen in the top left of the lineage display window but unless you know it is there you cannot see it. You can click on the whitespace area in the top right corner though and it nicely closes just that window and goes back to your search.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #749: [NIFI-2303] Update lineage styles
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/749#discussion_r72835917
--- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/css/provenance.css ---
@@ -500,33 +524,40 @@ text.event-type.expand-parents, text.event-type.expand-children {
}
g.flowfile circle.context, g.event circle.context {
- stroke: #b70303;
+ stroke: #004849;
stroke-width: 1.5px;
}
-path.flowfile-icon-base {
- pointer-events: none;
+.flowfile-icon {
+ font-family: flowfont;
+ content: "\e808";
+ font-size: 16px;
+ color: #ad9897;
}
-path.flowfile-icon-base-outline {
- pointer-events: none;
-}
+/*path.flowfile-icon-base {*/
+ /*pointer-events: none;*/
+/*}*/
-path.flowfile-icon-mid {
- pointer-events: none;
-}
+/*path.flowfile-icon-base-outline {*/
+ /*pointer-events: none;*/
+/*}*/
-path.flowfile-icon-mid-outline {
- pointer-events: none;
-}
+/*path.flowfile-icon-mid {*/
+ /*pointer-events: none;*/
+/*}*/
-path.flowfile-icon-arc {
- pointer-events: none;
-}
+/*path.flowfile-icon-mid-outline {*/
--- End diff --
can this commented section be removed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #749: [NIFI-2303] Update lineage styles
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/749
reviewing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #749: [NIFI-2303] Update lineage styles
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/749
Ok went through it all. Can you check into the above comment on the icon blocking path highlighting. Otherwise, looks good!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #749: [NIFI-2303] Update lineage styles
Posted by moranr <gi...@git.apache.org>.
Github user moranr commented on the issue:
https://github.com/apache/nifi/pull/749
I can confirm the issues @joewitt has mentioned. Additionally, the context menus still appear to be picking up some old styles. They should look just like the component context menus.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #749: [NIFI-2303] Update lineage styles
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/749
also of note you can right click in the gray area when the screen widens and get the default context menu of the browser whereas if you stay over the white lineage area you cannot other than when right-clicking on an item (as expected and then it is a normal context menu)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #749: [NIFI-2303] Update lineage styles
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/749
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #749: [NIFI-2303] Update lineage styles
Posted by moranr <gi...@git.apache.org>.
Github user moranr commented on the issue:
https://github.com/apache/nifi/pull/749
Also for the context menus I recommend changing the Expand icon to _fa-plus-square_ (from _fa-plus-square-o_) and Collapse to _fa-minus-square_ (from _fa-minus-square-o_); this reversed style will better match the others
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #749: [NIFI-2303] Update lineage styles
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/749
cool checking it out now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #749: [NIFI-2303] Update lineage styles
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/749#discussion_r72835896
--- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/css/provenance.css ---
@@ -500,33 +524,40 @@ text.event-type.expand-parents, text.event-type.expand-children {
}
g.flowfile circle.context, g.event circle.context {
- stroke: #b70303;
+ stroke: #004849;
stroke-width: 1.5px;
}
-path.flowfile-icon-base {
- pointer-events: none;
+.flowfile-icon {
+ font-family: flowfont;
+ content: "\e808";
+ font-size: 16px;
+ color: #ad9897;
}
-path.flowfile-icon-base-outline {
- pointer-events: none;
-}
+/*path.flowfile-icon-base {*/
+ /*pointer-events: none;*/
+/*}*/
-path.flowfile-icon-mid {
- pointer-events: none;
-}
+/*path.flowfile-icon-base-outline {*/
+ /*pointer-events: none;*/
+/*}*/
-path.flowfile-icon-mid-outline {
- pointer-events: none;
-}
+/*path.flowfile-icon-mid {*/
+ /*pointer-events: none;*/
+/*}*/
-path.flowfile-icon-arc {
- pointer-events: none;
-}
+/*path.flowfile-icon-mid-outline {*/
+ /*pointer-events: none;*/
+/*}*/
-path.flowfile-icon-top {
- pointer-events: none;
-}
+/*path.flowfile-icon-arc {*/
--- End diff --
can this commented section be removed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #749: [NIFI-2303] Update lineage styles
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/749
Hovering over the icons in the lineage graph is extremely sensitive to have it highlight the path. I think it is getting confused about when you're over the image in teh circle versus other parts of the circle. When over image directly it doesn not highlight. Could you take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---