[jira] [Commented] (SPARK-14630) Code style: public abstract methods should have explicit return types

["Apache Spark (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-14630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240872#comment-15240872 ] 

Apache Spark commented on SPARK-14630:
--------------------------------------

User 'lw-lin' has created a pull request for this issue:
https://github.com/apache/spark/pull/12389

> Code style: public abstract methods should have explicit return types
> ---------------------------------------------------------------------
>
>                 Key: SPARK-14630
>                 URL: https://issues.apache.org/jira/browse/SPARK-14630
>             Project: Spark
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 2.0.0
>            Reporter: Liwei Lin
>            Priority: Minor
>
> Currently many public abstract methods (in abstract classes as well as traits) don't declare return types explicitly, such as 
> [o.a.s.streaming.dstream.InputDStream|https://github.com/apache/spark/blob/master/streaming/src/main/scala/org/apache/spark/streaming/dstream/InputDStream.scala#L110]:
> {code}
> def start() // should be: def start(): Unit
> def stop()  // should be: def stop(): Unit
> ...
> {code}
> [o.a.s.streaming.receiver.Receiver|https://github.com/apache/spark/blob/master/streaming/src/main/scala/org/apache/spark/streaming/receiver/Receiver.scala#L102]:
> {code}
> def onStart() // should be: def onStart(): Unit
> def onStop()  // should be: def onStop(): Unit
> ...
> {code}
> These methods exist in core, sql, streaming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org