[jira] [Commented] (OPENNLP-309) facilitating the specialization of POSDictionary

["William Colen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENNLP-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279841#comment-13279841 ] 

William Colen commented on OPENNLP-309:
---------------------------------------

I will replace POSDictionary by TagDictionary wherever possible. As far as I know it is a backward compatible change, isn't it?
I am facing the same problem Riccardo Tasso had. It is hard to replace the dictionary implementation because everywhere is using POSDictionary instead of the interface.
                
> facilitating the specialization of POSDictionary
> ------------------------------------------------
>
>                 Key: OPENNLP-309
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-309
>             Project: OpenNLP
>          Issue Type: Improvement
>          Components: POS Tagger
>            Reporter: Riccardo Tasso
>            Assignee: William Colen
>            Priority: Minor
>   Original Estimate: 6h
>  Remaining Estimate: 6h
>
> The train method in POSTaggerME receives in input a POSDictionary. This makes the implementation of custom dictionaries painful.
> I suggest to replace the POSDictionary input as a TagDictionary.
> Another improvement may also be the declaration of POSDictionary fields as protected, to help the extension of this class.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira