You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by nlivens <gi...@git.apache.org> on 2016/06/08 06:28:00 UTC
[GitHub] cloudstack pull request #1585: CLOUDSTACK-9399 : NPE during deletion of host...
GitHub user nlivens opened a pull request:
https://github.com/apache/cloudstack/pull/1585
CLOUDSTACK-9399 : NPE during deletion of host when clusterId is null
In most network plugins, there's a Resource class which will handle the communication with the actual device / underlaying client / ... They're configured as a host, so ACS is able to send commands towards it.
When they're configured as a host, the clusterId is not filled in since it's not relevant. Hence, the NPE while deleting this host because of ```long clusterId = host.getClusterId();```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nlivens/cloudstack CLOUDSTACK-9399
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1585.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1585
----
commit ffe72ca227a518907bca396603a2641e10c5d02d
Author: Nick Livens <ni...@nuagenetworks.net>
Date: 2016-06-03T09:04:09Z
CLOUDSTACK-9399 : NPE during deletion of host when clusterId is null
commit a64f0b903e8c421dfef33b1a2c7347548b5f7fa9
Author: Prashanth Manthena <pr...@alcatel-lucent.com>
Date: 2016-06-03T18:51:25Z
CLOUDSTACK-9399 : Marvin test coverage for Nuage VSP device CRUD operations
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1585: CLOUDSTACK-9399 : NPE during deletion of host...
Posted by nlivens <gi...@git.apache.org>.
Github user nlivens closed the pull request at:
https://github.com/apache/cloudstack/pull/1585
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1585: CLOUDSTACK-9399 : NPE during deletion of host when c...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1585
This is looking good. I will merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1585: CLOUDSTACK-9399 : NPE during deletion of host when c...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1585
This fixes a bug in the current master right? I suspect this is a candidate to be merged into the frozen master to be released in 4.9?
Please close and reopen this PR or force push to kick off Travis again, it timed out.
Can I get one more code review? Thx...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1585: CLOUDSTACK-9399 : NPE during deletion of host when c...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1585
The Java code fix seems good to me, never hurts to check for NULL, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1585: CLOUDSTACK-9399 : NPE during deletion of host when c...
Posted by KrisSterckx <gi...@git.apache.org>.
Github user KrisSterckx commented on the issue:
https://github.com/apache/cloudstack/pull/1585
@swill, you prefer i close and reopen? Thx
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1585: CLOUDSTACK-9399 : NPE during deletion of host when c...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1585
It is easier for you to just close and reopen, so that is usually the method people use. You can force push as well, either work...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1585: CLOUDSTACK-9399 : NPE during deletion of host when c...
Posted by prashanthvarma <gi...@git.apache.org>.
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1585
PR contents:
1) Fix for this bug
2) Marvin test coverage for Nuage VSP device CRUD operations including verifications for this bug fix.
PEP8 & PyFlakes compliance of the added Marvin code:
CloudStack$
CloudStack$ pep8 --max-line-length=150 test/integration/plugins/nuagevsp/.py
CloudStack$ pyflakes test/integration/plugins/nuagevsp/.py
CloudStack$
Marvin Test Run:
CloudStack$ nosetests --with-marvin --marvin-config=nuage.cfg /test/integration/plugins/nuagevsp/test_nuage_vsp.py
Marvin Test Run Results:
Test Nuage VSP SDN plugin with basic Isolated Network functionality ... === TestName: test_nuage_vsp | Status : SUCCESS ===
ok
Test Nuage VSP device in the Nuage VSP Physical Network ... === TestName: test_nuage_vsp_device | Status : SUCCESS ===
ok
Ran 2 tests in 447.773s
OK
Marvin Test Run Logs:
[results.txt](https://github.com/apache/cloudstack/files/304392/results.txt)
[runinfo.txt](https://github.com/apache/cloudstack/files/304393/runinfo.txt)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1585: CLOUDSTACK-9399 : NPE during deletion of host when c...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1585
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 0
Duration: 3h 58m 45s
```
**Associated Uploads**
**`/tmp/MarvinLogs/DeployDataCenter__Jun_10_2016_17_56_52_QZJDPZ:`**
* [dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1585/tmp/MarvinLogs/DeployDataCenter__Jun_10_2016_17_56_52_QZJDPZ/dc_entries.obj)
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1585/tmp/MarvinLogs/DeployDataCenter__Jun_10_2016_17_56_52_QZJDPZ/failed_plus_exceptions.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1585/tmp/MarvinLogs/DeployDataCenter__Jun_10_2016_17_56_52_QZJDPZ/runinfo.txt)
**`/tmp/MarvinLogs/test_network_B7VDME:`**
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1585/tmp/MarvinLogs/test_network_B7VDME/failed_plus_exceptions.txt)
* [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1585/tmp/MarvinLogs/test_network_B7VDME/results.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1585/tmp/MarvinLogs/test_network_B7VDME/runinfo.txt)
**`/tmp/MarvinLogs/test_vpc_routers_S6QVRP:`**
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1585/tmp/MarvinLogs/test_vpc_routers_S6QVRP/failed_plus_exceptions.txt)
* [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1585/tmp/MarvinLogs/test_vpc_routers_S6QVRP/results.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1585/tmp/MarvinLogs/test_vpc_routers_S6QVRP/runinfo.txt)
Uploads will be available until `2016-08-13 02:00:00 +0200 CEST`
*Comment created by [`upr comment`](https://github.com/cloudops/upr).*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1585: CLOUDSTACK-9399 : NPE during deletion of host...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1585
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1585: CLOUDSTACK-9399 : NPE during deletion of host...
Posted by nlivens <gi...@git.apache.org>.
GitHub user nlivens reopened a pull request:
https://github.com/apache/cloudstack/pull/1585
CLOUDSTACK-9399 : NPE during deletion of host when clusterId is null
In most network plugins, there's a Resource class which will handle the communication with the actual device / underlaying client / ... They're configured as a host, so ACS is able to send commands towards it.
When they're configured as a host, the clusterId is not filled in since it's not relevant. Hence, the NPE while deleting this host because of ```long clusterId = host.getClusterId();```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nlivens/cloudstack CLOUDSTACK-9399
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1585.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1585
----
commit ffe72ca227a518907bca396603a2641e10c5d02d
Author: Nick Livens <ni...@nuagenetworks.net>
Date: 2016-06-03T09:04:09Z
CLOUDSTACK-9399 : NPE during deletion of host when clusterId is null
commit e972273bf17bedd089b0ef0716615b183dec4135
Author: Prashanth Manthena <pr...@alcatel-lucent.com>
Date: 2016-06-03T18:51:25Z
CLOUDSTACK-9399 : Marvin test coverage for Nuage VSP device CRUD operations
commit 7531f24d7374be18eac04000ffac12ee5c462953
Author: Prashanth Manthena <pr...@alcatel-lucent.com>
Date: 2016-06-08T13:35:33Z
Nuage VSP : Enhancing Marvin test coverage
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1585: CLOUDSTACK-9399 : NPE during deletion of host when c...
Posted by nlivens <gi...@git.apache.org>.
Github user nlivens commented on the issue:
https://github.com/apache/cloudstack/pull/1585
@mike-tutkowski, pinging you because I made changes upon your recent merge :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1585: CLOUDSTACK-9399 : NPE during deletion of host when c...
Posted by mike-tutkowski <gi...@git.apache.org>.
Github user mike-tutkowski commented on the issue:
https://github.com/apache/cloudstack/pull/1585
@nlivens Ah, I was not aware that that's how it works for network plug-ins.
The code LGTM. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1585: CLOUDSTACK-9399 : NPE during deletion of host when c...
Posted by prashanthvarma <gi...@git.apache.org>.
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1585
@swill Yes, this is a bug in current master, and IMHO is a candidate to be merged into the frozen master to be released in 4.9.
Note: As of know, there have been two code reviews in this PR from the community.
We will force push to kick off Travis again, and will keep you updated.
Thank you !!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1585: CLOUDSTACK-9399 : NPE during deletion of host when c...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1585
Thank you. I am currently running CI on it as well to make sure it comes back clean. Hopefully we can get travis clean as well with a close and reopen.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1585: CLOUDSTACK-9399 : NPE during deletion of host when c...
Posted by prashanthvarma <gi...@git.apache.org>.
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1585
Marvin Test Run:
CloudStack$ nosetests --with-marvin --marvin-config=nuage.cfg /test/integration/plugins/nuagevsp
Marvin Test Results:
Test user data and password reset functionality with Nuage VSP SDN plugin ... === TestName: test_nuage_UserDataPasswordReset | Status : SUCCESS ===
ok
Test Nuage VSP VPC Offering with different combinations of LB service providers ... === TestName: test_01_nuage_internallb_vpc_Offering | Status : SUCCESS ===
ok
Test Nuage VSP VPC Network Offering with and without Internal LB service ... === TestName: test_02_nuage_internallb_vpc_network_offering | Status : SUCCESS ===
ok
Test Nuage VSP VPC Networks with and without Internal LB service ... === TestName: test_03_nuage_internallb_vpc_networks | Status : SUCCESS ===
ok
Test Nuage VSP VPC Internal LB functionality with different combinations of Internal LB rules ... === TestName: test_04_nuage_internallb_rules | Status : SUCCESS ===
ok
Test Nuage VSP VPC Internal LB functionality by performing (wget) traffic tests within a VPC ... === TestName: test_05_nuage_internallb_traffic | Status : SUCCESS ===
ok
Test Nuage VSP VPC Internal LB functionality with different LB algorithms by performing (wget) traffic tests ... === TestName: test_06_nuage_internallb_algorithms_traffic | Status : SUCCESS ===
ok
Test Nuage VSP VPC Internal LB functionality with restarts of VPC network components by performing (wget) ... === TestName: test_07_nuage_internallb_vpc_network_restarts_traffic | Status : SUCCESS ===
ok
Test Nuage VSP VPC Internal LB functionality with InternalLbVm appliance operations by performing (wget) ... === TestName: test_08_nuage_internallb_appliance_operations_traffic | Status : SUCCESS ===
ok
Test basic VPC Network functionality with Nuage VSP SDN plugin ... === TestName: test_nuage_vpc_network | Status : SUCCESS ===
ok
Test basic VPC Network functionality with Nuage VSP SDN plugin on multiple zones ... SKIP: There is only one Zone configured: skipping test
Test Nuage VSP SDN plugin with basic Isolated Network functionality ... === TestName: test_nuage_vsp | Status : SUCCESS ===
ok
Test Nuage VSP device in the Nuage VSP Physical Network ... === TestName: test_nuage_vsp_device | Status : SUCCESS ===
ok
Ran 13 tests in 8562.574s
OK (SKIP=1)
Marvin Test Run Logs:
[results.txt](https://github.com/apache/cloudstack/files/308973/results.txt)
[runinfo.txt](https://github.com/apache/cloudstack/files/308975/runinfo.txt)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---