You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2011/04/21 08:29:05 UTC
[jira] [Created] (HBASE-3807) Fix units in RS UI metrics
Fix units in RS UI metrics
--------------------------
Key: HBASE-3807
URL: https://issues.apache.org/jira/browse/HBASE-3807
Project: HBase
Issue Type: Bug
Reporter: stack
Fix For: 0.92.0
Currently the metrics are a mix of MB and bytes. Its confusing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3807) Fix units in RS UI metrics
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-3807:
-------------------------
Assignee: subramanian raghunathan
Assigning to Subramanian.
> Fix units in RS UI metrics
> --------------------------
>
> Key: HBASE-3807
> URL: https://issues.apache.org/jira/browse/HBASE-3807
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: subramanian raghunathan
> Fix For: 0.92.0
>
> Attachments: HBASE-3807_trunk.patch
>
>
> Currently the metrics are a mix of MB and bytes. Its confusing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3807) Fix units in RS UI metrics
Posted by "subramanian raghunathan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
subramanian raghunathan updated HBASE-3807:
-------------------------------------------
Status: Patch Available (was: Open)
> Fix units in RS UI metrics
> --------------------------
>
> Key: HBASE-3807
> URL: https://issues.apache.org/jira/browse/HBASE-3807
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Fix For: 0.94.0
>
> Attachments: HBASE-3807_trunk.patch
>
>
> Currently the metrics are a mix of MB and bytes. Its confusing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3807) Fix units in RS UI metrics
Posted by "subramanian raghunathan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082296#comment-13082296 ]
subramanian raghunathan commented on HBASE-3807:
------------------------------------------------
Removing the unused code for determining time elapsed in RegionServerMetrics :
int seconds = (int)((System.currentTimeMillis() - this.lastUpdate)/1000);
if (seconds == 0) {
seconds = 1;
}
Will upload the patch ASAP
> Fix units in RS UI metrics
> --------------------------
>
> Key: HBASE-3807
> URL: https://issues.apache.org/jira/browse/HBASE-3807
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Fix For: 0.94.0
>
>
> Currently the metrics are a mix of MB and bytes. Its confusing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3807) Fix units in RS UI metrics
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-3807:
--------------------------
Fix Version/s: (was: 0.92.0)
0.94.0
> Fix units in RS UI metrics
> --------------------------
>
> Key: HBASE-3807
> URL: https://issues.apache.org/jira/browse/HBASE-3807
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Fix For: 0.94.0
>
>
> Currently the metrics are a mix of MB and bytes. Its confusing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3807) Fix units in RS UI metrics
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-3807:
-------------------------
Resolution: Fixed
Fix Version/s: (was: 0.94.0)
0.92.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Very nice. Thank you Subramanian. Applied to TRUNK
> Fix units in RS UI metrics
> --------------------------
>
> Key: HBASE-3807
> URL: https://issues.apache.org/jira/browse/HBASE-3807
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Fix For: 0.92.0
>
> Attachments: HBASE-3807_trunk.patch
>
>
> Currently the metrics are a mix of MB and bytes. Its confusing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3807) Fix units in RS UI metrics
Posted by "subramanian raghunathan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082150#comment-13082150 ]
subramanian raghunathan commented on HBASE-3807:
------------------------------------------------
requestsPerSecond=0.0, numberOfOnlineRegions=8, numberOfStores=8, numberOfStorefiles=8, storefileIndexSizeMB=0, rootIndexSizeKB=3, totalStaticIndexSizeKB=0, totalStaticBloomSizeKB=0, memstoreSizeMB=0, readRequestsCount=48, writeRequestsCount=8, compactionQueueSize=0, flushQueueSize=0, usedHeapMB=38, maxHeapMB=995, {color:green}blockCacheSizeMB=1.65, blockCacheFreeMB=197.53{color}, blockCacheCount=4, blockCacheHitCount=79, blockCacheMissCount=4, blockCacheEvictedCount=0, blockCacheHitRatio=95%, blockCacheHitCachingRatio=95%
> Fix units in RS UI metrics
> --------------------------
>
> Key: HBASE-3807
> URL: https://issues.apache.org/jira/browse/HBASE-3807
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Fix For: 0.94.0
>
>
> Currently the metrics are a mix of MB and bytes. Its confusing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3807) Fix units in RS UI metrics
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082706#comment-13082706 ]
Hudson commented on HBASE-3807:
-------------------------------
Integrated in HBase-TRUNK #2107 (See [https://builds.apache.org/job/HBase-TRUNK/2107/])
HBASE-3807 Fix units in RS UI metrics
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/HServerLoad.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java
> Fix units in RS UI metrics
> --------------------------
>
> Key: HBASE-3807
> URL: https://issues.apache.org/jira/browse/HBASE-3807
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Fix For: 0.92.0
>
> Attachments: HBASE-3807_trunk.patch
>
>
> Currently the metrics are a mix of MB and bytes. Its confusing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3807) Fix units in RS UI metrics
Posted by "subramanian raghunathan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082295#comment-13082295 ]
subramanian raghunathan commented on HBASE-3807:
------------------------------------------------
Also modifying the debug log in LruBlockCache since theres duplicate percentages{%%} in cachingHitsRatio & hitRatio
2011-08-09 11:39:52,227 DEBUG org.apache.hadoop.hbase.io.hfile.LruBlockCache: LRU Stats: total=960.27 KB, free=198.75 MB, max=199.69 MB, blocks=2, accesses=19, hits=17, {color:red}hitRatio=89.47%%{color}, cachingAccesses=19, cachingHits=17, {color:red}cachingHitsRatio=89.47%%{color}, evictions=0, evicted=0, evictedPerRun=NaN
after fix
2011-08-10 10:58:59,062 DEBUG org.apache.hadoop.hbase.io.hfile.LruBlockCache: LRU Stats: total=1.65 MB, free=197.53 MB, max=199.18 MB, blocks=4, accesses=83, hits=79, {color:green}hitRatio=95.18%{color}, cachingAccesses=83, cachingHits=79, {color:green}cachingHitsRatio=95.18%{color}, evictions=0, evicted=0, evictedPerRun=NaN
> Fix units in RS UI metrics
> --------------------------
>
> Key: HBASE-3807
> URL: https://issues.apache.org/jira/browse/HBASE-3807
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Fix For: 0.94.0
>
>
> Currently the metrics are a mix of MB and bytes. Its confusing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3807) Fix units in RS UI metrics
Posted by "subramanian raghunathan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
subramanian raghunathan updated HBASE-3807:
-------------------------------------------
Attachment: HBASE-3807_trunk.patch
> Fix units in RS UI metrics
> --------------------------
>
> Key: HBASE-3807
> URL: https://issues.apache.org/jira/browse/HBASE-3807
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Fix For: 0.94.0
>
> Attachments: HBASE-3807_trunk.patch
>
>
> Currently the metrics are a mix of MB and bytes. Its confusing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3807) Fix units in RS UI metrics
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-3807:
-------------------------
Fix Version/s: 0.92.0
> Fix units in RS UI metrics
> --------------------------
>
> Key: HBASE-3807
> URL: https://issues.apache.org/jira/browse/HBASE-3807
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Fix For: 0.92.0
>
>
> Currently the metrics are a mix of MB and bytes. Its confusing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3807) Fix units in RS UI metrics
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13081763#comment-13081763 ]
stack commented on HBASE-3807:
------------------------------
Your proposal looks excellent Subramanian. Would suggest two digits after the decimal point only is needed (There is a limitDecimalTo2 in Hadoop StringUtils class if that is of any help).
> Fix units in RS UI metrics
> --------------------------
>
> Key: HBASE-3807
> URL: https://issues.apache.org/jira/browse/HBASE-3807
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Fix For: 0.94.0
>
>
> Currently the metrics are a mix of MB and bytes. Its confusing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3807) Fix units in RS UI metrics
Posted by "subramanian raghunathan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13081586#comment-13081586 ]
subramanian raghunathan commented on HBASE-3807:
------------------------------------------------
Proposing to change from the following formats
request=0.0, regions=8, stores=8, storefiles=8, storefileIndexSize=0, rootIndexSizeKB=3, totalStaticIndexSizeKB=0, totalStaticBloomSizeKB=0, memstoreSize=0, readRequestsCount=56, writeRequestsCount=14, compactionQueueSize=0, flushQueueSize=0, usedHeap=41, maxHeap=995, blockCacheSize=1767336, blockCacheFree=207082792, blockCacheCount=9, blockCacheHitCount=50, blockCacheMissCount=9, blockCacheEvictedCount=0, blockCacheHitRatio=84, blockCacheHitCachingRatio=84
stores=1, storefiles=2, storefileUncompressedSizeMB=0, storefileSizeMB=0, memstoreSizeMB=0, storefileIndexSizeMB=0, readRequestsCount=8, writeRequestsCount=2, rootIndexSizeKB=0, totalStaticIndexSizeKB=0, totalStaticBloomSizeKB=0
to
{color:red}requestsPerSecond=0.0, numberOfOnlineRegions=8, numberOfStores=8, numberOfStorefiles=10, storefileIndexSizeMB=0{color}, rootIndexSizeKB=4, totalStaticIndexSizeKB=0, totalStaticBloomSizeKB=0, {color:red}memstoreSizeMB=0{color}, readRequestsCount=48, writeRequestsCount=8, compactionQueueSize=0, flushQueueSize=0,{color:red}usedHeapMB=34, maxHeapMB=995, blockCacheSizeMB=1.6885986, blockCacheFreeMB=197.4864{color}, blockCacheCount=11, blockCacheHitCount=53, blockCacheMissCount=11, blockCacheEvictedCount=0, {color:red}blockCacheHitRatio=82%, blockCacheHitCachingRatio=82%{color}
{color:red}numberOfStores=1, numberOfStorefiles=3{color}, storefileUncompressedSizeMB=0, storefileSizeMB=0,memstoreSizeMB=0, storefileIndexSizeMB=0, readRequestsCount=8, writeRequestsCount=2, rootIndexSizeKB=1, totalStaticIndexSizeKB=0, totalStaticBloomSizeKB=0
Also proposing the following metric in bytes blockCacheSize ,blockCacheFree planning to MB with full precision like {color:green}blockCacheSizeMB=1.6885986, blockCacheFreeMB=197.4864{color}
If this looks good ,i can upload the patch for trunk. If needed i can prepare the patch for 90.X also.
> Fix units in RS UI metrics
> --------------------------
>
> Key: HBASE-3807
> URL: https://issues.apache.org/jira/browse/HBASE-3807
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Fix For: 0.94.0
>
>
> Currently the metrics are a mix of MB and bytes. Its confusing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira