You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2015/03/04 17:56:29 UTC

Review Request 31730: RU: create documentation for Upgrade API

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31730/
-----------------------------------------------------------

Review request for Ambari, Jonathan Hurley and Tom Beerbower.


Bugs: AMBARI-9926
    https://issues.apache.org/jira/browse/AMBARI-9926


Repository: ambari


Description
-------

.md files for Upgrade API


Diffs
-----

  ambari-server/docs/api/v1/index.md 026efbe 
  ambari-server/docs/api/v1/upgrades.md PRE-CREATION 

Diff: https://reviews.apache.org/r/31730/diff/


Testing
-------

Rat check:
[INFO] Ambari Main ....................................... SUCCESS [14.229s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.182s]
[INFO] Ambari Web ........................................ SUCCESS [30.394s]
[INFO] Ambari Views ...................................... SUCCESS [0.158s]
[INFO] Ambari Admin View ................................. SUCCESS [42.017s]
[INFO] Ambari Metrics Common ............................. SUCCESS [0.463s]
[INFO] Ambari Server ..................................... SUCCESS [9.958s]
[INFO] Ambari Agent ...................................... SUCCESS [0.497s]
[INFO] Ambari Client ..................................... SUCCESS [0.068s]
[INFO] Ambari Python Client .............................. SUCCESS [0.212s]
[INFO] Ambari Groovy Client .............................. SUCCESS [0.275s]
[INFO] Ambari Shell ...................................... SUCCESS [0.061s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.079s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [0.110s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:39.818s
[INFO] Finished at: Wed Mar 04 11:54:42 EST 2015
[INFO] Final Memory: 25M/486M
[INFO] ------------------------------------------------------------------------


Thanks,

Nate Cole


Re: Review Request 31730: RU: create documentation for Upgrade API

Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31730/#review75207
-----------------------------------------------------------

Ship it!


Ship It!

- Tom Beerbower


On March 4, 2015, 6:41 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31730/
> -----------------------------------------------------------
> 
> (Updated March 4, 2015, 6:41 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Tom Beerbower.
> 
> 
> Bugs: AMBARI-9926
>     https://issues.apache.org/jira/browse/AMBARI-9926
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> .md files for Upgrade API
> 
> 
> Diffs
> -----
> 
>   ambari-server/docs/api/v1/index.md 026efbe 
>   ambari-server/docs/api/v1/upgrades.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31730/diff/
> 
> 
> Testing
> -------
> 
> Rat check:
> [INFO] Ambari Main ....................................... SUCCESS [14.229s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.182s]
> [INFO] Ambari Web ........................................ SUCCESS [30.394s]
> [INFO] Ambari Views ...................................... SUCCESS [0.158s]
> [INFO] Ambari Admin View ................................. SUCCESS [42.017s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [0.463s]
> [INFO] Ambari Server ..................................... SUCCESS [9.958s]
> [INFO] Ambari Agent ...................................... SUCCESS [0.497s]
> [INFO] Ambari Client ..................................... SUCCESS [0.068s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.212s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [0.275s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.061s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.079s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [0.110s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:39.818s
> [INFO] Finished at: Wed Mar 04 11:54:42 EST 2015
> [INFO] Final Memory: 25M/486M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Re: Review Request 31730: RU: create documentation for Upgrade API

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31730/
-----------------------------------------------------------

(Updated March 4, 2015, 1:41 p.m.)


Review request for Ambari, Jonathan Hurley and Tom Beerbower.


Changes
-------

Updated patch for comments.


Bugs: AMBARI-9926
    https://issues.apache.org/jira/browse/AMBARI-9926


Repository: ambari


Description
-------

.md files for Upgrade API


Diffs (updated)
-----

  ambari-server/docs/api/v1/index.md 026efbe 
  ambari-server/docs/api/v1/upgrades.md PRE-CREATION 

Diff: https://reviews.apache.org/r/31730/diff/


Testing
-------

Rat check:
[INFO] Ambari Main ....................................... SUCCESS [14.229s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.182s]
[INFO] Ambari Web ........................................ SUCCESS [30.394s]
[INFO] Ambari Views ...................................... SUCCESS [0.158s]
[INFO] Ambari Admin View ................................. SUCCESS [42.017s]
[INFO] Ambari Metrics Common ............................. SUCCESS [0.463s]
[INFO] Ambari Server ..................................... SUCCESS [9.958s]
[INFO] Ambari Agent ...................................... SUCCESS [0.497s]
[INFO] Ambari Client ..................................... SUCCESS [0.068s]
[INFO] Ambari Python Client .............................. SUCCESS [0.212s]
[INFO] Ambari Groovy Client .............................. SUCCESS [0.275s]
[INFO] Ambari Shell ...................................... SUCCESS [0.061s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.079s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [0.110s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:39.818s
[INFO] Finished at: Wed Mar 04 11:54:42 EST 2015
[INFO] Final Memory: 25M/486M
[INFO] ------------------------------------------------------------------------


Thanks,

Nate Cole


Re: Review Request 31730: RU: create documentation for Upgrade API

Posted by Nate Cole <nc...@hortonworks.com>.

> On March 4, 2015, 12:15 p.m., Tom Beerbower wrote:
> > ambari-server/docs/api/v1/upgrades.md, line 111
> > <https://reviews.apache.org/r/31730/diff/1/?file=884413#file884413line111>
> >
> >     Should we mention HOLDING_FAILED as well?

Thanks for reviewing - I'll add those in.


- Nate


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31730/#review75186
-----------------------------------------------------------


On March 4, 2015, 11:56 a.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31730/
> -----------------------------------------------------------
> 
> (Updated March 4, 2015, 11:56 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Tom Beerbower.
> 
> 
> Bugs: AMBARI-9926
>     https://issues.apache.org/jira/browse/AMBARI-9926
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> .md files for Upgrade API
> 
> 
> Diffs
> -----
> 
>   ambari-server/docs/api/v1/index.md 026efbe 
>   ambari-server/docs/api/v1/upgrades.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31730/diff/
> 
> 
> Testing
> -------
> 
> Rat check:
> [INFO] Ambari Main ....................................... SUCCESS [14.229s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.182s]
> [INFO] Ambari Web ........................................ SUCCESS [30.394s]
> [INFO] Ambari Views ...................................... SUCCESS [0.158s]
> [INFO] Ambari Admin View ................................. SUCCESS [42.017s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [0.463s]
> [INFO] Ambari Server ..................................... SUCCESS [9.958s]
> [INFO] Ambari Agent ...................................... SUCCESS [0.497s]
> [INFO] Ambari Client ..................................... SUCCESS [0.068s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.212s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [0.275s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.061s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.079s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [0.110s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:39.818s
> [INFO] Finished at: Wed Mar 04 11:54:42 EST 2015
> [INFO] Final Memory: 25M/486M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Re: Review Request 31730: RU: create documentation for Upgrade API

Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31730/#review75186
-----------------------------------------------------------


Looks good.


ambari-server/docs/api/v1/upgrades.md
<https://reviews.apache.org/r/31730/#comment122163>

    Should we mention HOLDING_FAILED as well?


- Tom Beerbower


On March 4, 2015, 4:56 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31730/
> -----------------------------------------------------------
> 
> (Updated March 4, 2015, 4:56 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Tom Beerbower.
> 
> 
> Bugs: AMBARI-9926
>     https://issues.apache.org/jira/browse/AMBARI-9926
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> .md files for Upgrade API
> 
> 
> Diffs
> -----
> 
>   ambari-server/docs/api/v1/index.md 026efbe 
>   ambari-server/docs/api/v1/upgrades.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31730/diff/
> 
> 
> Testing
> -------
> 
> Rat check:
> [INFO] Ambari Main ....................................... SUCCESS [14.229s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.182s]
> [INFO] Ambari Web ........................................ SUCCESS [30.394s]
> [INFO] Ambari Views ...................................... SUCCESS [0.158s]
> [INFO] Ambari Admin View ................................. SUCCESS [42.017s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [0.463s]
> [INFO] Ambari Server ..................................... SUCCESS [9.958s]
> [INFO] Ambari Agent ...................................... SUCCESS [0.497s]
> [INFO] Ambari Client ..................................... SUCCESS [0.068s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.212s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [0.275s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.061s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.079s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [0.110s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:39.818s
> [INFO] Finished at: Wed Mar 04 11:54:42 EST 2015
> [INFO] Final Memory: 25M/486M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Re: Review Request 31730: RU: create documentation for Upgrade API

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31730/#review75191
-----------------------------------------------------------

Ship it!


Ship It!

- Jonathan Hurley


On March 4, 2015, 11:56 a.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31730/
> -----------------------------------------------------------
> 
> (Updated March 4, 2015, 11:56 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Tom Beerbower.
> 
> 
> Bugs: AMBARI-9926
>     https://issues.apache.org/jira/browse/AMBARI-9926
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> .md files for Upgrade API
> 
> 
> Diffs
> -----
> 
>   ambari-server/docs/api/v1/index.md 026efbe 
>   ambari-server/docs/api/v1/upgrades.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31730/diff/
> 
> 
> Testing
> -------
> 
> Rat check:
> [INFO] Ambari Main ....................................... SUCCESS [14.229s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.182s]
> [INFO] Ambari Web ........................................ SUCCESS [30.394s]
> [INFO] Ambari Views ...................................... SUCCESS [0.158s]
> [INFO] Ambari Admin View ................................. SUCCESS [42.017s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [0.463s]
> [INFO] Ambari Server ..................................... SUCCESS [9.958s]
> [INFO] Ambari Agent ...................................... SUCCESS [0.497s]
> [INFO] Ambari Client ..................................... SUCCESS [0.068s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.212s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [0.275s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.061s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.079s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [0.110s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:39.818s
> [INFO] Finished at: Wed Mar 04 11:54:42 EST 2015
> [INFO] Final Memory: 25M/486M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>