You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2022/09/14 07:46:08 UTC

[GitHub] [phoenix] stoty commented on a diff in pull request #1493: PHOENIX-6767 Traversing through all the guideposts to prepare paralleā€¦

stoty commented on code in PR #1493:
URL: https://github.com/apache/phoenix/pull/1493#discussion_r970446421


##########
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixTableLevelMetricsIT.java:
##########
@@ -549,6 +550,7 @@ private static void assertMetricValue(Metric m, MetricType checkType, long compa
         assertSelectQueryTableMetrics(tableName, false, 1, 0, 1, 0, 0, true, 0, 0, rs);
     }
 
+    @Ignore

Review Comment:
   nit: Can you add coments here ?



##########
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixTableLevelMetricsIT.java:
##########
@@ -549,6 +550,7 @@ private static void assertMetricValue(Metric m, MetricType checkType, long compa
         assertSelectQueryTableMetrics(tableName, false, 1, 0, 1, 0, 0, true, 0, 0, rs);
     }
 
+    @Ignore

Review Comment:
   nit: Can you add comments here ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org