[jira] [Comment Edited] (OAK-8624) oak-run: tests leak mapd temp files

["Julian Reschke (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-8624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931524#comment-16931524 ] 

Julian Reschke edited comment on OAK-8624 at 10/1/19 12:35 PM:
---------------------------------------------------------------

trunk: (1.18.0) [r1867061|http://svn.apache.org/r1867061]
1.10: [r1867841|http://svn.apache.org/r1867841]



was (Author: reschke):
trunk: [r1867061|http://svn.apache.org/r1867061]

> oak-run: tests leak mapd temp files
> -----------------------------------
>
>                 Key: OAK-8624
>                 URL: https://issues.apache.org/jira/browse/OAK-8624
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: run
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Minor
>              Labels: candidate_oak_1_8
>             Fix For: 1.18.0, 1.10.6
>
>         Attachments: OAK-8624.diff
>
>
> This is because {{MapDBMapFactory}} is backed by temporary DB, but that one is never closed.
> Fix:
> - make it {{closeable}}
> - adapt test case and use in {{RecoveryCommand}}
> However, {{RecoveryCommand}} sets the {{MapFactory}} instance globally, and never resets it. Thus, if the factory is indeed closed, subsequent tests will fail. So, in {{RecoveryCommand}}, restore the default factory when done.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)