You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/02/05 03:21:39 UTC
[jira] [Commented] (DRILL-3581) Google Guava version is so old it
causes incompatibilities with other libs
[ https://issues.apache.org/jira/browse/DRILL-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15133526#comment-15133526 ]
ASF GitHub Bot commented on DRILL-3581:
---------------------------------------
GitHub user jacques-n opened a pull request:
https://github.com/apache/drill/pull/361
DRILL-3581: Upgrade Guava, HPPC and Jackson
- Replace Stopwatch constructors with .createStarted() or .createUnstarted()
- Stop using InputSupplier and Closeables.closeQuietly
- Clean up quiet closes to log or (preferably) propagate.
- Add log4j to enforcer exclusions.
- Update HBaseTestSuite to add patching of Closeables.closeQuietly() and Stopwatch legacy methods. Only needed when running HBaseMiniCluster.
- Remove log4j from HBase's pom to provide exception logging.
- Remove log4j from Hive's shaded pom.
- Update Catastrophic failures to use the same pattern to ensure reporting.
- Update test framework to avoid trying IPv6 resolution. (This removes 90s pause from HBase startup in my tests)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jacques-n/drill DRILL-3581
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/361.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #361
----
commit 915e32bf111eda80a2e27814c79ad2de170edbb7
Author: Jacques Nadeau <ja...@apache.org>
Date: 2016-02-03T03:30:31Z
DRILL-3581: Upgrade HPPC to 0.7.1
commit 47e22769502f023cdfb2603512a47486dc288aef
Author: Jacques Nadeau <ja...@apache.org>
Date: 2016-02-03T03:30:47Z
DRILL-3581: Upgrade Jackson to version 2.7.1
commit 8f8cf4911e48e0c105050196d39cd3cff96cee62
Author: Jacques Nadeau <ja...@apache.org>
Date: 2015-09-14T20:01:57Z
DRILL-3581: Upgrade to Guava 18.0
- Replace Stopwatch constructors with .createStarted() or .createUnstarted()
- Stop using InputSupplier and Closeables.closeQuietly
- Clean up quiet closes to log or (preferably) propagate.
- Add log4j to enforcer exclusions.
- Update HBaseTestSuite to add patching of Closeables.closeQuietly() and Stopwatch legacy methods. Only needed when running HBaseMiniCluster.
- Remove log4j from HBase's pom to provide exception logging.
- Remove log4j from Hive's shaded pom.
- Update Catastrophic failures to use the same pattern to ensure reporting.
- Update test framework to avoid trying IPv6 resolution. (This removes 90s pause from HBase startup in my tests)
----
> Google Guava version is so old it causes incompatibilities with other libs
> --------------------------------------------------------------------------
>
> Key: DRILL-3581
> URL: https://issues.apache.org/jira/browse/DRILL-3581
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - JDBC
> Affects Versions: 1.1.0
> Environment: Linux, JDK 1.8
> Reporter: Joseph Barefoot
> Assignee: Jacques Nadeau
> Fix For: 1.6.0
>
>
> Drill is currently using Guava version 14.0.1, which was released March 2013. https://github.com/apache/drill/blob/master/pom.xml
> Many other java projects use newer versions, however this conflicts with the Drill JDBC driver since a couple of APIs it uses are incompatible with the newer guava versions. In particular:
> https://github.com/apache/drill/blob/master/common/src/main/java/org/apache/drill/common/util/PathScanner.java
> (The public StopWatch class constructor has been removed in favor of factory methods)
> Although this seems minor, it prevents easily using Drill from a java application, since again many other open source libs will be using the latest Guava version (18).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)