You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Georg Henzler (JIRA)" <ji...@apache.org> on 2019/01/08 13:01:00 UTC
[jira] [Created] (FELIX-6016) Clean up util package in Health Check
API
Georg Henzler created FELIX-6016:
------------------------------------
Summary: Clean up util package in Health Check API
Key: FELIX-6016
URL: https://issues.apache.org/jira/browse/FELIX-6016
Project: Felix
Issue Type: Improvement
Components: Health Checks
Reporter: Georg Henzler
Assignee: Georg Henzler
Currently the bundle "org.apache.felix.healthcheck.api" contains the package "org.apache.felix.hc.util" with three classes. Utility packages are always a bit of a code smell, and in this case it can be avoided by
* Moving the class FormattingResultLog to package org.apache.felix.hc.api
** This is commonly used, but when migrating from Sling HCs the package names change anyway and "Organise Imports" in IDE fixes it quickly
* Moving the class HealthCheckMetadata to package org.apache.felix.hc.api.execution
** It belongs to this package (it's only used there and in the impl). Most users don't require this (as the standard execution mechanisms suffice) - hence the change is not problematic
* Moving the internal class HealthCheckFilter to bundle org.apache.felix.healthcheck.core
** Since the introduction of the health check executor there was not much point of using this anymore, it's pretty much only used by executor implementation right now
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)