[PATCH] TaskHandler fixes

[Ovidiu Predescu <ov...@cup.hp.com>]

Hi,

In 1.4, if an extension task is declared to implement TaskContainer, all the
contained tasks are added correctly to the extension task. However the
contained tasks will not have the attribute setter methods invoked as it should
happen. This doesn't happen with tasks defined in Ant itself, only with new
extension tasks defined in additional jar files.

The following patch fixes this problem. It essentially appends a child
configuration wrapper to its container task wrapper. The patch was generated
against the 1.4 release.

Could you please review the patch and commit it in CVS?

Best regards,
-- 
Ovidiu Predescu <ov...@cup.hp.com>
http://orion.rgv.hp.com/ (inside HP's firewall only)
http://sourceforge.net/users/ovidiu/ (my SourceForge page)
http://www.geocities.com/SiliconValley/Monitor/7464/ (GNU, Emacs, other stuff)

Re: [PATCH] TaskHandler fixes

[Stefan Bodewig <bo...@apache.org>]

On Thu, 01 Nov 2001, Ovidiu Predescu <ov...@cup.hp.com> wrote:

> In 1.4, if an extension task is declared to implement TaskContainer,
> all the contained tasks are added correctly to the extension
> task. However the contained tasks will not have the attribute setter
> methods invoked as it should happen. This doesn't happen with tasks
> defined in Ant itself, only with new extension tasks defined in
> additional jar files.

It doesn't happen for the built-in TaskContainers as they invoke
Task.perform instead of Task.execute - which has the additional side
effect of firing build events.

While I agree that "configuring" the tasks (Ant-speak for invoking the
attribute setters) should happen for the children of TaskContainer
tasks the same way it happens for the other child elements - that's
why I'll commit your patch - we should probably advise people who
implement TaskContainer to use perform instead of execute as well.

Stefan

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>