You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/06/09 16:42:40 UTC

[GitHub] [nifi] Lehel44 commented on a change in pull request #5140: NIFI-8662: Using the configured AWS region when parsing from VPCE end…

Lehel44 commented on a change in pull request #5140:
URL: https://github.com/apache/nifi/pull/5140#discussion_r648489582



##########
File path: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/AbstractAWSProcessor.java
##########
@@ -319,9 +319,14 @@ protected void initializeRegionAndEndpoint(ProcessContext context) {
                 getLogger().info("Overriding endpoint with {}", urlstr);
 
                 if (urlstr.endsWith(".vpce.amazonaws.com")) {

Review comment:
       Would you extract this into a constant? It is used here and also in row 346.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org