[GitHub] [pulsar] Shoothzj commented on a diff in pull request #15867: add metric for InMemoryDelayedDeliveryTracker's memory usage

[GitBox <gi...@apache.org>]

Shoothzj commented on code in PR #15867:
URL: https://github.com/apache/pulsar/pull/15867#discussion_r930738603


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/AggregatedNamespaceStats.java:
##########
@@ -59,6 +59,7 @@ public class AggregatedNamespaceStats {
     long compactionCompactedEntriesCount;
     long compactionCompactedEntriesSize;
     StatsBuckets compactionLatencyBuckets = new StatsBuckets(CompactionRecord.WRITE_LATENCY_BUCKETS_USEC);
+    public int delayedTrackerMemoryUsage;

Review Comment:
   ```suggestion
       int delayedTrackerMemoryUsage;
   ```
   I think we don't need `public`?



##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/TopicStats.java:
##########
@@ -67,6 +67,7 @@ class TopicStats {
     long compactionCompactedEntriesCount;
     long compactionCompactedEntriesSize;
     StatsBuckets compactionLatencyBuckets = new StatsBuckets(CompactionRecord.WRITE_LATENCY_BUCKETS_USEC);
+    public int delayedTrackerMemoryUsage;

Review Comment:
   ```suggestion
       int delayedTrackerMemoryUsage;
   ```
   do we really need public?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org