You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "Qianyi951015 (via GitHub)" <gi...@apache.org> on 2023/02/02 03:48:12 UTC
[GitHub] [shardingsphere] Qianyi951015 opened a new pull request, #23918: Replace `AuthorityRuleResultSet` with `AuthorityRuleExecutor`
Qianyi951015 opened a new pull request, #23918:
URL: https://github.com/apache/shardingsphere/pull/23918
For #23854.
Changes proposed in this pull request:
- Replace `AuthorityRuleResultSet` with `AuthorityRuleExecutor`
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #23918: Replace `AuthorityRuleResultSet` with `AuthorityRuleExecutor`
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #23918:
URL: https://github.com/apache/shardingsphere/pull/23918#issuecomment-1413131038
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23918?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23918](https://codecov.io/gh/apache/shardingsphere/pull/23918?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (636890a) into [master](https://codecov.io/gh/apache/shardingsphere/commit/2f1a10fc543b05db270caa2c35a648a5129a72c9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f1a10f) will **decrease** coverage by `0.08%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #23918 +/- ##
============================================
- Coverage 50.19% 50.11% -0.08%
- Complexity 1567 1569 +2
============================================
Files 3247 3243 -4
Lines 53483 53375 -108
Branches 9800 9796 -4
============================================
- Hits 26844 26750 -94
+ Misses 24280 24272 -8
+ Partials 2359 2353 -6
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/23918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...thority/distsql/handler/AuthorityRuleExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/23918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2F1dGhvcml0eS9kaXN0c3FsL2hhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2F1dGhvcml0eS9kaXN0c3FsL2hhbmRsZXIvQXV0aG9yaXR5UnVsZUV4ZWN1dG9yLmphdmE=) | `71.42% <100.00%> (ø)` | |
| [.../agent/core/classloader/AgentExtraClassLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/23918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9jbGFzc2xvYWRlci9BZ2VudEV4dHJhQ2xhc3NMb2FkZXIuamF2YQ==) | `10.00% <0.00%> (-13.34%)` | :arrow_down: |
| [...m/CRC32MatchDataConsistencyCalculateAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/23918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL2NoZWNrL2NvbnNpc3RlbmN5L2FsZ29yaXRobS9DUkMzMk1hdGNoRGF0YUNvbnNpc3RlbmN5Q2FsY3VsYXRlQWxnb3JpdGhtLmphdmE=) | `43.58% <0.00%> (-2.76%)` | :arrow_down: |
| [...t/DMLShardingConditionsShardingAuditAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/23918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvYWxnb3JpdGhtL2F1ZGl0L0RNTFNoYXJkaW5nQ29uZGl0aW9uc1NoYXJkaW5nQXVkaXRBbGdvcml0aG0uamF2YQ==) | `87.50% <0.00%> (-2.50%)` | :arrow_down: |
| [.../PersonalIdentityNumberRandomReplaceAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/23918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvbWFzay9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tYXNrL2FsZ29yaXRobS9yZXBsYWNlL1BlcnNvbmFsSWRlbnRpdHlOdW1iZXJSYW5kb21SZXBsYWNlQWxnb3JpdGhtLmphdmE=) | `78.94% <0.00%> (-1.06%)` | :arrow_down: |
| [...thm/sharding/hint/HintInlineShardingAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/23918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvYWxnb3JpdGhtL3NoYXJkaW5nL2hpbnQvSGludElubGluZVNoYXJkaW5nQWxnb3JpdGhtLmphdmE=) | `92.85% <0.00%> (-0.90%)` | :arrow_down: |
| [...he/shardingsphere/shadow/rule/ShadowTableRule.java](https://codecov.io/gh/apache/shardingsphere/pull/23918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhZG93L2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYWRvdy9ydWxlL1NoYWRvd1RhYmxlUnVsZS5qYXZh) | `94.11% <0.00%> (-0.89%)` | :arrow_down: |
| [...ask/algorithm/cover/MaskFromXToYMaskAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/23918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvbWFzay9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tYXNrL2FsZ29yaXRobS9jb3Zlci9NYXNrRnJvbVhUb1lNYXNrQWxnb3JpdGhtLmphdmE=) | `80.95% <0.00%> (-0.87%)` | :arrow_down: |
| [...ReplicationDatabaseDiscoveryProviderAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/23918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZGItZGlzY292ZXJ5L3Byb3ZpZGVyL215c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYmRpc2NvdmVyeS9teXNxbC90eXBlL015U1FMTm9ybWFsUmVwbGljYXRpb25EYXRhYmFzZURpc2NvdmVyeVByb3ZpZGVyQWxnb3JpdGhtLmphdmE=) | `53.70% <0.00%> (-0.85%)` | :arrow_down: |
| [...ask/algorithm/cover/KeepFromXToYMaskAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/23918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvbWFzay9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tYXNrL2FsZ29yaXRobS9jb3Zlci9LZWVwRnJvbVhUb1lNYXNrQWxnb3JpdGhtLmphdmE=) | `82.60% <0.00%> (-0.73%)` | :arrow_down: |
| ... and [74 more](https://codecov.io/gh/apache/shardingsphere/pull/23918?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #23918: Replace `AuthorityRuleResultSet` with `AuthorityRuleExecutor`
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang merged PR #23918:
URL: https://github.com/apache/shardingsphere/pull/23918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org