svn commit: r1096918 - /shindig/trunk/features/src/main/javascript/features/core.config.base/config.js

[jo...@apache.org]

Author: johnh
Date: Tue Apr 26 21:29:09 2011
New Revision: 1096918

URL: http://svn.apache.org/viewvc?rev=1096918&view=rev
Log:
Use Function syntax rather than eval to set config value. Doing so avoids dead-code removal of otherwise seemingly-unused config variable.


Modified:
    shindig/trunk/features/src/main/javascript/features/core.config.base/config.js

Modified: shindig/trunk/features/src/main/javascript/features/core.config.base/config.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/core.config.base/config.js?rev=1096918&r1=1096917&r2=1096918&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/core.config.base/config.js (original)
+++ shindig/trunk/features/src/main/javascript/features/core.config.base/config.js Tue Apr 26 21:29:09 2011
@@ -122,13 +122,13 @@ gadgets.config = function() {
   function parseConfig(configText) {
     var config;
     try {
-      eval("config=(" + configText + "\n)");
+      config = (new Function("return (" + configText + "\n)"))();
     } catch (e) { }
     if (typeof config === "object") {
       return config;
     }
     try {
-      eval("config=({" + configText + "\n})");
+      config = (new Function("return ({" + configText + "\n})"))();
     } catch (e) { }
     return typeof config === "object" ? config : {};
   }