[jira] [Resolved] (OLINGO-499) AbstractValuable.isComplex

["Michael Bolz (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OLINGO-499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Bolz resolved OLINGO-499.
---------------------------------
       Resolution: Fixed
    Fix Version/s: (Java) V4 4.0.0-beta-02

Fixed with commit [\[OLINGO-499\]\[OLINGO-501\] Serialization of complex collections works properly|https://git-wip-us.apache.org/repos/asf?p=olingo-odata4.git;a=commit;h=5f18ea2e09398a059e31e833fd43e800d6fd2bba].

> AbstractValuable.isComplex
> --------------------------
>
>                 Key: OLINGO-499
>                 URL: https://issues.apache.org/jira/browse/OLINGO-499
>             Project: Olingo
>          Issue Type: Bug
>          Components: odata4-commons, odata4-server
>    Affects Versions: V4 4.0.0-beta-01
>            Reporter: Ole Lilienthal
>            Assignee: Michael Bolz
>            Priority: Critical
>              Labels: easyfix
>             Fix For: (Java) V4 4.0.0-beta-02
>
>         Attachments: Olingo499.diff
>
>
> org.apache.olingo.commons.core.data.AbstractValuable.isComplex() returns false for org.apache.olingo.commons.api.data.ValueType.COLLECTION_COMPLEX.
> It should rather be:
> return (valueType == ValueType.COMPLEX || valueType.getBaseType() == ValueType.COMPLEX);
> Otherwise there is a contradiction in the function: org.apache.olingo.server.core.serializer.json.ODataJsonSerializer.writeComplexCollection
> The switch checks the value type to be COLLECTION_COMPLEX and wants to use the property.asComplex which currently always returns null due to the wrong isComplex implementation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)