[GitHub] mikewalch commented on a change in pull request #902: fixes #894 merge SimpleConfiguration Objects

[gi...@git.apache.org]

mikewalch commented on a change in pull request #902: fixes #894 merge SimpleConfiguration Objects
URL: https://github.com/apache/fluo/pull/902#discussion_r131683399
 
 

 ##########
 File path: modules/api/src/main/java/org/apache/fluo/api/config/SimpleConfiguration.java
 ##########
 @@ -225,6 +224,34 @@ public void save(OutputStream out) {
     }
   }
 
+  /**
+   * @since 1.2.0
+   */
+  public void addProperty(String key, Boolean value) {
+    internalConfig.addProperty(key, value);
+  }
+
+  /**
+   * @since 1.2.0
+   */
+  public void addProperty(String key, Integer value) {
+    internalConfig.addProperty(key, value);
+  }
+
+  /**
+   * @since 1.2.0
+   */
+  public void addProperty(String key, Long value) {
 
 Review comment:
   Do we need to expose addProperty()?  If so, then it should be documented how it is different from setProperty().
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services