You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by danix800 <gi...@git.apache.org> on 2016/09/26 13:04:36 UTC
[GitHub] spark pull request #15243: Fixing comment since Actor is not used anymore.
GitHub user danix800 opened a pull request:
https://github.com/apache/spark/pull/15243
Fixing comment since Actor is not used anymore.
## What changes were proposed in this pull request?
Fixing comment since Actor is not used anymore.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/danix800/spark comment-fixing
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/15243.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #15243
----
commit 3fe33a29064dcc06e8deebfeec2045af4a44dfed
Author: Ding Fei <da...@danix>
Date: 2016-09-26T13:01:33Z
Fixing comment since Actor is not used anymore.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #15243: Fixing comment since Actor is not used anymore.
Posted by danix800 <gi...@git.apache.org>.
Github user danix800 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15243#discussion_r80614009
--- Diff: core/src/main/scala/org/apache/spark/deploy/worker/WorkerWatcher.scala ---
@@ -21,7 +21,7 @@ import org.apache.spark.internal.Logging
import org.apache.spark.rpc._
/**
- * Actor which connects to a worker process and terminates the JVM if the connection is severed.
+ * WorkerWatcher RpcEndpoint which connects to a worker process and terminates the JVM if the connection is severed.
--- End diff --
Thanks! Fix again!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15243: Fixing comment since Actor is not used anymore.
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15243
**[Test build #65917 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65917/consoleFull)** for PR 15243 at commit [`3fe33a2`](https://github.com/apache/spark/commit/3fe33a29064dcc06e8deebfeec2045af4a44dfed).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15243: Fixing comment since Actor is not used anymore.
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15243
Hi, @danix800 .
Could you fix the following comment in this PR, too?
https://github.com/apache/spark/blob/master/core/src/test/scala/org/apache/spark/MapOutputTrackerSuite.scala#L256
```
// Frame size should be ~1.1MB, and MapOutputTrackerMasterActor should throw exception.
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #15243: Fixing comment since Actor is not used anymore.
Posted by danix800 <gi...@git.apache.org>.
Github user danix800 closed the pull request at:
https://github.com/apache/spark/pull/15243
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15243: Fixing comment since Actor is not used anymore.
Posted by danix800 <gi...@git.apache.org>.
Github user danix800 commented on the issue:
https://github.com/apache/spark/pull/15243
Fixing comment since Actor is not used anymore.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15243: Fixing comment since Actor is not used anymore.
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15243
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65917/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15243: Fixing comment since Actor is not used anymore.
Posted by danix800 <gi...@git.apache.org>.
Github user danix800 commented on the issue:
https://github.com/apache/spark/pull/15243
Hi, @dongjoon-hyun . Fixed!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #15243: Fixing comment since Actor is not used anymore.
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15243#discussion_r80476813
--- Diff: core/src/main/scala/org/apache/spark/deploy/worker/WorkerWatcher.scala ---
@@ -21,7 +21,7 @@ import org.apache.spark.internal.Logging
import org.apache.spark.rpc._
/**
- * Actor which connects to a worker process and terminates the JVM if the connection is severed.
+ * WorkerWatcher RpcEndpoint which connects to a worker process and terminates the JVM if the connection is severed.
--- End diff --
The line is too long here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15243: Fixing comment since Actor is not used anymore.
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/15243
Jenkins test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15243: Fixing comment since Actor is not used anymore.
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15243
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15243: Fixing comment since Actor is not used anymore.
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15243
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15243: Fixing comment since Actor is not used anymore.
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15243
**[Test build #65917 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65917/consoleFull)** for PR 15243 at commit [`3fe33a2`](https://github.com/apache/spark/commit/3fe33a29064dcc06e8deebfeec2045af4a44dfed).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #15243: Fixing comment since Actor is not used anymore.
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15243#discussion_r80478992
--- Diff: core/src/main/scala/org/apache/spark/deploy/worker/WorkerWatcher.scala ---
@@ -21,7 +21,7 @@ import org.apache.spark.internal.Logging
import org.apache.spark.rpc._
/**
- * Actor which connects to a worker process and terminates the JVM if the connection is severed.
+ * WorkerWatcher RpcEndpoint which connects to a worker process and terminates the JVM if the connection is severed.
--- End diff --
yeah, just say `Endpoint`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org