You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "aminghadersohi (via GitHub)" <gi...@apache.org> on 2026/09/15 06:31:31 UTC

[PR] fix(databricks): select the SQLAlchemy 2 dialect [superset]

aminghadersohi opened a new pull request, #44286:
URL: https://github.com/apache/superset/pull/44286

   ### SUMMARY
   The `databricks` extra pins `databricks-sqlalchemy==1.0.5`, which unconditionally requires `sqlalchemy>=1.3.24,<2.0.0` and therefore cannot resolve with Superset's SQLAlchemy 2 requirement. Select `databricks-sqlalchemy>=2.0.1,<3`: 2.0.1 is the first stable 2.x release and requires SQLAlchemy>=2.0.21.
   
   Keep the connector range unchanged. Add an optional real-dialect regression that first checks its published SQLAlchemy requirement, then constructs the canonical `databricks://` engine, verifies HTTP path/catalog/schema/native parameter arguments, and compiles a bound query without sockets. Document the requirement in engine metadata, its regenerated documentation field, and UPDATING.md. No requirements lock change: this extra is not in the development install.
   
   Independent slice of [SC-120252](https://app.shortcut.com/preset/story/120252), tracked by [SC-121011](https://app.shortcut.com/preset/story/121011). This is not #44278's legacy ODBC/saved-URI migration and does not change Shell's connector overrides or production-image contract.
   
   ### TESTING INSTRUCTIONS
   - Resolver negative: `uv pip install --dry-run 'databricks-sqlalchemy==1.0.5' 'sqlalchemy==2.0.52'` fails at the unconditional `<2` constraint.
   - Python 3.11 / SQLAlchemy2.0.52 / greenlet3.5.5 / dialect2.0.1 / connector4.5.0 / pyarrow25.0.1: `pytest -q tests/unit_tests/db_engine_specs/test_databricks.py` — **65 passed**. Independently reviewed and rerun; final pinned-greenlet rerun also65.
   - Old1.0.5 metadata control fails the intended SQLAlchemy-version assertion before dialect import. The test order avoids an incidental namespace-overlay import failure masquerading as SQLAlchemy evidence.
   - Staged pre-commit: all applicable hooks pass, including mypy/Ruff/pylint/metadata validation. Relevant generated docs field verified; unrelated generator drift excluded.
   
   The new regression skips when this optional dialect distribution is absent (including the default CI install). These are explicit local exact-floor/connectionless tests, not live Databricks, authentication/TLS, reflection, or exact production-image qualification. Existing latest/range installs are not proof that every future release works.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Not applicable.
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue: [SC-121011](https://app.shortcut.com/preset/story/121011)
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(databricks): select the SQLAlchemy 2 dialect [superset]

Posted by "aminghadersohi (via GitHub)" <gi...@apache.org>.
aminghadersohi commented on PR #44286:
URL: https://github.com/apache/superset/pull/44286#issuecomment-5675927431

   Final scope/CI checkpoint: independent review found no blocking implementation issues; canonical zone-pinned branch matches this published head. Hosted pre-commit and all 20 testcontainers jobs pass. Full unit suite remains pending; overall CI is not green. Actual migration-startup logs report Multiple head revisions on unchanged master (`c7f53d184ea2` and `88a01c781622`). Separate baseline repair is tracked as SC-121019, not folded into this driver PR. Full inventory/overlap and evidence boundaries: https://agor.sandbox.preset.zone/ui/kb/work-log/sqlalchemy2/sc120252-driver-floor-audit-2026-09-15.md . No formal human approval, live/exact-image qualification, or merge claimed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(databricks): select the SQLAlchemy 2 dialect [superset]

Posted by "aminghadersohi (via GitHub)" <gi...@apache.org>.
aminghadersohi commented on PR #44286:
URL: https://github.com/apache/superset/pull/44286#issuecomment-5685592436

   Review-range correction pushed as 822336d19a4baf6789623807b89d94a104704534; the only review thread is addressed. All five branch-changed files passed scoped pre-commit, and the focused Databricks suite passed 65 tests at the exact dialect floor.
   
   CI is **not green**. I inspected all 15 failed checks on the preceding head: twelve execution jobs fail during migration startup with multiple Alembic heads, and three required aggregate checks propagate those failures. None of the skipped checks is required; their workflow conditions exclude this PR (frontend-only jobs, Dependabot/first-contributor/label automation, and master-only image tagging).
   
   The shared repair remains a landing dependency: #44288 and #44317 overlap, so maintainers must select one and coordinate #44283. #44317 has human approval but CI is still running. I will update this branch onto repaired master and monitor the resulting exact-head CI after the selected fix lands. No migration workaround, merge, draft conversion, or zone move is being performed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(databricks): select the SQLAlchemy 2 dialect [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44286:
URL: https://github.com/apache/superset/pull/44286#issuecomment-5675820666

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(databricks): select the SQLAlchemy 2 dialect [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44286:
URL: https://github.com/apache/superset/pull/44286#issuecomment-5688198595

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
   
   <details>
   <summary>
   Bito Usage Guide
   </summary>
   
   **Commands**
         
   Type the following command in the pull request comment and save the comment.
         
   - `/review` - Manually triggers an incremental AI Review.
   - `/review full` - Manually triggers a full AI Review.
   
   - `/pause` - Pauses automatic reviews on this pull request.
   - `/resume` - Resumes automatic reviews.
   - `/resolve` - Marks all Bito-posted review comments as resolved.
   - `/abort` - Cancels all in-progress reviews.
   
         
   Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
         
   **Configuration**
   
   This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
         
   **Documentation & Help**
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(databricks): select the SQLAlchemy 2 dialect [superset]

Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #44286:
URL: https://github.com/apache/superset/pull/44286#issuecomment-5675845621

   ### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
   
   
   |  Name | Link |
   |:-:|------------------------|
   |<span aria-hidden="true">🔨</span> Latest commit | fa21805e5a2702521e766b78b9b533b6cbd27802 |
   |<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6aa8e64309b87800089d7093 |
   |<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-44286--superset-docs-preview.netlify.app](https://deploy-preview-44286--superset-docs-preview.netlify.app) |
   |<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br />![QR Code](https://app.netlify.com/qr-code/eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1cmwiOiJodHRwczovL2RlcGxveS1wcmV2aWV3LTQ0Mjg2LS1zdXBlcnNldC1kb2NzLXByZXZpZXcubmV0bGlmeS5hcHAifQ.cVGvrrjCzLD2lNkig7mUgkN8LH0iNTQ2THtplaHP78Y)<br /><br />_Use your smartphone camera to open QR code link._</details> |
   |<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DcrJDYAgEADAXvYtyUYMhx1YxnIYjCAIfoixd_nNY14oNafywAowgal02TDc7kjRBp_6zBw9ZOphz8b2mHMdz_kSc9_cmIJIebFw1EZJhYhKO4maw_cD) |
   ---
   <!-- [superset-docs-preview Preview](https://deploy-preview-44286--superset-docs-preview.netlify.app) -->
   _To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(databricks): select the SQLAlchemy 2 dialect [superset]

Posted by "aminghadersohi (via GitHub)" <gi...@apache.org>.
aminghadersohi commented on code in PR #44286:
URL: https://github.com/apache/superset/pull/44286#discussion_r4018790019


##########
UPDATING.md:
##########
@@ -24,6 +24,8 @@ assists people when migrating to a new version.
 
 ## Next
 
+- The Databricks extra requires databricks-sqlalchemy 2.0.1 or later. The 1.x dialect requires SQLAlchemy below 2.

Review Comment:
   Fixed in 822336d19a4baf6789623807b89d94a104704534. UPDATING.md, the Databricks engine metadata, and docs/src/data/databases.json all say “databricks-sqlalchemy 2.x (at least 2.0.1),” matching the >=2.0.1,<3 extra. Scoped pre-commit (all five branch-changed files, including mypy/Ruff/pylint/metadata validation) passed. The focused real-dialect suite passed: 65 tests with SQLAlchemy 2.0.52, dialect 2.0.1, connector 4.5.0, and greenlet 3.5.5.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(databricks): select the SQLAlchemy 2 dialect [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44286:
URL: https://github.com/apache/superset/pull/44286#issuecomment-5690153961

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
   
   <details>
   <summary>
   Bito Usage Guide
   </summary>
   
   **Commands**
         
   Type the following command in the pull request comment and save the comment.
         
   - `/review` - Manually triggers an incremental AI Review.
   - `/review full` - Manually triggers a full AI Review.
   
   - `/pause` - Pauses automatic reviews on this pull request.
   - `/resume` - Resumes automatic reviews.
   - `/resolve` - Marks all Bito-posted review comments as resolved.
   - `/abort` - Cancels all in-progress reviews.
   
         
   Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
         
   **Configuration**
   
   This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
         
   **Documentation & Help**
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(databricks): select the SQLAlchemy 2 dialect [superset]

Posted by "aminghadersohi (via GitHub)" <gi...@apache.org>.
aminghadersohi commented on PR #44286:
URL: https://github.com/apache/superset/pull/44286#issuecomment-5688288754

   The shared repair #44288 has landed on master as 4c27cbd007efa298c2c1101b85a1ea158ed0502a. Verified master contains that commit and the migration graph has exactly one head, e2f3a1b9c640. Rebased this PR onto repaired master without conflicts; this PR still changes only the original five Databricks files and contains no independent migration repair.
   
   Published rebased head: 56a03189babe41f12b88cae35b94909ef0f9c943, using an explicit lease against the previous 822336d19a4baf6789623807b89d94a104704534 head. All applicable scoped pre-commit hooks passed again, and all 65 focused Databricks tests passed at the exact dialect floor. Fresh CI is being monitored; no green result is claimed until every applicable check succeeds. The documentation review thread remains resolved. No merge, draft conversion, or zone movement.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(databricks): select the SQLAlchemy 2 dialect [superset]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #44286:
URL: https://github.com/apache/superset/pull/44286#issuecomment-5676044311

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/44286?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 75.91%. Comparing base ([`b6de64f`](https://app.codecov.io/gh/apache/superset/commit/b6de64fce749f9d537a32893ef957a70b0b4cb25?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fa21805`](https://app.codecov.io/gh/apache/superset/commit/fa21805e5a2702521e766b78b9b533b6cbd27802?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 1 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #44286      +/-   ##
   ==========================================
   - Coverage   75.91%   75.91%   -0.01%     
   ==========================================
     Files        2926     2926              
     Lines      173023   173023              
     Branches    40139    40139              
   ==========================================
   - Hits       131351   131349       -2     
   - Misses      38993    38995       +2     
     Partials     2679     2679              
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/44286/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [python](https://app.codecov.io/gh/apache/superset/pull/44286/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `76.14% <ø> (-0.01%)` | :arrow_down: |
   | [unit](https://app.codecov.io/gh/apache/superset/pull/44286/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `76.14% <ø> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/44286?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(databricks): select the SQLAlchemy 2 dialect [superset]

Posted by "aminghadersohi (via GitHub)" <gi...@apache.org>.
aminghadersohi commented on PR #44286:
URL: https://github.com/apache/superset/pull/44286#issuecomment-5676109873

   The shared master Alembic startup blocker is isolated in ready PR #44288 (`d6f00dcffec9beb74bc9480b40f38515c5527a5a`): a no-op merge of `c7f53d184ea2` and `88a01c781622`, reproduced on master `ae240a8e6f0332acb709943d0884eae73927c9de`.
   
   No driver changes or migration workarounds are added here. Graph/SQLite upgrade-downgrade validation and 147 focused migration tests pass; independent review found no correctness issues. #44288's CI/maintainer review is pending, and its landing must be coordinated with the overlapping ClickHouse migration in #44283. The general Python-Unit jobs on #44285/#44286/#44287 passed; the confirmed blocker is in migration-dependent startup jobs, not that general unit suite. Nothing has been merged.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(databricks): select the SQLAlchemy 2 dialect [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #44286:
URL: https://github.com/apache/superset/pull/44286


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(databricks): select the SQLAlchemy 2 dialect [superset]

Posted by "aminghadersohi (via GitHub)" <gi...@apache.org>.
aminghadersohi commented on PR #44286:
URL: https://github.com/apache/superset/pull/44286#issuecomment-5688635497

   ## Final exact-head CI and review verification
   
   Verified 2026-09-15 21:56 UTC. Head: `56a03189babe41f12b88cae35b94909ef0f9c943`.
   
   **All applicable CI checks are terminal SUCCESS.** Full rollup: **86 SUCCESS, 10 SKIPPED, 2 NEUTRAL** (98 entries). **All 13 required checks are SUCCESS.** No failed, cancelled, action-required, queued, pending, or skipped-required checks remain.
   
   - Corrected all three documentation locations to “databricks-sqlalchemy 2.x (at least 2.0.1).” The sole review thread is answered and resolved; pagination is exhausted.
   - Waited for the separately maintained #44288 repair to land as `4c27cbd007efa298c2c1101b85a1ea158ed0502a`, verified it on master with sole migration head `e2f3a1b9c640`, then rebased without conflicts and pushed with an explicit expected-SHA lease. No migration repair was added to this PR’s five-file diff.
   - Rebased-head scoped pre-commit passed, including mypy/Ruff/pylint/metadata validation. Focused Databricks suite: **65 passed** with SQLAlchemy 2.0.52, dialect 2.0.1, connector 4.5.0, and greenlet 3.5.5. These are connectionless tests, not live Databricks qualification.
   - Ten skipped checks are non-required and excluded by workflow conditions: six frontend-only child jobs, Dependabot approval/requirements synchronization, first-contributor welcome, and master-push-only image tagging.
   - The two NEUTRAL results are Netlify informational Header rules / Pages changed reports. The actual deploy-preview and Redirect rules checks are SUCCESS; the neutral reports are not being relabeled SUCCESS.
   - **Remaining gate: human maintainer review/approval (REVIEW_REQUIRED).** No unresolved review threads or CI blockers remain. PR remains OPEN, non-draft, MERGEABLE; no merge performed. Clean worktree remains in zone-sqlalchemy-2.
   
   <details>
   <summary>Full check rollup — all 98 entries</summary>
   
   | Workflow | Check | Conclusion | Required |
   |---|---|---|---|
   | Auto-approve Dependabot patch bumps | [Approve patch-level bump ](https://github.com/apache/superset/actions/runs/35025374869/job/104571008784) | SKIPPED | No |
   | Sync requirements for Python dependency PRs | [sync-python-dep-requirements ](https://github.com/apache/superset/actions/runs/35025374805/job/104571008245) | SKIPPED | No |
   | 🎪 Superset Showtime | [🎪 Sync PR to desired state ](https://github.com/apache/superset/actions/runs/35025372935/job/104571048994) | SKIPPED | No |
   | Build & publish docker images | [changes ](https://github.com/apache/superset/actions/runs/35025375078/job/104571008410) | SUCCESS | No |
   | Check OpenAPI spec drift | [check-openapi-spec-drift ](https://github.com/apache/superset/actions/runs/35025374827/job/104571006701) | SUCCESS | No |
   | Check python dependencies | [check-python-deps ](https://github.com/apache/superset/actions/runs/35025374828/job/104571007120) | SUCCESS | No |
   | CodeQL | [changes ](https://github.com/apache/superset/actions/runs/35025374700/job/104571007036) | SUCCESS | No |
   | Dependency Review | [dependency-review ](https://github.com/apache/superset/actions/runs/35025374681/job/104571007510) | SUCCESS | Yes |
   | E2E | [changes ](https://github.com/apache/superset/actions/runs/35025374961/job/104571007647) | SUCCESS | No |
   | Enforce single Alembic migration head | [enforce-single-migration-head ](https://github.com/apache/superset/actions/runs/35025374885/job/104571007250) | SUCCESS | Yes |
   | Frontend Build CI (unit tests, linting & sanity checks) | [frontend-build ](https://github.com/apache/superset/actions/runs/35025374963/job/104571007952) | SUCCESS | Yes |
   | Hold Label Check | [check-hold-label ](https://github.com/apache/superset/actions/runs/35025374834/job/104571007336) | SUCCESS | No |
   | License Template Check | [License Check ](https://github.com/apache/superset/actions/runs/35025374672/job/104571006632) | SUCCESS | No |
   | PR Lint | [lint-check ](https://github.com/apache/superset/actions/runs/35025374898/job/104571007302) | SUCCESS | Yes |
   | Playwright Experimental Tests | [changes ](https://github.com/apache/superset/actions/runs/35025374750/job/104571007085) | SUCCESS | No |
   | Pull Request Labeler | [labeler ](https://github.com/apache/superset/actions/runs/35025372990/job/104571000984) | SUCCESS | No |
   | Python Presto/Hive | [changes ](https://github.com/apache/superset/actions/runs/35025374933/job/104571007785) | SUCCESS | No |
   | Python-Integration | [changes ](https://github.com/apache/superset/actions/runs/35025374935/job/104571015812) | SUCCESS | No |
   | Python-Unit | [changes ](https://github.com/apache/superset/actions/runs/35025374921/job/104571007859) | SUCCESS | No |
   | Superset App CLI tests | [test-load-examples ](https://github.com/apache/superset/actions/runs/35025374947/job/104571007563) | SUCCESS | No |
   | Superset Extensions CLI Package Tests | [test-superset-extensions-cli-package (current) ](https://github.com/apache/superset/actions/runs/35025374965/job/104571007330) | SUCCESS | No |
   | Testcontainers | [compute-matrix ](https://github.com/apache/superset/actions/runs/35025374924/job/104571007581) | SUCCESS | No |
   | Translations | [frontend-check-translations ](https://github.com/apache/superset/actions/runs/35025374858/job/104571007537) | SUCCESS | No |
   | Validate All GitHub Actions | [validate-all-ghas ](https://github.com/apache/superset/actions/runs/35025374883/job/104571007843) | SUCCESS | No |
   | pre-commit checks | [pre-commit (current) ](https://github.com/apache/superset/actions/runs/35025374779/job/104571007391) | SUCCESS | Yes |
   | Frontend Build CI (unit tests, linting & sanity checks) | [sharded-jest-tests ](https://github.com/apache/superset/actions/runs/35025374963/job/104571342746) | SKIPPED | No |
   | Build & publish docker images | [setup_matrix ](https://github.com/apache/superset/actions/runs/35025375078/job/104571008558) | SUCCESS | No |
   | CodeQL | [Analyze (python) ](https://github.com/apache/superset/actions/runs/35025374700/job/104571183302) | SUCCESS | No |
   | Dependency Review | [python-dependency-liccheck ](https://github.com/apache/superset/actions/runs/35025374681/job/104571007183) | SUCCESS | No |
   | E2E | [cypress-matrix (chrome) ](https://github.com/apache/superset/actions/runs/35025374961/job/104571156455) | SUCCESS | No |
   | Playwright Experimental Tests | [playwright-tests-experimental (chromium) ](https://github.com/apache/superset/actions/runs/35025374750/job/104571169774) | SUCCESS | No |
   | Python Presto/Hive | [test-postgres-presto ](https://github.com/apache/superset/actions/runs/35025374933/job/104571156061) | SUCCESS | Yes |
   | Python-Integration | [test-mysql ](https://github.com/apache/superset/actions/runs/35025374935/job/104571160641) | SUCCESS | Yes |
   | Python-Unit | [event-file ](https://github.com/apache/superset/actions/runs/35025374921/job/104571007892) | SUCCESS | No |
   | Superset Extensions CLI Package Tests | [actions-timeline ](https://github.com/apache/superset/actions/runs/35025374965/job/104571190016) | SUCCESS | No |
   | Testcontainers | [testcontainers (cockroachdb, 10) ](https://github.com/apache/superset/actions/runs/35025374924/job/104571046772) | SUCCESS | No |
   | Translations | [babel-extract ](https://github.com/apache/superset/actions/runs/35025374858/job/104571007689) | SUCCESS | No |
   | pre-commit checks | [actions-timeline ](https://github.com/apache/superset/actions/runs/35025374779/job/104572541991) | SUCCESS | No |
   | CodeQL | [Analyze (javascript) ](https://github.com/apache/superset/actions/runs/35025374700/job/104571183209) | SUCCESS | No |
   | Playwright Experimental Tests | [playwright-tests-experimental (chromium, /app/prefix) ](https://github.com/apache/superset/actions/runs/35025374750/job/104571169839) | SUCCESS | No |
   | Testcontainers | [testcontainers (crate, 10) ](https://github.com/apache/superset/actions/runs/35025374924/job/104571046610) | SUCCESS | No |
   | Testcontainers | [testcontainers (trino, 10) ](https://github.com/apache/superset/actions/runs/35025374924/job/104571046681) | SUCCESS | No |
   | Testcontainers | [testcontainers (mssql, 10) ](https://github.com/apache/superset/actions/runs/35025374924/job/104571046677) | SUCCESS | No |
   | Testcontainers | [testcontainers (elasticsearch, 10) ](https://github.com/apache/superset/actions/runs/35025374924/job/104571046646) | SUCCESS | No |
   | Testcontainers | [testcontainers (oracle, 15) ](https://github.com/apache/superset/actions/runs/35025374924/job/104571046562) | SUCCESS | No |
   | Testcontainers | [testcontainers (db2, 25) ](https://github.com/apache/superset/actions/runs/35025374924/job/104571046754) | SUCCESS | No |
   | Testcontainers | [testcontainers (mariadb, 10) ](https://github.com/apache/superset/actions/runs/35025374924/job/104571046734) | SUCCESS | No |
   | Testcontainers | [testcontainers (timescaledb, 10) ](https://github.com/apache/superset/actions/runs/35025374924/job/104571046659) | SUCCESS | No |
   | Testcontainers | [testcontainers (yugabytedb, 10) ](https://github.com/apache/superset/actions/runs/35025374924/job/104571046612) | SUCCESS | No |
   | Testcontainers | [testcontainers (monetdb, 10) ](https://github.com/apache/superset/actions/runs/35025374924/job/104571046603) | SUCCESS | No |
   | Testcontainers | [testcontainers (mongodb, 10) ](https://github.com/apache/superset/actions/runs/35025374924/job/104571046592) | SUCCESS | No |
   | Testcontainers | [testcontainers (postgres, 10) ](https://github.com/apache/superset/actions/runs/35025374924/job/104571047275) | SUCCESS | No |
   | Testcontainers | [testcontainers (mysql, 10) ](https://github.com/apache/superset/actions/runs/35025374924/job/104571046624) | SUCCESS | No |
   | Testcontainers | [testcontainers (clickhouse, 10) ](https://github.com/apache/superset/actions/runs/35025374924/job/104571046732) | SUCCESS | No |
   | Testcontainers | [testcontainers (starrocks, 15) ](https://github.com/apache/superset/actions/runs/35025374924/job/104571046731) | SUCCESS | No |
   | Testcontainers | [testcontainers (databend, 10) ](https://github.com/apache/superset/actions/runs/35025374924/job/104571046726) | SUCCESS | No |
   | Testcontainers | [testcontainers (risingwave, 10) ](https://github.com/apache/superset/actions/runs/35025374924/job/104571046737) | SUCCESS | No |
   | Testcontainers | [testcontainers (firebird, 10) ](https://github.com/apache/superset/actions/runs/35025374924/job/104571046706) | SUCCESS | No |
   | Testcontainers | [testcontainers (ydb, 10) ](https://github.com/apache/superset/actions/runs/35025374924/job/104571046730) | SUCCESS | No |
   | Frontend Build CI (unit tests, linting & sanity checks) | [lint-frontend ](https://github.com/apache/superset/actions/runs/35025374963/job/104571342874) | SKIPPED | No |
   | Build & publish docker images | [verify docker build PY_VER override ](https://github.com/apache/superset/actions/runs/35025375078/job/104571008557) | SUCCESS | No |
   | E2E | [playwright-tests (chromium) ](https://github.com/apache/superset/actions/runs/35025374961/job/104571156293) | SUCCESS | No |
   | Playwright Experimental Tests | [actions-timeline ](https://github.com/apache/superset/actions/runs/35025374750/job/104574551683) | SUCCESS | No |
   | Python Presto/Hive | [test-postgres-hive ](https://github.com/apache/superset/actions/runs/35025374933/job/104571156101) | SUCCESS | Yes |
   | Python-Integration | [test-postgres (current) ](https://github.com/apache/superset/actions/runs/35025374935/job/104571160574) | SUCCESS | No |
   | Python-Unit | [unit-tests (current) ](https://github.com/apache/superset/actions/runs/35025374921/job/104571156492) | SUCCESS | No |
   | Testcontainers | [actions-timeline ](https://github.com/apache/superset/actions/runs/35025374924/job/104571884785) | SUCCESS | No |
   | Translations | [actions-timeline ](https://github.com/apache/superset/actions/runs/35025374858/job/104571625739) | SUCCESS | No |
   | E2E | [playwright-tests (chromium, /app/prefix) ](https://github.com/apache/superset/actions/runs/35025374961/job/104571156253) | SUCCESS | No |
   | Build & publish docker images | [docker-compose-image-tag ](https://github.com/apache/superset/actions/runs/35025375078/job/104571162369) | SKIPPED | No |
   | Frontend Build CI (unit tests, linting & sanity checks) | [validate-frontend ](https://github.com/apache/superset/actions/runs/35025374963/job/104571343380) | SKIPPED | No |
   | E2E | [cypress-matrix-required ](https://github.com/apache/superset/actions/runs/35025374961/job/104574740181) | SUCCESS | Yes |
   | Python Presto/Hive | [actions-timeline ](https://github.com/apache/superset/actions/runs/35025374933/job/104572405059) | SUCCESS | No |
   | Python-Integration | [test-sqlite ](https://github.com/apache/superset/actions/runs/35025374935/job/104571160608) | SUCCESS | Yes |
   | Python-Unit | [unit-tests-required ](https://github.com/apache/superset/actions/runs/35025374921/job/104576318656) | SUCCESS | Yes |
   | Frontend Build CI (unit tests, linting & sanity checks) | [test-storybook ](https://github.com/apache/superset/actions/runs/35025374963/job/104571342808) | SKIPPED | No |
   | Build & publish docker images | [docker-build (superset) ](https://github.com/apache/superset/actions/runs/35025375078/job/104571160768) | SUCCESS | No |
   | E2E | [playwright-tests-required ](https://github.com/apache/superset/actions/runs/35025374961/job/104576491212) | SUCCESS | Yes |
   | Python-Integration | [test-postgres-required ](https://github.com/apache/superset/actions/runs/35025374935/job/104579109890) | SUCCESS | Yes |
   | Build & publish docker images | [docker-build (dev) ](https://github.com/apache/superset/actions/runs/35025375078/job/104571160730) | SUCCESS | No |
   | Build & publish docker images | [docker-build (lean) ](https://github.com/apache/superset/actions/runs/35025375078/job/104571160821) | SUCCESS | No |
   | Frontend Build CI (unit tests, linting & sanity checks) | [bundle-size ](https://github.com/apache/superset/actions/runs/35025374963/job/104571342530) | SKIPPED | No |
   | Build & publish docker images | [actions-timeline ](https://github.com/apache/superset/actions/runs/35025375078/job/104574595732) | SUCCESS | No |
   | E2E | [actions-timeline ](https://github.com/apache/superset/actions/runs/35025374961/job/104576523397) | SUCCESS | No |
   | Python-Integration | [actions-timeline ](https://github.com/apache/superset/actions/runs/35025374935/job/104579141855) | SUCCESS | No |
   | Frontend Build CI (unit tests, linting & sanity checks) | [report-coverage ](https://github.com/apache/superset/actions/runs/35025374963/job/104571344531) | SKIPPED | No |
   | Frontend Build CI (unit tests, linting & sanity checks) | [actions-timeline ](https://github.com/apache/superset/actions/runs/35025374963/job/104571343145) | SUCCESS | No |
   | External status | [Header rules - superset-docs-preview ](https://app.netlify.com/projects/superset-docs-preview/deploys/6aa9b767fa08260008857615) | NEUTRAL | No |
   | External status | [Pages changed - superset-docs-preview ](https://app.netlify.com/projects/superset-docs-preview/deploys/6aa9b767fa08260008857615) | NEUTRAL | No |
   | External status | [CodeQL ](https://github.com/apache/superset/runs/104571622956) | SUCCESS | No |
   | External status | [zizmor ](https://github.com/apache/superset/runs/104571184374) | SUCCESS | No |
   | External status | [Redirect rules - superset-docs-preview ](https://app.netlify.com/projects/superset-docs-preview/deploys/6aa9b767fa08260008857615) | SUCCESS | No |
   | External status | [codecov/patch ](https://app.codecov.io/gh/apache/superset/pull/44286) | SUCCESS | No |
   | External status | [codecov/project ](https://app.codecov.io/gh/apache/superset/pull/44286) | SUCCESS | No |
   | External status | [codecov/project/core-packages-ts ](https://app.codecov.io/gh/apache/superset/pull/44286) | SUCCESS | No |
   | External status | [codecov/project/core-packages-tsx ](https://app.codecov.io/gh/apache/superset/pull/44286) | SUCCESS | No |
   | External status | [netlify/superset-docs-preview/deploy-preview ](https://deploy-preview-44286--superset-docs-preview.netlify.app) | SUCCESS | No |
   | 🎪 Superset Showtime | [Python Unit Test Results ](https://github.com/apache/superset/runs/104576477687) | SUCCESS | No |
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(databricks): select the SQLAlchemy 2 dialect [superset]

Posted by "aminghadersohi (via GitHub)" <gi...@apache.org>.
aminghadersohi commented on PR #44286:
URL: https://github.com/apache/superset/pull/44286#issuecomment-5688807910

   @rusackas — Amin has assigned you for review. When you have a moment, could you please take a look? Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(databricks): select the SQLAlchemy 2 dialect [superset]

Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #44286:
URL: https://github.com/apache/superset/pull/44286#discussion_r4012700089


##########
UPDATING.md:
##########
@@ -24,6 +24,8 @@ assists people when migrating to a new version.
 
 ## Next
 
+- The Databricks extra requires databricks-sqlalchemy 2.0.1 or later. The 1.x dialect requires SQLAlchemy below 2.

Review Comment:
   **Suggestion:** The extra also excludes databricks-sqlalchemy 3.x, but “2.0.1 or later” implies every newer version is supported and can mislead users into an unsatisfiable installation. [api mismatch]
   
   **Assessment:** 🟠 `Major` · 🔁 `Occurrence: Rarely`
   
   [![Use CodeAnt Skill](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/use-codeant-skill-flat-v2.svg)](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [![Fix in Cursor](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-cursor-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=cf07294a705948c4a1952a14f7793aa9&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [![Fix in VSCode Claude](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-vscode-claude-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=cf07294a705948c4a1952a14f7793aa9&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** UPDATING.md
   **Line:** 27:27
   **Comment:**
   	*Api Mismatch: The extra also excludes databricks-sqlalchemy 3.x, but “2.0.1 or later” implies every newer version is supported and can mislead users into an unsatisfiable installation.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
   Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
   ```
   </details>
   <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44286&comment_hash=a50ec52f6dc4ad8936f3889ee9d4260b3638bf318a78550757279cfdd07c06a6&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44286&comment_hash=a50ec52f6dc4ad8936f3889ee9d4260b3638bf318a78550757279cfdd07c06a6&reaction=dislike'>👎</a>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(databricks): select the SQLAlchemy 2 dialect [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44286:
URL: https://github.com/apache/superset/pull/44286#issuecomment-5675899904

   <!-- Bito Reply -->
   The flagged issue is correct. The current dependency definition in `pyproject.toml` uses `databricks-sqlalchemy>=2.0.1, <3`, which correctly restricts the version to the 2.x series. However, the documentation in `UPDATING.md` and `superset/db_engine_specs/databricks.py` states "2.0.1 or later," which implies support for 3.x and beyond, creating a mismatch with the actual package constraints.
   
   To resolve this, update the documentation to explicitly mention the supported version range. Would you like me to implement this change across the documentation files, and would you like me to check the rest of the PR comments for other issues?
   
   **UPDATING.md**
   ```
   - The Databricks extra requires databricks-sqlalchemy 2.0.1 or later (up to 3.x). The 1.x dialect requires SQLAlchemy below 2.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org