You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by Viraj Bhat <vi...@yahoo-inc.com> on 2013/05/23 02:12:14 UTC
Re: Review Request: PIG-3318 Patch to address default values when schemas
are merged in AvroStorage. It does this for Records containing primitive
values
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11135/
-----------------------------------------------------------
(Updated May 23, 2013, 12:12 a.m.)
Review request for pig.
Summary (updated)
-----------------
PIG-3318 Patch to address default values when schemas are merged in AvroStorage. It does this for Records containing primitive values
Description
-------
Default values are not honoured when merging default schema
This addresses bug PIG-3318.
https://issues.apache.org/jira/browse/PIG-3318
Diffs
-----
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorage.java 1484564
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java 1484564
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroInputFormat.java 1484564
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroRecordReader.java 1484564
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/TestAvroStorage.java 1484564
Diff: https://reviews.apache.org/r/11135/diff/
Testing
-------
Yes
Thanks,
Viraj Bhat
Re: Review Request: PIG-3318 Patch to address default values when schemas
are merged in AvroStorage. It does this for Records containing primitive
values
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11135/#review21046
-----------------------------------------------------------
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorage.java
<https://reviews.apache.org/r/11135/#comment43545>
When user has specified a input schema, that needs to be used as the reader schema. If not, then the merged schema for that path needs to be used as the reader schema.
Need to throw error if both multiple_schemas and user defined schema is present.
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java
<https://reviews.apache.org/r/11135/#comment43543>
formatting
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java
<https://reviews.apache.org/r/11135/#comment43544>
Why not just set default on the mergedSchema for FIXED and primitive types (or throw an error if there is a conflict) and be done with it?
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroRecordReader.java
<https://reviews.apache.org/r/11135/#comment43546>
Why do we need to initialize with default values. If the merged reader schema, has the default value won't it be automatically set?
- Rohini Palaniswamy
On May 23, 2013, 12:12 a.m., Viraj Bhat wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11135/
> -----------------------------------------------------------
>
> (Updated May 23, 2013, 12:12 a.m.)
>
>
> Review request for pig.
>
>
> Description
> -------
>
> Default values are not honoured when merging default schema
>
>
> This addresses bug PIG-3318.
> https://issues.apache.org/jira/browse/PIG-3318
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorage.java 1484564
> http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java 1484564
> http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroInputFormat.java 1484564
> http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroRecordReader.java 1484564
> http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/TestAvroStorage.java 1484564
>
> Diff: https://reviews.apache.org/r/11135/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Viraj Bhat
>
>
Re: Review Request: PIG-3318 Patch to address default values when schemas
are merged in AvroStorage. It does this for Records containing primitive
values
Posted by Viraj Bhat <vi...@yahoo-inc.com>.
> On June 10, 2013, 7:06 p.m., Rohini Palaniswamy wrote:
> > http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java, lines 327-338
> > <https://reviews.apache.org/r/11135/diff/5/?file=295050#file295050line327>
> >
> > This can be simplified into few lines
This was fixed by creating a new function which will make the code more readable.
- Viraj
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11135/#review21662
-----------------------------------------------------------
On May 30, 2013, 2:28 a.m., Viraj Bhat wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11135/
> -----------------------------------------------------------
>
> (Updated May 30, 2013, 2:28 a.m.)
>
>
> Review request for pig and Rohini Palaniswamy.
>
>
> Description
> -------
>
> Default values are not honoured when merging default schema
>
>
> This addresses bug PIG-3318.
> https://issues.apache.org/jira/browse/PIG-3318
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorage.java 1484564
> http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java 1484564
> http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroInputFormat.java 1484564
> http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroRecordReader.java 1484564
> http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/TestAvroStorage.java 1484564
>
> Diff: https://reviews.apache.org/r/11135/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Viraj Bhat
>
>
Re: Review Request: PIG-3318 Patch to address default values when schemas
are merged in AvroStorage. It does this for Records containing primitive
values
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11135/#review21662
-----------------------------------------------------------
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java
<https://reviews.apache.org/r/11135/#comment44774>
This can be simplified into few lines
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java
<https://reviews.apache.org/r/11135/#comment44773>
Don't need a if else here
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroInputFormat.java
<https://reviews.apache.org/r/11135/#comment44775>
New variable not required. Can check if schemaToMergedSchemaMap is not null or empty
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroRecordReader.java
<https://reviews.apache.org/r/11135/#comment44776>
Remove this line
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroRecordReader.java
<https://reviews.apache.org/r/11135/#comment44777>
Keep subFields.get(i).defaultValue() in a local variable instead of repeating
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/TestAvroStorage.java
<https://reviews.apache.org/r/11135/#comment44778>
testMultipleSchemasWithDefaultValue
- Rohini Palaniswamy
On May 30, 2013, 2:28 a.m., Viraj Bhat wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11135/
> -----------------------------------------------------------
>
> (Updated May 30, 2013, 2:28 a.m.)
>
>
> Review request for pig and Rohini Palaniswamy.
>
>
> Description
> -------
>
> Default values are not honoured when merging default schema
>
>
> This addresses bug PIG-3318.
> https://issues.apache.org/jira/browse/PIG-3318
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorage.java 1484564
> http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java 1484564
> http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroInputFormat.java 1484564
> http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroRecordReader.java 1484564
> http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/TestAvroStorage.java 1484564
>
> Diff: https://reviews.apache.org/r/11135/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Viraj Bhat
>
>
Re: Review Request: PIG-3318 Patch to address default values when schemas
are merged in AvroStorage. It does this for Records containing primitive
values
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11135/#review21704
-----------------------------------------------------------
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java
<https://reviews.apache.org/r/11135/#comment44865>
Should be outside if else
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroRecordReader.java
<https://reviews.apache.org/r/11135/#comment44866>
Do not need this variable. Can do if else on the condition
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroRecordReader.java
<https://reviews.apache.org/r/11135/#comment44867>
formatting. space after ,
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroRecordReader.java
<https://reviews.apache.org/r/11135/#comment44868>
formatting. Code in next line
- Rohini Palaniswamy
On June 11, 2013, 3:04 a.m., Viraj Bhat wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11135/
> -----------------------------------------------------------
>
> (Updated June 11, 2013, 3:04 a.m.)
>
>
> Review request for pig and Rohini Palaniswamy.
>
>
> Description
> -------
>
> Default values are not honoured when merging default schema
>
>
> This addresses bug PIG-3318.
> https://issues.apache.org/jira/browse/PIG-3318
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorage.java 1491556
> http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java 1491556
> http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroRecordReader.java 1491556
> http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/TestAvroStorage.java 1491562
>
> Diff: https://reviews.apache.org/r/11135/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Viraj Bhat
>
>
Re: Review Request: PIG-3318 Patch to address default values when schemas
are merged in AvroStorage. It does this for Records containing primitive
values
Posted by Viraj Bhat <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11135/
-----------------------------------------------------------
(Updated June 14, 2013, 12:15 a.m.)
Review request for pig and Rohini Palaniswamy.
Changes
-------
Indentation and variable case changes.
Description
-------
Default values are not honoured when merging default schema
This addresses bug PIG-3318.
https://issues.apache.org/jira/browse/PIG-3318
Diffs (updated)
-----
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorage.java 1491556
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java 1491556
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroInputFormat.java 1491556
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroRecordReader.java 1491556
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/TestAvroStorage.java 1491562
Diff: https://reviews.apache.org/r/11135/diff/
Testing
-------
Yes
Thanks,
Viraj Bhat
Re: Review Request: PIG-3318 Patch to address default values when schemas
are merged in AvroStorage. It does this for Records containing primitive
values
Posted by Viraj Bhat <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11135/
-----------------------------------------------------------
(Updated June 13, 2013, 6:34 p.m.)
Review request for pig and Rohini Palaniswamy.
Changes
-------
1) Change the testcase to use mockstorage
2) Remove the condition that does not verify results in Hadoop 23
3) Add back the "usemultipleSchemas" flag to handle cases when schemaToMergedSchemaMap is null and multiple_schemas is invoked. Test case testMultipleSchema1 fails for the previous patch
4) Testing done with Hadoop 23
Description
-------
Default values are not honoured when merging default schema
This addresses bug PIG-3318.
https://issues.apache.org/jira/browse/PIG-3318
Diffs (updated)
-----
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorage.java 1491556
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java 1491556
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroInputFormat.java 1491556
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroRecordReader.java 1491556
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/TestAvroStorage.java 1491562
Diff: https://reviews.apache.org/r/11135/diff/
Testing
-------
Yes
Thanks,
Viraj Bhat
Re: Review Request: PIG-3318 Patch to address default values when schemas
are merged in AvroStorage. It does this for Records containing primitive
values
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11135/#review21792
-----------------------------------------------------------
Ship it!
Ship It!
- Rohini Palaniswamy
On June 12, 2013, 2:05 a.m., Viraj Bhat wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11135/
> -----------------------------------------------------------
>
> (Updated June 12, 2013, 2:05 a.m.)
>
>
> Review request for pig and Rohini Palaniswamy.
>
>
> Description
> -------
>
> Default values are not honoured when merging default schema
>
>
> This addresses bug PIG-3318.
> https://issues.apache.org/jira/browse/PIG-3318
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorage.java 1491556
> http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java 1491556
> http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroRecordReader.java 1491556
> http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/TestAvroStorage.java 1491562
>
> Diff: https://reviews.apache.org/r/11135/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Viraj Bhat
>
>
Re: Review Request: PIG-3318 Patch to address default values when schemas
are merged in AvroStorage. It does this for Records containing primitive
values
Posted by Viraj Bhat <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11135/
-----------------------------------------------------------
(Updated June 12, 2013, 2:05 a.m.)
Review request for pig and Rohini Palaniswamy.
Changes
-------
Modified changes with formatting
Description
-------
Default values are not honoured when merging default schema
This addresses bug PIG-3318.
https://issues.apache.org/jira/browse/PIG-3318
Diffs (updated)
-----
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorage.java 1491556
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java 1491556
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroRecordReader.java 1491556
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/TestAvroStorage.java 1491562
Diff: https://reviews.apache.org/r/11135/diff/
Testing
-------
Yes
Thanks,
Viraj Bhat
Re: Review Request: PIG-3318 Patch to address default values when schemas
are merged in AvroStorage. It does this for Records containing primitive
values
Posted by Viraj Bhat <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11135/
-----------------------------------------------------------
(Updated June 11, 2013, 9:40 p.m.)
Review request for pig and Rohini Palaniswamy.
Changes
-------
Addressing comments in diff6
Description
-------
Default values are not honoured when merging default schema
This addresses bug PIG-3318.
https://issues.apache.org/jira/browse/PIG-3318
Diffs (updated)
-----
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorage.java 1491556
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java 1491556
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroRecordReader.java 1491556
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/TestAvroStorage.java 1491562
Diff: https://reviews.apache.org/r/11135/diff/
Testing
-------
Yes
Thanks,
Viraj Bhat
Re: Review Request: PIG-3318 Patch to address default values when schemas
are merged in AvroStorage. It does this for Records containing primitive
values
Posted by Viraj Bhat <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11135/
-----------------------------------------------------------
(Updated June 11, 2013, 3:04 a.m.)
Review request for pig and Rohini Palaniswamy.
Changes
-------
Updated patch
Description
-------
Default values are not honoured when merging default schema
This addresses bug PIG-3318.
https://issues.apache.org/jira/browse/PIG-3318
Diffs (updated)
-----
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorage.java 1491556
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java 1491556
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroRecordReader.java 1491556
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/TestAvroStorage.java 1491562
Diff: https://reviews.apache.org/r/11135/diff/
Testing
-------
Yes
Thanks,
Viraj Bhat
Re: Review Request: PIG-3318 Patch to address default values when schemas
are merged in AvroStorage. It does this for Records containing primitive
values
Posted by Viraj Bhat <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11135/
-----------------------------------------------------------
(Updated May 30, 2013, 2:28 a.m.)
Review request for pig and Rohini Palaniswamy.
Description
-------
Default values are not honoured when merging default schema
This addresses bug PIG-3318.
https://issues.apache.org/jira/browse/PIG-3318
Diffs
-----
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorage.java 1484564
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java 1484564
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroInputFormat.java 1484564
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroRecordReader.java 1484564
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/TestAvroStorage.java 1484564
Diff: https://reviews.apache.org/r/11135/diff/
Testing
-------
Yes
Thanks,
Viraj Bhat