You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by gi...@git.apache.org on 2017/08/16 03:35:46 UTC

[GitHub] javelinjs commented on a change in pull request #7411: [scala-package][spark] fix example script

javelinjs commented on a change in pull request #7411: [scala-package][spark] fix example script
URL: https://github.com/apache/incubator-mxnet/pull/7411#discussion_r133352986
 
 

 ##########
 File path: scala-package/spark/bin/run-mnist-example.sh
 ##########
 @@ -18,47 +18,62 @@
 # under the License.
 
 CURR_DIR=$(cd `dirname $0`; pwd)
-MODULE_DIR=$(cd $CURR_DIR/../; pwd)
-ROOT_DIR=$(cd $CURR_DIR/../../; pwd)
+SPARK_MODULE_DIR=$(cd $CURR_DIR/../; pwd)
+SCALA_PKG_DIR=$(cd $CURR_DIR/../../; pwd)
 
+OS=""
 
-LIB_DIR=${MODULE_DIR}/target/classes/lib
-JAR=${MODULE_DIR}/target/mxnet-spark_2.10-0.1.2-SNAPSHOT.jar
+if [ "$(uname)" == "Darwin" ]; then
+	# Do something under Mac OS X platform
+	OS='osx-x86_64-cpu'	
 
 Review comment:
   Could you make all indent to 2 spaces?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services