You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "flyingfish89 (via GitHub)" <gi...@apache.org> on 2023/02/06 10:50:08 UTC
[GitHub] [nuttx] flyingfish89 opened a new pull request, #8441: fix a bug of strtold
flyingfish89 opened a new pull request, #8441:
URL: https://github.com/apache/nuttx/pull/8441
## Summary
if input is -1e308,The output should be -100000000......
but the output is -inf
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8441: fix a bug of strtold
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #8441:
URL: https://github.com/apache/nuttx/pull/8441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] fjpanag commented on pull request #8441: fix a bug of strtold
Posted by "fjpanag (via GitHub)" <gi...@apache.org>.
fjpanag commented on PR #8441:
URL: https://github.com/apache/nuttx/pull/8441#issuecomment-1419335030
Indeed this PR fixed the issue, and tests were able to move forward.
However, now there is a new Lua test failing.
I guess it is related, but I won't have the time to investigate it today.
Please have a look bellow:
```
NuttShell (NSH) NuttX-12.0.0
nsh> lua
Lua 5.4.0 Copyright (C) 1994-2020 Lua.org, PUC-Rio
> assert(0e12 == 0 and .0 == 0 and 0. == 0 and .2e2 == 20 and 2.E-1 == 0.2)
stdin:1: malformed number near '0e12'
>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] flyingfish89 commented on pull request #8441: fix a bug of strtold
Posted by "flyingfish89 (via GitHub)" <gi...@apache.org>.
flyingfish89 commented on PR #8441:
URL: https://github.com/apache/nuttx/pull/8441#issuecomment-1420599636
Can you show me how to build your test program, and then I will fix the rest of the bugs as soon as possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] flyingfish89 commented on pull request #8441: fix a bug of strtold
Posted by "flyingfish89 (via GitHub)" <gi...@apache.org>.
flyingfish89 commented on PR #8441:
URL: https://github.com/apache/nuttx/pull/8441#issuecomment-1420051788
> Indeed this PR fixed the issue, and tests were able to move forward.
>
> However, now there is a new Lua test failing. I guess it is related, but I won't have the time to investigate it today.
>
> Please have a look bellow:
>
> ```
> NuttShell (NSH) NuttX-12.0.0
> nsh> lua
> Lua 5.4.0 Copyright (C) 1994-2020 Lua.org, PUC-Rio
> > assert(0e12 == 0 and .0 == 0 and 0. == 0 and .2e2 == 20 and 2.E-1 == 0.2)
> stdin:1: malformed number near '0e12'
> >
> ```
could you please change strtold to look like this and then test if there are any other questions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] flyingfish89 commented on pull request #8441: fix a bug of strtold
Posted by "flyingfish89 (via GitHub)" <gi...@apache.org>.
flyingfish89 commented on PR #8441:
URL: https://github.com/apache/nuttx/pull/8441#issuecomment-1420604494
> Can you show me how to build your test program, and then I will fix the rest of the bugs as soon as possible
I ’m sorry about this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] fjpanag commented on pull request #8441: fix a bug of strtold
Posted by "fjpanag (via GitHub)" <gi...@apache.org>.
fjpanag commented on PR #8441:
URL: https://github.com/apache/nuttx/pull/8441#issuecomment-1420590008
@flyingfish89 I tried the above change, and indeed it fixes the issue. The tests move forward.
However, I get a new failure at:
```Lua
assert(tonumber'+ 0.01' == nil and tonumber'+.e1' == nil and
tonumber'1e' == nil and tonumber'1.0e+' == nil and
tonumber'.' == nil)
```
After commenting out the failing tests, I get a new failure at:
```Lua
assert(f(tonumber(' ')) == nil)
```
*(And maybe there are more after that...)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] fjpanag commented on pull request #8441: fix a bug of strtold
Posted by "fjpanag (via GitHub)" <gi...@apache.org>.
fjpanag commented on PR #8441:
URL: https://github.com/apache/nuttx/pull/8441#issuecomment-1420647794
> I ’m sorry about this.
Don't worry!
So, I am using the official Lua tests suite.
Tests can be found [here](https://www.lua.org/tests/).
I am using Lua v5.2.4, so I am running [these](https://www.lua.org/tests/lua-5.2.2-tests.tar.gz) tests.
The problematic file is `math.lua`, as you guessed, which is also attached. So you can concentrate on this, instead of running all the tests.
Note that the NuttX config is for Lua v5.4, while I am running v5.2.
However, as it turns out, all issues are reproducible on the standard config, using Lua shell directly through NSH.
So, you may just try on `sim:lua`.
Feel free to ask for anything that you may need me to test out, or for any Lua-related help.
[math.lua.txt](https://github.com/apache/nuttx/files/10674643/math.lua.txt)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] fjpanag commented on pull request #8441: fix a bug of strtold
Posted by "fjpanag (via GitHub)" <gi...@apache.org>.
fjpanag commented on PR #8441:
URL: https://github.com/apache/nuttx/pull/8441#issuecomment-1420652742
As a side note, the Lua tests are quite extensive. They test both the language itself but also the system it runs on.
Lua depends on standards compliance, and the tests exercise this in many places.
I think that it would be a great addition to have CI run these tests.
Although strictly speaking it is not NuttX testing, it has indicated me lots of OS-level problems in the past.
It seems of great value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] flyingfish89 commented on pull request #8441: fix a bug of strtold
Posted by "flyingfish89 (via GitHub)" <gi...@apache.org>.
flyingfish89 commented on PR #8441:
URL: https://github.com/apache/nuttx/pull/8441#issuecomment-1420668739
ok,thanks for your suggestion and I'll use it in my future work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org