You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "JiajunBernoulli (via GitHub)" <gi...@apache.org> on 2023/06/15 01:51:12 UTC

[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #3260: [CALCITE-5751] Add ARRAY_APPEND, ARRAY_POSITION, ARRAY_REMOVE, ARRAY_…

JiajunBernoulli commented on code in PR #3260:
URL: https://github.com/apache/calcite/pull/3260#discussion_r1230329536


##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -3894,6 +3894,14 @@ public static List compact(List list) {
     return result;
   }
 
+  /** Support the ARRAY_APPEND function. */
+  public static List arrayAppend(List list, Object element) {
+    final List result = new ArrayList(list.size() + 1);

Review Comment:
   Can you resolve it?
   
   ![image](https://github.com/apache/calcite/assets/45968640/bee8250d-cf12-423c-9d24-757816750069)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org