[GitHub] [apisix] gxthrj commented on a change in pull request #2279: feat: Add labels for upstream object

[GitBox <gi...@apache.org>]

gxthrj commented on a change in pull request #2279:
URL: https://github.com/apache/apisix/pull/2279#discussion_r493261175



##########
File path: apisix/schema_def.lua
##########
@@ -332,6 +332,10 @@ local upstream_schema = {
             description = "enable websocket for request",
             type        = "boolean"
         },
+        labels = {
+            description = "key/value pairs to specify attributes",

Review comment:
       I think `key-value` is more descriptive, and we can make some conventions on the `key`, which is more readable.
   e.g.
   ```
   lables: {
       "version": "v1"
   }
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org