You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Uwe Schindler (JIRA)" <ji...@apache.org> on 2015/11/20 19:30:11 UTC
[jira] [Comment Edited] (LUCENE-6902) Fail fsync immediately
[ https://issues.apache.org/jira/browse/LUCENE-6902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15018471#comment-15018471 ]
Uwe Schindler edited comment on LUCENE-6902 at 11/20/15 6:29 PM:
-----------------------------------------------------------------
Hi the patch fails on windows, because it does not swallow the IOException when fsyncing a directory. I will correct it and upload new patch. In fact, you catched the exception at the wrong place!
was (Author: thetaphi):
Hi the patch fails on windows, because it does not swallow the IOException when fsyncing a directory. I will correct it and upload new patch.
> Fail fsync immediately
> ----------------------
>
> Key: LUCENE-6902
> URL: https://issues.apache.org/jira/browse/LUCENE-6902
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/store
> Affects Versions: 5.3.1
> Reporter: Daniel Mitterdorfer
> Assignee: Uwe Schindler
> Priority: Minor
> Fix For: 5.4
>
> Attachments: ioutils-fsync-fail-fast.patch
>
>
> While analysing a build issue in Elasticsearch I stumpled upon org.apache.lucene.util.IOUtils.fsync. It has a retry loop in fsync whenever an IOException occurs. However, there are lots of instances where a retry is not useful, e.g. when a channel has been closed, a ClosedChannelException is thrown and IOUtils#fsync still tries to fsync multiple times on the closed channel.
> After bringing the issue to Robert's attention, he even opted for removing the retry logic entirely for fsyncing.
> Please find attached a patch that removes the retry logic.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org