You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Antonio Petrelli (JIRA)" <ji...@apache.org> on 2006/10/02 13:52:15 UTC
[jira] Created: (SB-49) InsertTag.preprocessAttribute is called
even if an attribute does not need preprocessing
InsertTag.preprocessAttribute is called even if an attribute does not need preprocessing
----------------------------------------------------------------------------------------
Key: SB-49
URL: http://issues.apache.org/struts/browse/SB-49
Project: Sandbox
Issue Type: Improvement
Components: Tiles
Affects Versions: 2.0
Environment: N/A (it's a design issue)
Reporter: Antonio Petrelli
Priority: Minor
The InsertTag.preprocessAttribute is called for every attribute, even those that are configured via Tiles configuration files, that are correct after the end of the creation.
Therefore there is a (pretty small) performance problem. Currently is a case of a null check and a String comparison (plus a call, obiously), but in the future it could be more complex.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SB-49) AttributeTag.calculateType is called even
if an attribute does not need preprocessing
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/SB-49?page=all ]
Antonio Petrelli updated SB-49:
-------------------------------
Summary: AttributeTag.calculateType is called even if an attribute does not need preprocessing (was: InsertTag.preprocessAttribute is called even if an attribute does not need preprocessing)
Description:
The AttributeTag.calculateType method is called for every attribute, even those that have been already preprocessed.
Therefore there is a (pretty small) performance problem. Currently is a case of a null check and a String comparison (plus a call, obiously), but in the future it could be more complex.
was:
The InsertTag.preprocessAttribute is called for every attribute, even those that are configured via Tiles configuration files, that are correct after the end of the creation.
Therefore there is a (pretty small) performance problem. Currently is a case of a null check and a String comparison (plus a call, obiously), but in the future it could be more complex.
Updated because InsertTag has been splitted
> AttributeTag.calculateType is called even if an attribute does not need preprocessing
> -------------------------------------------------------------------------------------
>
> Key: SB-49
> URL: http://issues.apache.org/struts/browse/SB-49
> Project: Sandbox
> Issue Type: Improvement
> Components: Tiles
> Affects Versions: 2.0
> Environment: N/A (it's a design issue)
> Reporter: Antonio Petrelli
> Priority: Minor
>
> The AttributeTag.calculateType method is called for every attribute, even those that have been already preprocessed.
> Therefore there is a (pretty small) performance problem. Currently is a case of a null check and a String comparison (plus a call, obiously), but in the future it could be more complex.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SB-49) InsertTag.preprocessAttribute is called
even if an attribute does not need preprocessing
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/SB-49?page=comments#action_38594 ]
Antonio Petrelli commented on SB-49:
------------------------------------
The code put in InsertTag has been put in AttributeTag, but then the "preprocessAttribute" has been removed for the container refactoring.
I am waiting to know if this code has been removed or moved to update this issue.
> InsertTag.preprocessAttribute is called even if an attribute does not need preprocessing
> ----------------------------------------------------------------------------------------
>
> Key: SB-49
> URL: http://issues.apache.org/struts/browse/SB-49
> Project: Sandbox
> Issue Type: Improvement
> Components: Tiles
> Affects Versions: 2.0
> Environment: N/A (it's a design issue)
> Reporter: Antonio Petrelli
> Priority: Minor
>
> The InsertTag.preprocessAttribute is called for every attribute, even those that are configured via Tiles configuration files, that are correct after the end of the creation.
> Therefore there is a (pretty small) performance problem. Currently is a case of a null check and a String comparison (plus a call, obiously), but in the future it could be more complex.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SB-49) AttributeTag.calculateType is called even
if an attribute does not need preprocessing
Posted by "David H. DeWolf (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/SB-49?page=comments#action_38832 ]
David H. DeWolf commented on SB-49:
-----------------------------------
This should also be done within the container if at all possible. Some of it has allready been moved. This can be done after an initial 2.0.0 release.
> AttributeTag.calculateType is called even if an attribute does not need preprocessing
> -------------------------------------------------------------------------------------
>
> Key: SB-49
> URL: http://issues.apache.org/struts/browse/SB-49
> Project: Sandbox
> Issue Type: Improvement
> Components: Tiles
> Affects Versions: 2.0
> Environment: N/A (it's a design issue)
> Reporter: Antonio Petrelli
> Priority: Minor
> Fix For: 2.0.1
>
>
> The AttributeTag.calculateType method is called for every attribute, even those that have been already preprocessed.
> Therefore there is a (pretty small) performance problem. Currently is a case of a null check and a String comparison (plus a call, obiously), but in the future it could be more complex.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SB-49) AttributeTag.calculateType is called even
if an attribute does not need preprocessing
Posted by "David H. DeWolf (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/SB-49?page=all ]
David H. DeWolf updated SB-49:
------------------------------
Fix Version/s: 2.0.1
> AttributeTag.calculateType is called even if an attribute does not need preprocessing
> -------------------------------------------------------------------------------------
>
> Key: SB-49
> URL: http://issues.apache.org/struts/browse/SB-49
> Project: Sandbox
> Issue Type: Improvement
> Components: Tiles
> Affects Versions: 2.0
> Environment: N/A (it's a design issue)
> Reporter: Antonio Petrelli
> Priority: Minor
> Fix For: 2.0.1
>
>
> The AttributeTag.calculateType method is called for every attribute, even those that have been already preprocessed.
> Therefore there is a (pretty small) performance problem. Currently is a case of a null check and a String comparison (plus a call, obiously), but in the future it could be more complex.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira