[GitHub] [iotdb] JackieTien97 commented on a diff in pull request #8411: [IOTDB-5172] Fix SingleDeviceViewNode can't get outputColumnTypes when it's isolated

[GitBox <gi...@apache.org>]

JackieTien97 commented on code in PR #8411:
URL: https://github.com/apache/iotdb/pull/8411#discussion_r1045339825


##########
server/src/main/java/org/apache/iotdb/db/mpp/plan/planner/plan/node/process/SingleDeviceViewNode.java:
##########
@@ -36,10 +36,12 @@ public class SingleDeviceViewNode extends SingleChildProcessNode {
   private final String device;
 
   // To reduce memory cost, SingleDeviceViewNode doesn't serialize and deserialize
-  // outputColumnNames.
-  // It just rebuilds using the infos from parent node.
-  private List<String> outputColumnNames;
+  // outputColumnNames.It just rebuilds using the infos from parent node.
+  private final List<String> outputColumnNames;
   private final List<Integer> deviceToMeasurementIndexes;
+  // For some isolated SingleDeviceViewNodes without parent node, they need to cache
+  // the outputColumnNames themselves.
+  private boolean cacheOutputColumnNames = false;

Review Comment:
   Add another UT case to test serialize and deserialize for SingleDeviceViewNode when `cacheOutputColumnNames` is `true`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org