[GitHub] [spark] LuciferYang commented on a diff in pull request #39854: [SPARK-42284][CONNECT] Make sure connect server assembly is built before running client tests - SBT

["LuciferYang (via GitHub)" <gi...@apache.org>]

LuciferYang commented on code in PR #39854:
URL: https://github.com/apache/spark/pull/39854#discussion_r1093494467


##########
project/SparkBuild.scala:
##########
@@ -851,6 +851,9 @@ object SparkConnectClient {
       )
     },
 
+    // Make sure the connect server assembly jar is available for testing.
+    test := ((Test / test) dependsOn (LocalProject("connect") / assembly)).value,

Review Comment:
   looks perfect,  does maven have a similar solution?
   
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org