[GitHub] [netbeans] timboudreau edited a comment on pull request #2232: [NETBEANS-4699] Make it easy to create dynamically updated ProxyLookup instances without subclassing

[GitBox <gi...@apache.org>]

timboudreau edited a comment on pull request #2232:
URL: https://github.com/apache/netbeans/pull/2232#issuecomment-671105098


   > Am I missing something? Doesn't it throw an IllegalStateException in that scenario?
   
   It does now, per Jarda's request.  If I weren't at this moment attempting once again to run tests against a sub-branch that modifies a bunch of modules (including the default lookup itself) to use this patch I'd fix it right now.  Feel free to fix in the meantime, or I'll get to it this evening, once my laptop isn't being brought to its knees by tests.
   
   This ought to be perfectly safe for the current release - nothing uses the code without the patches I'm going to submit as a separate pull request once I'm sure they don't break anything.  I, for one, have two large NetBeans-based codebases I would immediately begin using ProxyLookup.Controller in if it were available, with probably 10-12 ProxyLookup subclasses that could be eliminated.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists