You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/23 18:28:14 UTC
[GitHub] [airflow] zhangyi-hu opened a new pull request #16617: rename test_cycle to check_cycle
zhangyi-hu opened a new pull request #16617:
URL: https://github.com/apache/airflow/pull/16617
closes: #16608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #16617: Rename test_cycle to check_cycle
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16617:
URL: https://github.com/apache/airflow/pull/16617#issuecomment-867116572
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] zhangyi-hu commented on pull request #16617: Rename test_cycle to check_cycle
Posted by GitBox <gi...@apache.org>.
zhangyi-hu commented on pull request #16617:
URL: https://github.com/apache/airflow/pull/16617#issuecomment-867655592
> @zhangyi-hu can you rebase to master please
Rebased to git@github.com:apache/airflow.git main branch and pushed by force.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #16617: Rename test_cycle to check_cycle
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #16617:
URL: https://github.com/apache/airflow/pull/16617#issuecomment-867846740
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] zhangyi-hu commented on pull request #16617: Rename test_cycle to check_cycle
Posted by GitBox <gi...@apache.org>.
zhangyi-hu commented on pull request #16617:
URL: https://github.com/apache/airflow/pull/16617#issuecomment-867778016
> Some black formatting needed :(
formatted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #16617: Rename test_cycle to check_cycle
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #16617:
URL: https://github.com/apache/airflow/pull/16617#discussion_r658075860
##########
File path: airflow/utils/dag_cycle_tester.py
##########
@@ -25,6 +25,21 @@
def test_cycle(dag):
+ """
+ A wrapper function of `check_cycle` for backward compatibility purpose.
+ New code should use `check_cycle` instead since this function name `test_cycle` starts with 'test_' and
+ will be considered as a unit test by pytest, resulting in failure.
+ """
+ from warnings import warn
Review comment:
Why does this import need to be local?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16617: Rename test_cycle to check_cycle
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16617:
URL: https://github.com/apache/airflow/pull/16617#issuecomment-867748304
Some black formatting needed :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] xinbinhuang commented on a change in pull request #16617: Rename test_cycle to check_cycle
Posted by GitBox <gi...@apache.org>.
xinbinhuang commented on a change in pull request #16617:
URL: https://github.com/apache/airflow/pull/16617#discussion_r657386846
##########
File path: airflow/utils/dag_cycle_tester.py
##########
@@ -25,6 +25,17 @@
def test_cycle(dag):
+ """
+ A wrapper function of check_cycle for backward compatibility reason.
+ New code should use check_cycle instead, since this function name test_cycle starts with test_ and pytest
Review comment:
```suggestion
A wrapper function of `check_cycle` for backward compatibility reason.
New code should use `check_cycle` instead, since this function name `test_cycle` starts with 'test_' and pytest
```
##########
File path: airflow/utils/dag_cycle_tester.py
##########
@@ -25,6 +25,17 @@
def test_cycle(dag):
+ """
+ A wrapper function of check_cycle for backward compatibility reason.
+ New code should use check_cycle instead, since this function name test_cycle starts with test_ and pytest
+ will consider it as a unit test causing failure.
+ """
+ from warnings import warn
+ warn("Deprecated, please use check_cycle at the same module instead.", DeprecationWarning)
Review comment:
```suggestion
warn("Deprecated, please use `check_cycle` at the same module instead.", DeprecationWarning)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #16617: Rename test_cycle to check_cycle
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #16617:
URL: https://github.com/apache/airflow/pull/16617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] xinbinhuang commented on pull request #16617: Rename test_cycle to check_cycle
Posted by GitBox <gi...@apache.org>.
xinbinhuang commented on pull request #16617:
URL: https://github.com/apache/airflow/pull/16617#issuecomment-867384614
@zhangyi-hu can you rebase to master please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] xinbinhuang commented on a change in pull request #16617: Rename test_cycle to check_cycle
Posted by GitBox <gi...@apache.org>.
xinbinhuang commented on a change in pull request #16617:
URL: https://github.com/apache/airflow/pull/16617#discussion_r657385033
##########
File path: airflow/utils/dag_cycle_tester.py
##########
@@ -25,6 +25,17 @@
def test_cycle(dag):
+ """
+ A wrapper function of check_cycle for backward compatibility reason.
+ New code should use check_cycle instead, since this function name test_cycle starts with test_ and pytest
+ will consider it as a unit test causing failure.
Review comment:
Small nit:
```suggestion
New code should use check_cycle instead. Since the function test_cycle starts with test_, pytest
will consider it as a unit test and cause failure.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] zhangyi-hu commented on a change in pull request #16617: Rename test_cycle to check_cycle
Posted by GitBox <gi...@apache.org>.
zhangyi-hu commented on a change in pull request #16617:
URL: https://github.com/apache/airflow/pull/16617#discussion_r658093334
##########
File path: airflow/utils/dag_cycle_tester.py
##########
@@ -25,6 +25,21 @@
def test_cycle(dag):
+ """
+ A wrapper function of `check_cycle` for backward compatibility purpose.
+ New code should use `check_cycle` instead since this function name `test_cycle` starts with 'test_' and
+ will be considered as a unit test by pytest, resulting in failure.
+ """
+ from warnings import warn
Review comment:
We discourage the usage of this function and warn that it is deprecated, as a result, its usage can be predicted to be rare. This 'warn' is only used here so doesn't need to be imported at the module level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] xinbinhuang commented on a change in pull request #16617: Rename test_cycle to check_cycle
Posted by GitBox <gi...@apache.org>.
xinbinhuang commented on a change in pull request #16617:
URL: https://github.com/apache/airflow/pull/16617#discussion_r657386152
##########
File path: airflow/utils/dag_cycle_tester.py
##########
@@ -25,6 +25,17 @@
def test_cycle(dag):
+ """
+ A wrapper function of check_cycle for backward compatibility reason.
+ New code should use check_cycle instead, since this function name test_cycle starts with test_ and pytest
+ will consider it as a unit test causing failure.
+ """
+ from warnings import warn
+ warn("Deprecated, please use check_cycle at the same module instead.", DeprecationWarning)
Review comment:
```suggestion
warn("Deprecated, please use `check_cycle` at the same module instead.", DeprecationWarning)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #16617: Rename test_cycle to check_cycle
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #16617:
URL: https://github.com/apache/airflow/pull/16617#discussion_r657794512
##########
File path: airflow/utils/dag_cycle_tester.py
##########
@@ -25,6 +25,17 @@
def test_cycle(dag):
+ """
+ A wrapper function of `check_cycle` for backward compatibility purpose.
+ New code should use `check_cycle` instead since this function name `test_cycle` starts with 'test_' and
+ will be considered as a unit test by pytest, resulting in failure.
+ """
+ from warnings import warn
+ warn("Deprecated, please use `check_cycle` at the same module instead.", DeprecationWarning)
Review comment:
```suggestion
warn(
"Deprecated, please use `check_cycle` at the same module instead.",
DeprecationWarning,
stacklevel=2,
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #16617: rename test_cycle to check_cycle
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #16617:
URL: https://github.com/apache/airflow/pull/16617#issuecomment-867064352
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org