[GitHub] [iceberg] rdblue commented on a diff in pull request #5391: Python: Add Hive Catalog

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #5391:
URL: https://github.com/apache/iceberg/pull/5391#discussion_r933884571


##########
python/vendor/README.md:
##########
@@ -0,0 +1,29 @@
+# Vendor packages
+
+Some packages we want to maintain in the repository itself, because there is no good 3rd party alternative.
+
+## FB303 Thrift client
+
+fb303 is a base Thrift service and a common set of functionality for querying stats, options, and other information from a service.
+
+```bash
+rm -f /tmp/fb303.thrift
+rm -rf fb303
+curl https://raw.githubusercontent.com/apache/thrift/master/contrib/fb303/if/fb303.thrift > /tmp/fb303.thrift
+rm -rf /tmp/gen-py/
+thrift -gen py -o /tmp/ /tmp/fb303.thrift
+mv /tmp/gen-py/fb303 fb303
+```
+
+# Hive Metastore Thrift definition
+
+The thrift definition require the fb303 service as a dependency
+
+```bash
+rm -rf /tmp/hive
+mkdir -p /tmp/hive/share/fb303/if/
+curl https://raw.githubusercontent.com/apache/thrift/master/contrib/fb303/if/fb303.thrift > /tmp/hive/share/fb303/if/fb303.thrift
+curl https://raw.githubusercontent.com/apache/hive/master/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift > /tmp/hive/hive_metastore.thrift

Review Comment:
   Do we need the steps above if fb303 is included when building the Hive interfaces?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org